Patch Detail
Show a patch.
GET /api/patches/31/?format=api
{ "id": 31, "url": "https://patchwork.libcamera.org/api/patches/31/?format=api", "web_url": "https://patchwork.libcamera.org/patch/31/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181211191011.6315-2-laurent.pinchart@ideasonboard.com>", "date": "2018-12-11T19:10:06", "name": "[libcamera-devel,1/6] build: Clean up file names variables", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "45b85c3bb4b70feb5f9b4c7e67f75d673de3d096", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/31/mbox/", "series": [ { "id": 16, "url": "https://patchwork.libcamera.org/api/series/16/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=16", "date": "2018-12-11T19:10:05", "name": "Documentation: Initial Doxygen support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/16/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/31/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/31/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EF7760B10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Dec 2018 20:09:40 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F1BE564\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Dec 2018 20:09:39 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544555379;\n\tbh=kQfdXFYxkz4If6UH4SrNW9VyH3TrlPnRvjYzzDW+qe4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fSMHTkEVpzyq0KtYsiI97fPup1/T1yRrMAoYvwKArK3zpbhofF3u31OHdruxfWEf4\n\tdai5LWIXjI5YdNipmP4lzHL90DmxHtb43ZzBHvWBEgL4zK/8LrP2zc1ll1Gl5tyhey\n\tvhkBlGeseHR3jYG0XuuC+En4yjRv+dzkblCip51o=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 11 Dec 2018 21:10:06 +0200", "Message-Id": "<20181211191011.6315-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181211191011.6315-1-laurent.pinchart@ideasonboard.com>", "References": "<20181211191011.6315-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/6] build: Clean up file names variables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 11 Dec 2018 19:09:40 -0000" }, "content": "The build system defines two variables, public_api and sources, that\nstore the names of the public headers and the source files respectively.\nThese files will need to be referenced when generating documentation\nfrom source code, so let's make the variable names more descriptive:\n\n- Rename public_api to libcamera_api and use the files() function\n- Rename sources to libcamera_sources\n- Add a libcamera_headers variable to hold the internal headers\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/meson.build | 6 +++---\n src/libcamera/meson.build | 9 +++++++--\n 2 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 8fb21e983832..8c82675a25d2 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -1,6 +1,6 @@\n-public_api = [\n+libcamera_api = files([\n 'libcamera.h',\n-]\n+])\n \n-install_headers(public_api,\n+install_headers(libcamera_api,\n subdir : 'libcamera')\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex fe38f8b2b5b4..0c44b5ab58fb 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -1,14 +1,19 @@\n-sources = files([\n+libcamera_sources = files([\n 'log.cpp',\n 'main.cpp',\n ])\n \n+libcamera_headers = files([\n+ 'include/log.h',\n+ 'include/utils.h',\n+])\n+\n includes = [\n libcamera_includes,\n include_directories('include'),\n ]\n \n libcamera = shared_library('camera',\n- sources,\n+ libcamera_sources,\n install : true,\n include_directories : includes)\n", "prefixes": [ "libcamera-devel", "1/6" ] }