Patch Detail
Show a patch.
GET /api/patches/3059/?format=api
{ "id": 3059, "url": "https://patchwork.libcamera.org/api/patches/3059/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3059/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200309123319.630-2-naush@raspberrypi.com>", "date": "2020-03-09T12:33:14", "name": "[libcamera-devel,v2,1/6] libcamera: controls: Specify manual gain units and change exposure units", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b910e41370aa8d285e6ab008252e6b42ce9c0964", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3059/mbox/", "series": [ { "id": 715, "url": "https://patchwork.libcamera.org/api/series/715/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=715", "date": "2020-03-09T12:33:13", "name": "Patchset for libcamera controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/715/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3059/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3059/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6001562923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 13:35:31 +0100 (CET)", "by mail-wr1-x441.google.com with SMTP id v11so10850122wrm.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 09 Mar 2020 05:35:31 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tz135sm25693827wmc.20.2020.03.09.05.35.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Mar 2020 05:35:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=fuXO2iK3dTw0vD630Rg4SRSmZfkfCAiE+45ME/pLDOA=;\n\tb=GOTEtg+KGSBoDOGmIfWM0xAInpOfXPO62MhBFevnUEnJsNjpmi/pvBsf9VioooFRqI\n\tfyYs7GechsS71s20y6dPUtuy0oYy3aDKeluWdNavygkTJAr8vkV+mWsT28R+Lnj1wzl8\n\t9X8g7UZTihrCwHFpbPE6fJU+rde4y9RcLcTWAv1DlYF1mx3oLHl/ch7hxvfKc1HQrFnE\n\tUJ7PmlcUUo4Nd7s3JkkflF7nuPStsbJiXS7IpCuhKP4/ISI96Um7keZOuO1xKZNe8bGc\n\tonvcUzkRLoFf06WkNono1tZMNJ64HaA+tUgUAl+zrbkyWUMfchn1q1PBBCP6Wh2iLCno\n\tNdrw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=fuXO2iK3dTw0vD630Rg4SRSmZfkfCAiE+45ME/pLDOA=;\n\tb=cDaFcIW16WOJSB7/S9nBjG0dW86bSEGknea7CqRFQfp1r/BWW3CJWbzcIQmOXp2CmN\n\tPb//QrZWCUKqSJCUfYj/w37fqCJwviRhSKYHDIiwXVeHkiadcfVDDMAy+l+ut1yhIBqh\n\tvF3Np0iF/07dEaNDATIC01U0SIs9SpnEvf9Zug0yLAAy/I6iNuMMINgehLFXxmIhR6dB\n\tbHXQ5ls9bem27vpz8XmxsiwVuJyGLXshHFpgIF+uq8iRiBVLy4juBzW7bKC7wjRUUrUC\n\t0NTQKnFTes1tk4vf2KPiWRteHI4+LoIbd1Gc6B59vicAyObhVe3aiXN4UoQ5y6/tfrCZ\n\ttiFg==", "X-Gm-Message-State": "ANhLgQ3LMBlvkpNfA0711oD5ch3aIfyIhx0IWPpYwi+5+Z4+v/wsHGsc\n\t1qeDN7uFSVvJcL9+k08GfPVePxaNI0Axkw==", "X-Google-Smtp-Source": "ADFU+vsgA0Z38VwufkEU3Bc+x3Tuvmaq/izGmjFl/lbtw8rMzv+uV6zRnX8B4ZtUXbt8gAPNhedUbw==", "X-Received": "by 2002:adf:fe41:: with SMTP id m1mr5890515wrs.355.1583757330988;\n\tMon, 09 Mar 2020 05:35:30 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Mar 2020 12:33:14 +0000", "Message-Id": "<20200309123319.630-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200309123319.630-1-naush@raspberrypi.com>", "References": "<20200309123319.630-1-naush@raspberrypi.com>", "Subject": "[libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 09 Mar 2020 12:35:31 -0000" }, "content": "Use micro-seconds for ManualExposure. This is changed from milli-\nseconds. The latter would not allow very low exposure times.\n\nManualGain switch to use a float to allow fractional gain adjustments.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4befec74..5bbe65ae 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -44,10 +44,17 @@ controls:\n \n - ManualExposure:\n type: int32_t\n- description: Specify a fixed exposure time in milli-seconds\n+ description: |\n+ Specify a fixed exposure time in micro-seconds to be applied in the\n+ sensor device.\n+\n+ \\sa ManualGain\n \n - ManualGain:\n- type: int32_t\n- description: Specify a fixed gain parameter\n+ type: float\n+ description: |\n+ Specify a fixed gain value to be applied in the pipeline. This gain is\n+ applied to all colour channels.\n \n+ \\sa ManualExposure\n ...\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }