From patchwork Mon Mar 9 12:33:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 3059 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6001562923 for ; Mon, 9 Mar 2020 13:35:31 +0100 (CET) Received: by mail-wr1-x441.google.com with SMTP id v11so10850122wrm.9 for ; Mon, 09 Mar 2020 05:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fuXO2iK3dTw0vD630Rg4SRSmZfkfCAiE+45ME/pLDOA=; b=GOTEtg+KGSBoDOGmIfWM0xAInpOfXPO62MhBFevnUEnJsNjpmi/pvBsf9VioooFRqI fyYs7GechsS71s20y6dPUtuy0oYy3aDKeluWdNavygkTJAr8vkV+mWsT28R+Lnj1wzl8 9X8g7UZTihrCwHFpbPE6fJU+rde4y9RcLcTWAv1DlYF1mx3oLHl/ch7hxvfKc1HQrFnE UJ7PmlcUUo4Nd7s3JkkflF7nuPStsbJiXS7IpCuhKP4/ISI96Um7keZOuO1xKZNe8bGc onvcUzkRLoFf06WkNono1tZMNJ64HaA+tUgUAl+zrbkyWUMfchn1q1PBBCP6Wh2iLCno Ndrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fuXO2iK3dTw0vD630Rg4SRSmZfkfCAiE+45ME/pLDOA=; b=cDaFcIW16WOJSB7/S9nBjG0dW86bSEGknea7CqRFQfp1r/BWW3CJWbzcIQmOXp2CmN Pb//QrZWCUKqSJCUfYj/w37fqCJwviRhSKYHDIiwXVeHkiadcfVDDMAy+l+ut1yhIBqh vF3Np0iF/07dEaNDATIC01U0SIs9SpnEvf9Zug0yLAAy/I6iNuMMINgehLFXxmIhR6dB bHXQ5ls9bem27vpz8XmxsiwVuJyGLXshHFpgIF+uq8iRiBVLy4juBzW7bKC7wjRUUrUC 0NTQKnFTes1tk4vf2KPiWRteHI4+LoIbd1Gc6B59vicAyObhVe3aiXN4UoQ5y6/tfrCZ tiFg== X-Gm-Message-State: ANhLgQ3LMBlvkpNfA0711oD5ch3aIfyIhx0IWPpYwi+5+Z4+v/wsHGsc 1qeDN7uFSVvJcL9+k08GfPVePxaNI0Axkw== X-Google-Smtp-Source: ADFU+vsgA0Z38VwufkEU3Bc+x3Tuvmaq/izGmjFl/lbtw8rMzv+uV6zRnX8B4ZtUXbt8gAPNhedUbw== X-Received: by 2002:adf:fe41:: with SMTP id m1mr5890515wrs.355.1583757330988; Mon, 09 Mar 2020 05:35:30 -0700 (PDT) Received: from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id z135sm25693827wmc.20.2020.03.09.05.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 05:35:30 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 9 Mar 2020 12:33:14 +0000 Message-Id: <20200309123319.630-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200309123319.630-1-naush@raspberrypi.com> References: <20200309123319.630-1-naush@raspberrypi.com> Subject: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify manual gain units and change exposure units X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 12:35:31 -0000 Use micro-seconds for ManualExposure. This is changed from milli- seconds. The latter would not allow very low exposure times. ManualGain switch to use a float to allow fractional gain adjustments. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham --- src/libcamera/control_ids.yaml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 4befec74..5bbe65ae 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -44,10 +44,17 @@ controls: - ManualExposure: type: int32_t - description: Specify a fixed exposure time in milli-seconds + description: | + Specify a fixed exposure time in micro-seconds to be applied in the + sensor device. + + \sa ManualGain - ManualGain: - type: int32_t - description: Specify a fixed gain parameter + type: float + description: | + Specify a fixed gain value to be applied in the pipeline. This gain is + applied to all colour channels. + \sa ManualExposure ...