Patch Detail
Show a patch.
GET /api/patches/27607/?format=api
{ "id": 27607, "url": "https://patchwork.libcamera.org/api/patches/27607/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27607/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260804101949.353266-6-barnabas.pocze@ideasonboard.com>", "date": "2026-08-04T10:19:44", "name": "[RFC,v1,05/10] libcamera: egl: Add `resetEGLContext()`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2d1410891bf26b1a09c8c769a509008d9a593af1", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27607/mbox/", "series": [ { "id": 6105, "url": "https://patchwork.libcamera.org/api/series/6105/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6105", "date": "2026-08-04T10:19:39", "name": "libcamera: software_isp: debayer_egl: Remove some leaks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6105/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27607/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27607/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1608C330A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2026 10:20:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E7ED680A3;\n\tTue, 4 Aug 2026 12:19:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 666726807C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:19:53 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE95ADA8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:18:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OF5aKbJH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838723;\n\tbh=/FOOkT8HkB0/KvseZFNzxHMIiyA7lcxFFBeOKQD5Z/U=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=OF5aKbJHj7g9dYC2F77mJ+BQiTlIcfxX8n+oNL1UYI9WuZ6BOIqViDjLCh9/e/kgm\n\tYKFT68YdZ9HfhnBYjTfNvPTUeJCYzwZHAgAEMfrbp1sI61XzQdfdEUzVpug6LG2rjW\n\tFjRVh81dxhNl+/jFTQcSycro9hz3HnBWLZnctv5g=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 05/10] libcamera: egl: Add `resetEGLContext()`", "Date": "Tue, 4 Aug 2026 12:19:44 +0200", "Message-ID": "<20260804101949.353266-6-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "References": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a function that undoes the effects of `initEGLContext()`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/egl.h | 1 +\n src/libcamera/egl.cpp | 21 +++++++++++++++++----\n 2 files changed, 18 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex fb77225ac4..e18bb91f4d 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -103,6 +103,7 @@ public:\n \t~eGL();\n \n \tint initEGLContext();\n+\tvoid resetEGLContext();\n \tstatic EGLDisplay probeDisplay();\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 3de5fab816..6b50e7bb77 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -71,14 +71,13 @@ eGL::eGL(EGLDisplay display)\n }\n \n /**\n- * \\brief Destroy the EGL helper\n+ * \\brief Release all EGL resources\n *\n- * Destroys the EGL context and surface if they were successfully created.\n+ * Equivalent to calling resetEGLContext().\n */\n eGL::~eGL()\n {\n-\tif (context_ != EGL_NO_CONTEXT)\n-\t\teglDestroyContext(display_, context_);\n+\tresetEGLContext();\n }\n \n /**\n@@ -436,6 +435,20 @@ fail:\n \treturn -ENODEV;\n }\n \n+/**\n+ * \\brief Destroy the EGL context\n+ *\n+ * This function destroys the EGL context created by initEGLContext().\n+ */\n+void eGL::resetEGLContext()\n+{\n+\tif (context_ != EGL_NO_CONTEXT)\n+\t\teglDestroyContext(display_, std::exchange(context_, EGL_NO_CONTEXT));\n+\n+\ttid_ = -1;\n+\tvtable_ = {};\n+}\n+\n /**\n * \\brief Make the EGL context current for the calling thread\n *\n", "prefixes": [ "RFC", "v1", "05/10" ] }