From patchwork Tue Aug 4 10:19:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27607 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1608C330A for ; Tue, 4 Aug 2026 10:20:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9E7ED680A3; Tue, 4 Aug 2026 12:19:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OF5aKbJH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 666726807C for ; Tue, 4 Aug 2026 12:19:53 +0200 (CEST) Received: from pb-laptop.local (185.221.141.208.nat.pool.zt.hu [185.221.141.208]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DE95ADA8 for ; Tue, 4 Aug 2026 12:18:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785838723; bh=/FOOkT8HkB0/KvseZFNzxHMIiyA7lcxFFBeOKQD5Z/U=; h=From:To:Subject:Date:In-Reply-To:References:From; b=OF5aKbJHj7g9dYC2F77mJ+BQiTlIcfxX8n+oNL1UYI9WuZ6BOIqViDjLCh9/e/kgm YKFT68YdZ9HfhnBYjTfNvPTUeJCYzwZHAgAEMfrbp1sI61XzQdfdEUzVpug6LG2rjW FjRVh81dxhNl+/jFTQcSycro9hz3HnBWLZnctv5g= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 05/10] libcamera: egl: Add `resetEGLContext()` Date: Tue, 4 Aug 2026 12:19:44 +0200 Message-ID: <20260804101949.353266-6-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260804101949.353266-1-barnabas.pocze@ideasonboard.com> References: <20260804101949.353266-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a function that undoes the effects of `initEGLContext()`. Signed-off-by: Barnabás Pőcze --- include/libcamera/internal/egl.h | 1 + src/libcamera/egl.cpp | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index fb77225ac4..e18bb91f4d 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -103,6 +103,7 @@ public: ~eGL(); int initEGLContext(); + void resetEGLContext(); static EGLDisplay probeDisplay(); int createInputDMABufTexture2D(eGLImage &eglImage, int fd); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 3de5fab816..6b50e7bb77 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -71,14 +71,13 @@ eGL::eGL(EGLDisplay display) } /** - * \brief Destroy the EGL helper + * \brief Release all EGL resources * - * Destroys the EGL context and surface if they were successfully created. + * Equivalent to calling resetEGLContext(). */ eGL::~eGL() { - if (context_ != EGL_NO_CONTEXT) - eglDestroyContext(display_, context_); + resetEGLContext(); } /** @@ -436,6 +435,20 @@ fail: return -ENODEV; } +/** + * \brief Destroy the EGL context + * + * This function destroys the EGL context created by initEGLContext(). + */ +void eGL::resetEGLContext() +{ + if (context_ != EGL_NO_CONTEXT) + eglDestroyContext(display_, std::exchange(context_, EGL_NO_CONTEXT)); + + tid_ = -1; + vtable_ = {}; +} + /** * \brief Make the EGL context current for the calling thread *