Patch Detail
Show a patch.
GET /api/patches/27604/?format=api
{ "id": 27604, "url": "https://patchwork.libcamera.org/api/patches/27604/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27604/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260804101949.353266-3-barnabas.pocze@ideasonboard.com>", "date": "2026-08-04T10:19:41", "name": "[RFC,v1,02/10] libcamera: egl: Remove `eGL::surface_`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4ed4494715a7a6d7a4c36a383e45bd88993a6cff", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27604/mbox/", "series": [ { "id": 6105, "url": "https://patchwork.libcamera.org/api/series/6105/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6105", "date": "2026-08-04T10:19:39", "name": "libcamera: software_isp: debayer_egl: Remove some leaks", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6105/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27604/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27604/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B658C3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2026 10:20:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E1D768095;\n\tTue, 4 Aug 2026 12:19:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F37B6807E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:19:52 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E5381CE8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2026 12:18:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JRLIgAfj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785838723;\n\tbh=j5yrrH8lQnXg+4XigDmOL+688pX+fiWNnS2tVNsCcR8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=JRLIgAfjnfEvqHSFT7tkkXsC5you1EeLS7U2D4YxXDy9Na2irczHRHHvcnNRQt5mk\n\tq/iqVmwuP37Uw6HAKuqk8oi9m+w5X2PvjltlE0GIfWpYgDNEPRpnRhvjRv60P4gT+i\n\tbKP8XLdsOmZHEfT1scIpdSJubbEZQYgke+BfrWa8=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 02/10] libcamera: egl: Remove `eGL::surface_`", "Date": "Tue, 4 Aug 2026 12:19:41 +0200", "Message-ID": "<20260804101949.353266-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "References": "<20260804101949.353266-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This member has always been unused, so remove it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/egl.h | 1 -\n src/libcamera/egl.cpp | 8 --------\n 2 files changed, 9 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex c43684808d..f8ae486a8d 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -133,7 +133,6 @@ private:\n \n \tEGLDisplay display_ = EGL_NO_DISPLAY;\n \tEGLContext context_ = EGL_NO_CONTEXT;\n-\tEGLSurface surface_ = EGL_NO_SURFACE;\n \n \tint compileShader(int shaderType, GLuint &shaderId, Span<const unsigned char> shaderData,\n \t\t\t Span<const std::string> shaderEnv);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 780b7bc2d5..900d2174df 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -57,11 +57,6 @@ LOG_DEFINE_CATEGORY(eGL)\n *\\brief EGL context handle\n */\n \n-/**\n- *\\var eGL::surface_\n- *\\brief EGL sufrace handle\n- */\n-\n /**\n * \\brief Construct an EGL helper\n * \\param[in] display The EGL display to use\n@@ -84,9 +79,6 @@ eGL::~eGL()\n {\n \tif (context_ != EGL_NO_CONTEXT)\n \t\teglDestroyContext(display_, context_);\n-\n-\tif (surface_ != EGL_NO_SURFACE)\n-\t\teglDestroySurface(display_, surface_);\n }\n \n /**\n", "prefixes": [ "RFC", "v1", "02/10" ] }