From patchwork Tue Aug 4 10:19:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27604 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6B658C3306 for ; Tue, 4 Aug 2026 10:20:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2E1D768095; Tue, 4 Aug 2026 12:19:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JRLIgAfj"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F37B6807E for ; Tue, 4 Aug 2026 12:19:52 +0200 (CEST) Received: from pb-laptop.local (185.221.141.208.nat.pool.zt.hu [185.221.141.208]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E5381CE8 for ; Tue, 4 Aug 2026 12:18:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785838723; bh=j5yrrH8lQnXg+4XigDmOL+688pX+fiWNnS2tVNsCcR8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JRLIgAfjnfEvqHSFT7tkkXsC5you1EeLS7U2D4YxXDy9Na2irczHRHHvcnNRQt5mk q/iqVmwuP37Uw6HAKuqk8oi9m+w5X2PvjltlE0GIfWpYgDNEPRpnRhvjRv60P4gT+i bKP8XLdsOmZHEfT1scIpdSJubbEZQYgke+BfrWa8= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 02/10] libcamera: egl: Remove `eGL::surface_` Date: Tue, 4 Aug 2026 12:19:41 +0200 Message-ID: <20260804101949.353266-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260804101949.353266-1-barnabas.pocze@ideasonboard.com> References: <20260804101949.353266-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This member has always been unused, so remove it. Signed-off-by: Barnabás Pőcze --- include/libcamera/internal/egl.h | 1 - src/libcamera/egl.cpp | 8 -------- 2 files changed, 9 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index c43684808d..f8ae486a8d 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -133,7 +133,6 @@ private: EGLDisplay display_ = EGL_NO_DISPLAY; EGLContext context_ = EGL_NO_CONTEXT; - EGLSurface surface_ = EGL_NO_SURFACE; int compileShader(int shaderType, GLuint &shaderId, Span shaderData, Span shaderEnv); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 780b7bc2d5..900d2174df 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -57,11 +57,6 @@ LOG_DEFINE_CATEGORY(eGL) *\brief EGL context handle */ -/** - *\var eGL::surface_ - *\brief EGL sufrace handle - */ - /** * \brief Construct an EGL helper * \param[in] display The EGL display to use @@ -84,9 +79,6 @@ eGL::~eGL() { if (context_ != EGL_NO_CONTEXT) eglDestroyContext(display_, context_); - - if (surface_ != EGL_NO_SURFACE) - eglDestroySurface(display_, surface_); } /**