Patch Detail
Show a patch.
GET /api/patches/27575/?format=api
{ "id": 27575, "url": "https://patchwork.libcamera.org/api/patches/27575/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27575/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260803131435.153927-26-barnabas.pocze@ideasonboard.com>", "date": "2026-08-03T13:14:10", "name": "[RFC,v3,25/50] ipa: libipa: agc: Adjust debug messages slightly", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "561008b463dce12e1bb35de1ddbf01e393a8733a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27575/mbox/", "series": [ { "id": 6103, "url": "https://patchwork.libcamera.org/api/series/6103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6103", "date": "2026-08-03T13:13:45", "name": "ipa: libipa: agc rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27575/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27575/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC3BEC333C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2026 13:15:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84C73680CD;\n\tMon, 3 Aug 2026 15:15:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E28F68097\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:14:44 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1169512;\n\tMon, 3 Aug 2026 15:13:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G/fU6K//\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762815;\n\tbh=x66YuLWtynSNp2hj+fWb2QhK8rI/MVTFPFDqBXxPkw8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=G/fU6K//Yzbp/hmGgFcoWtwHCHgQgJ+jEQ6cwyTRO3yR6A31J6e6AmeQ7xyniWmCH\n\tL/RkPfBY+5X1GPkfn0z7IuAIl0aP6USMlCBd/DrgYOYyoDEuGNsUkR8R++dyBXWczl\n\tb7i2PnnE9gYtXGFa8U5mFaPGkaMAtHwou6fCGLik=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC PATCH v3 25/50] ipa: libipa: agc: Adjust debug messages\n\tslightly", "Date": "Mon, 3 Aug 2026 15:14:10 +0200", "Message-ID": "<20260803131435.153927-26-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "References": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The log message showing the result of AGC seems too verbose to me,\nand the labels and values are far from each other. And also log the\nline duration when showing exposure and gain limits.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/agc.cpp | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex 78a938568c..5273c1f64b 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -272,8 +272,10 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,\n \tfloat defGain = config.sensor->gain(v4l2Gain.def().get<int32_t>());\n \n \tLOG(Agc, Debug)\n-\t\t<< \"Exposure: [\" << minExposure << \", \" << maxExposure\n-\t\t<< \"], gain: [\" << minGain << \", \" << maxGain << \"]\";\n+\t\t<< \"exposure:[\" << minExposure << ',' << maxExposure << ']'\n+\t\t<< \" gain:[\" << minGain << ',' << maxGain << ']'\n+\t\t<< \" line-duration:\" << session.lineDuration\n+\t\t<< \" sensor-output:\" << session.sensor.outputSize;\n \n \t/*\n \t * Compute the frame duration limits.\n@@ -601,10 +603,10 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state,\n \t\tnewExposureTime = newEv.exposureTime;\n \n \t\tLOG(Agc, Debug)\n-\t\t\t<< \"Divided up exposure time, analogue gain, quantization gain\"\n-\t\t\t<< \" and digital gain are \" << utils::Duration(state.automatic.exposure * lineDuration)\n-\t\t\t<< \", \" << state.automatic.gain << \", \" << state.automatic.quantizationGain\n-\t\t\t<< \" and \" << newEv.digitalGain;\n+\t\t\t<< \"exposure-time:\" << utils::Duration(state.automatic.exposure * lineDuration)\n+\t\t\t<< \" analogue-gain:\" << state.automatic.gain\n+\t\t\t<< \" quantization-gain:\" << state.automatic.quantizationGain\n+\t\t\t<< \" digital-gain:\" << newEv.digitalGain;\n \t}\n \n \t/*\n", "prefixes": [ "RFC", "v3", "25/50" ] }