Patch Detail
Show a patch.
GET /api/patches/27572/?format=api
{ "id": 27572, "url": "https://patchwork.libcamera.org/api/patches/27572/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27572/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260803131435.153927-23-barnabas.pocze@ideasonboard.com>", "date": "2026-08-03T13:14:07", "name": "[RFC,v3,22/50] ipa: libipa: agc: Omit `setLimits()` in `configure()`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0e1ed966a5fedc537fc4248f5564054b52dec65d", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27572/mbox/", "series": [ { "id": 6103, "url": "https://patchwork.libcamera.org/api/series/6103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6103", "date": "2026-08-03T13:13:45", "name": "ipa: libipa: agc rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27572/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27572/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CCEBC3339\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Aug 2026 13:15:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5202068092;\n\tMon, 3 Aug 2026 15:15:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE3D968091\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:14:43 +0200 (CEST)", "from pb-laptop.local (185.221.141.208.nat.pool.zt.hu\n\t[185.221.141.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 141C45B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Aug 2026 15:13:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c3seOd4K\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785762815;\n\tbh=5ShJ7WhxvZwZ2UFjC2q6rpeaDATnrCwjS4LBE8V3sg4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=c3seOd4KIm252NZGCFM3h8IoC1kKdPdLTHDgqQudwfh5SQuR31N1agmQ8U8whttVB\n\tITXgs5sx7L8TV7YQ8L/wdL6+AZJ9rV5bXM4uql2nk5Swn4+kYdybgBRiacrOf1XsSg\n\tIwSHPD/8OTPuVVhEnnB0bb3iE7W67UIP6trAdfq4=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 22/50] ipa: libipa: agc: Omit `setLimits()` in\n\t`configure()`", "Date": "Mon, 3 Aug 2026 15:14:07 +0200", "Message-ID": "<20260803131435.153927-23-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "References": "<20260803131435.153927-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`AgcMeanLuminance::setLimits()` is only required to be called before\n`calculateNewEv()`, so the call in `configure()` has no real effect\nbecause no calculation is carried out. So remove it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/libipa/agc.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex a8f91f864e..d751a8b0b8 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -313,9 +313,6 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,\n \tsession.maxFrameDuration = std::chrono::microseconds(frameDurations[1]);\n \n \timpl_.configure(session.lineDuration, config.sensor);\n-\timpl_.setLimits(session.minExposureTime, session.maxExposureTime,\n-\t\t\tsession.minAnalogueGain, session.maxAnalogueGain,\n-\t\t\t{});\n \timpl_.resetFrameCount();\n \n \t/* Configure the default exposure and gain. */\n", "prefixes": [ "RFC", "v3", "22/50" ] }