Patch Detail
Show a patch.
GET /api/patches/27418/?format=api
{ "id": 27418, "url": "https://patchwork.libcamera.org/api/patches/27418/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27418/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260720-libipa-algorithms-v6-26-ececb73f97cb@ideasonboard.com>", "date": "2026-07-20T14:59:44", "name": "[v6,26/31] ipa: libipa: lsc: Document LscDescriptor::sensorSize usage", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a5674a1adc3fa83dbd07a99dc81826de078ec255", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27418/mbox/", "series": [ { "id": 6067, "url": "https://patchwork.libcamera.org/api/series/6067/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6067", "date": "2026-07-20T14:59:18", "name": "ipa: libipa: Introduce libipa algorithms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/6067/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27418/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27418/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FCC9C333C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2026 15:00:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1877D67EA8;\n\tMon, 20 Jul 2026 17:00:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE80167E5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2026 16:59:55 +0200 (CEST)", "from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it\n\t[5.90.63.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9F01339E;\n\tMon, 20 Jul 2026 16:58:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BZukmN6H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784559537;\n\tbh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=BZukmN6HYKrFjPXHpwDtQSVmVX+HEwFljSQec/1pLGbsPDpdYkpeZ4ihiJ+hu5Wcx\n\tB6w7GWTGuU/XHqUvyKpI6pwfUTFQQ6rkoeF0nsjhIRcfuUEs0V6vEzSe7y+9WdFfb5\n\tvSJJ3T/+3klSQnmyiFKvUBqfvSqIBEa1FQtBJyPA=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 20 Jul 2026 16:59:44 +0200", "Subject": "[PATCH v6 26/31] ipa: libipa: lsc: Document\n\tLscDescriptor::sensorSize usage", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260720-libipa-algorithms-v6-26-ececb73f97cb@ideasonboard.com>", "References": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "In-Reply-To": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>, \n\tMilan Zamazal <mzamazal@redhat.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1079;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfaBoKFN+Kn0uuyVVcyDyfFiFzLZL3dPOOyF\n\tusdM1sUSp2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal432gAKCRByNAaPFqFW\n\tPPafEACyzfXw9Ss1XLpixpXTWZcFasxlkz2kqjk1IJOmldYJkopgvsI4ssZbFGv2W8aNp1U/D5+\n\tl8mwK3EmlKsAR0lG3zhYhF3M6nmVGEfOI8T28AuRArc76E9LUia3DiFbcgDhD7kITU/kCGiImGf\n\t9HlSnKPOpoQ9Sqo8BSsgdPNosAkzJGA2l8HJHNeiVTeria0S8ljRSct15RKRCjIdwUvbi1Q/sLr\n\t9TMXFJrOmzIlA/u64nXF3CvxbAONisdkFoo6pEg/zBzT7wE8OTiPZZ3CnRfoY7HRSDALYm5rXzI\n\tjtvyx6UDbdK81Fh6OcuxME2yD/Qxg5jyYhAKTHicbHAYvD0p5Hcr7JhCgHUE6Lq15OgNTjci5yh\n\tpZ1aeIU7AD7eXO0pDL8KC3k5YYO22/F9f01J+IomqBIJsO1Z6+KI4Dt/MOXRXbObCezyJ/xdwJW\n\tqHsM4hoAM40PADmjzcUOAlIumT5Gxru45/y4XLs+jKI5nc/Dxgihs/dXDqQqKdHAz8WP1BR0MmH\n\tnz7BzA9cOULJkNW9FElhMvHuMn+Ud5sVewEnyDkkWKp3kmI/zp1lVZyMTK5bO1/cjKSnpuXn/OU\n\tnrWTq/mbh5BTZT+lJhn9hnhw2CK6JK4gwjqjLqRdnJWSUXNtOYdjfOwwDw5ac3VLKPGjrpPFPJB\n\t3U6I26Ctp/nCkOg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that sensorSize_ has been removed from LscPolynomial and is\npassed to the Lsc algorithm through LscDescriptor document its intended\npurpose.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 2062b795991d..8c5c28077cce 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -179,6 +179,10 @@ namespace lsc {\n * k4: 0.0\n * \\endcode\n *\n+ * The LSC polynomial definition is generated at tuning time in relation\n+ * to the full sensor pixel array. This needs to be specified in\n+ * LscDescriptor::sensorSize.\n+ *\n * At LscAlgorithm::configure() time the LSC tables are re-sampled on the\n * sensor's crop rectangle in use to adapt them to the configuration in use for\n * a streaming session. Polynomial LSC tables support re-sampling and can be\n", "prefixes": [ "v6", "26/31" ] }