From patchwork Mon Jul 20 14:59:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27418 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9FCC9C333C for ; Mon, 20 Jul 2026 15:00:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1877D67EA8; Mon, 20 Jul 2026 17:00:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BZukmN6H"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BE80167E5D for ; Mon, 20 Jul 2026 16:59:55 +0200 (CEST) Received: from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it [5.90.63.152]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9F01339E; Mon, 20 Jul 2026 16:58:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784559537; bh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=BZukmN6HYKrFjPXHpwDtQSVmVX+HEwFljSQec/1pLGbsPDpdYkpeZ4ihiJ+hu5Wcx B6w7GWTGuU/XHqUvyKpI6pwfUTFQQ6rkoeF0nsjhIRcfuUEs0V6vEzSe7y+9WdFfb5 vSJJ3T/+3klSQnmyiFKvUBqfvSqIBEa1FQtBJyPA= From: Jacopo Mondi Date: Mon, 20 Jul 2026 16:59:44 +0200 Subject: [PATCH v6 26/31] ipa: libipa: lsc: Document LscDescriptor::sensorSize usage MIME-Version: 1.0 Message-Id: <20260720-libipa-algorithms-v6-26-ececb73f97cb@ideasonboard.com> References: <20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com> In-Reply-To: <20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug , Milan Zamazal Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1079; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=6Obv0Wz/HJF7mOUnS6V31ONAzqtsTuCPOBefw8+/xCs=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfaBoKFN+Kn0uuyVVcyDyfFiFzLZL3dPOOyF usdM1sUSp2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal432gAKCRByNAaPFqFW PPafEACyzfXw9Ss1XLpixpXTWZcFasxlkz2kqjk1IJOmldYJkopgvsI4ssZbFGv2W8aNp1U/D5+ l8mwK3EmlKsAR0lG3zhYhF3M6nmVGEfOI8T28AuRArc76E9LUia3DiFbcgDhD7kITU/kCGiImGf 9HlSnKPOpoQ9Sqo8BSsgdPNosAkzJGA2l8HJHNeiVTeria0S8ljRSct15RKRCjIdwUvbi1Q/sLr 9TMXFJrOmzIlA/u64nXF3CvxbAONisdkFoo6pEg/zBzT7wE8OTiPZZ3CnRfoY7HRSDALYm5rXzI jtvyx6UDbdK81Fh6OcuxME2yD/Qxg5jyYhAKTHicbHAYvD0p5Hcr7JhCgHUE6Lq15OgNTjci5yh pZ1aeIU7AD7eXO0pDL8KC3k5YYO22/F9f01J+IomqBIJsO1Z6+KI4Dt/MOXRXbObCezyJ/xdwJW qHsM4hoAM40PADmjzcUOAlIumT5Gxru45/y4XLs+jKI5nc/Dxgihs/dXDqQqKdHAz8WP1BR0MmH nz7BzA9cOULJkNW9FElhMvHuMn+Ud5sVewEnyDkkWKp3kmI/zp1lVZyMTK5bO1/cjKSnpuXn/OU nrWTq/mbh5BTZT+lJhn9hnhw2CK6JK4gwjqjLqRdnJWSUXNtOYdjfOwwDw5ac3VLKPGjrpPFPJB 3U6I26Ctp/nCkOg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that sensorSize_ has been removed from LscPolynomial and is passed to the Lsc algorithm through LscDescriptor document its intended purpose. Signed-off-by: Jacopo Mondi Reviewed-by: Stefan Klug Reviewed-by: Kieran Bingham --- src/ipa/libipa/lsc.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 2062b795991d..8c5c28077cce 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -179,6 +179,10 @@ namespace lsc { * k4: 0.0 * \endcode * + * The LSC polynomial definition is generated at tuning time in relation + * to the full sensor pixel array. This needs to be specified in + * LscDescriptor::sensorSize. + * * At LscAlgorithm::configure() time the LSC tables are re-sampled on the * sensor's crop rectangle in use to adapt them to the configuration in use for * a streaming session. Polynomial LSC tables support re-sampling and can be