Patch Detail
Show a patch.
GET /api/patches/27417/?format=api
{ "id": 27417, "url": "https://patchwork.libcamera.org/api/patches/27417/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27417/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260720-libipa-algorithms-v6-25-ececb73f97cb@ideasonboard.com>", "date": "2026-07-20T14:59:43", "name": "[v6,25/31] ipa: libipa: lsc_polynomial: Remove sensorSize_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "90c7432a2fb516b6f8dff4227390dfa18f044bd4", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27417/mbox/", "series": [ { "id": 6067, "url": "https://patchwork.libcamera.org/api/series/6067/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6067", "date": "2026-07-20T14:59:18", "name": "ipa: libipa: Introduce libipa algorithms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/6067/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27417/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27417/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05FBCC333B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2026 15:00:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 735D167E72;\n\tMon, 20 Jul 2026 17:00:18 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3787767E7B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2026 16:59:55 +0200 (CEST)", "from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it\n\t[5.90.63.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EEA3339C;\n\tMon, 20 Jul 2026 16:58:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y5z5l75n\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784559536;\n\tbh=k2Iq3q+zwr6OqfqbNHCbdw0aMUyO+rV/Rakq/K3/TGs=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Y5z5l75nYpl1ylxBFCM5pco2Vw4xIvZVUwSL0c01iV6n8hMGNA2dPh5BM6SFkszoX\n\t5HLV3WzUxeRDnt0SjgOkEeMrVvUWrG/qrKgOewvh3z4XhLVpgsYAaL9wnsuQaR5XK3\n\tSEKk9Rj6LE1sjOQwcQ31QndFwPxCIrd/trQJEkk0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 20 Jul 2026 16:59:43 +0200", "Subject": "[PATCH v6 25/31] ipa: libipa: lsc_polynomial: Remove sensorSize_", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260720-libipa-algorithms-v6-25-ececb73f97cb@ideasonboard.com>", "References": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "In-Reply-To": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>, \n\tMilan Zamazal <mzamazal@redhat.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3310;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=k2Iq3q+zwr6OqfqbNHCbdw0aMUyO+rV/Rakq/K3/TGs=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfaJHHrwcC5dN3ytGxn0nnhPOog1e7001pUY\n\t6s56tB0EP6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal432gAKCRByNAaPFqFW\n\tPGdLEACb0bc9TV7cQCaSRgL/pqbMLKgnMocnHtWYpj4MDvx10iXlmwzQuvb/rTsCOsVf1fSmLLM\n\t6QhA2agpw0N9AH4qG9OjIx+SQUUCDn+D9X99qYGmnfPB49QqkZIlyGsPsu4flTO1Sr7+fLZ9Lat\n\tXQGFtti7Ro3IEbPAiNh4MjwUs+eV71Df5uXK8Gx9SveY5vOyWLiEu40B/TR9UhRUwqe2TVrSLzF\n\tyw3X7O6qjasXscc29DYj3uPSV7MERxPvb+VMhA82HYfWnMdi8eU7SnCzJPa7FEklrrQ3GrUZa+x\n\taOO9ZIWtAVGBVUfu0ammmNdwrMoDKgBQhFXzT5lEgz3Iqbe2FSCRZbVRJYEspET1Nn8H1p797Rc\n\t3nJBuO6iGNr7deRGrmgvkZZ2nZIOv32Ys0JnB248BhD4vDtMlELf+dEeytLOCr/GhLhSbvQekEs\n\t07DdaSnycLsq0x2XDYtKl5Ucl0JuBkcTyFWy+Tv3AA0I/4+Ghy9zgdNhl6PF2fzO2t0WHYyybNM\n\tQzWmh4OJau1fBzAlHOT6JVicYOaAuSqJDchK8N2dBVM3Vkr1C3qc0K/aieHVUv44uopoztMA+p5\n\tsu9DJ+/r70kBbxw8VJib7V11Gm87QiGs9utvbWoEBGaMZjRvu0XavVtkYUdarcnM+k0mCrEXm72\n\t157+KX+/bjApPWQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensorSize_ field is only used during the init() function and is\nprovided to LscPolynomial using the LscDescriptor type.\n\nThere is no need to store it as a class member and to pass it in\nat class construction time.\n\nRemove it and move the \\todo comment in the LscDescriptor type\ndocumentation.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 6 +-----\n src/ipa/libipa/lsc_base.cpp | 3 +++\n src/ipa/libipa/lsc_polynomial.cpp | 7 -------\n src/ipa/libipa/lsc_polynomial.h | 6 ------\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 32626049a2e2..2062b795991d 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control\n \t\timpl_ = std::make_unique<LscTable>();\n \t\tLOG(Lsc, Debug) << \"Using table-based Lsc\";\n \t} else if (type == \"polynomial\") {\n-\t\t/*\n-\t\t * \\todo Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\timpl_ = std::make_unique<LscPolynomial>(descriptor.sensorSize);\n+\t\timpl_ = std::make_unique<LscPolynomial>();\n \t\tpolynomial_ = true;\n \t\tLOG(Lsc, Debug) << \"Using polynomial Lsc\";\n \t} else {\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 01616d1c2e2a..cf2c3bfc382f 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -78,6 +78,9 @@ void Interpolator<lsc::Components>::\n * \\var LscDescriptor::sensorSize\n * \\brief The physical sensor size. This is the largest frame size used to\n * generate the LSC table. Only used by the polynomial LSC algorithm\n+ *\n+ * \\todo: Most likely the reference frame should be native_size.\n+ * Let's wait how the internal discussions progress.\n */\n \n /**\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex e17ba85448be..c61c85fbf2b2 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)\n * \\sa LscImplementation\n */\n \n-/**\n- * \\fn LscPolynomial::LscPolynomial\n- * \\param[in] sensorSize The physical sensor size\n- *\n- * Construct an LscPolynomial\n- */\n-\n /**\n * \\brief Parse polynomial LSC data\n * \\param[in] sets The tuning file content\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex 2a26db499d68..6d19e46a50b7 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -57,11 +57,6 @@ private:\n \tusing PolynomialComponentsMap = std::map<unsigned int, PolynomialComponents>;\n \n public:\n-\tLscPolynomial(const Size &sensorSize)\n-\t\t: sensorSize_(sensorSize)\n-\t{\n-\t}\n-\n \tint parseLscData(const ValueNode &sets,\n \t\t\t const LscDescriptor &descriptor) override;\n \n@@ -75,7 +70,6 @@ private:\n \t\t\t\t\t Span<const double> yPositions,\n \t\t\t\t\t const Rectangle &cropRectangle);\n \tPolynomialComponentsMap lscData_;\n-\tSize sensorSize_;\n };\n \n } /* namespace ipa */\n", "prefixes": [ "v6", "25/31" ] }