From patchwork Mon Jul 20 14:59:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27417 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 05FBCC333B for ; Mon, 20 Jul 2026 15:00:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 735D167E72; Mon, 20 Jul 2026 17:00:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Y5z5l75n"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3787767E7B for ; Mon, 20 Jul 2026 16:59:55 +0200 (CEST) Received: from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it [5.90.63.152]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EEA3339C; Mon, 20 Jul 2026 16:58:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784559536; bh=k2Iq3q+zwr6OqfqbNHCbdw0aMUyO+rV/Rakq/K3/TGs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Y5z5l75nYpl1ylxBFCM5pco2Vw4xIvZVUwSL0c01iV6n8hMGNA2dPh5BM6SFkszoX 5HLV3WzUxeRDnt0SjgOkEeMrVvUWrG/qrKgOewvh3z4XhLVpgsYAaL9wnsuQaR5XK3 SEKk9Rj6LE1sjOQwcQ31QndFwPxCIrd/trQJEkk0= From: Jacopo Mondi Date: Mon, 20 Jul 2026 16:59:43 +0200 Subject: [PATCH v6 25/31] ipa: libipa: lsc_polynomial: Remove sensorSize_ MIME-Version: 1.0 Message-Id: <20260720-libipa-algorithms-v6-25-ececb73f97cb@ideasonboard.com> References: <20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com> In-Reply-To: <20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug , Milan Zamazal Cc: Jacopo Mondi , Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3310; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=k2Iq3q+zwr6OqfqbNHCbdw0aMUyO+rV/Rakq/K3/TGs=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfaJHHrwcC5dN3ytGxn0nnhPOog1e7001pUY 6s56tB0EP6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal432gAKCRByNAaPFqFW PGdLEACb0bc9TV7cQCaSRgL/pqbMLKgnMocnHtWYpj4MDvx10iXlmwzQuvb/rTsCOsVf1fSmLLM 6QhA2agpw0N9AH4qG9OjIx+SQUUCDn+D9X99qYGmnfPB49QqkZIlyGsPsu4flTO1Sr7+fLZ9Lat XQGFtti7Ro3IEbPAiNh4MjwUs+eV71Df5uXK8Gx9SveY5vOyWLiEu40B/TR9UhRUwqe2TVrSLzF yw3X7O6qjasXscc29DYj3uPSV7MERxPvb+VMhA82HYfWnMdi8eU7SnCzJPa7FEklrrQ3GrUZa+x aOO9ZIWtAVGBVUfu0ammmNdwrMoDKgBQhFXzT5lEgz3Iqbe2FSCRZbVRJYEspET1Nn8H1p797Rc 3nJBuO6iGNr7deRGrmgvkZZ2nZIOv32Ys0JnB248BhD4vDtMlELf+dEeytLOCr/GhLhSbvQekEs 07DdaSnycLsq0x2XDYtKl5Ucl0JuBkcTyFWy+Tv3AA0I/4+Ghy9zgdNhl6PF2fzO2t0WHYyybNM QzWmh4OJau1fBzAlHOT6JVicYOaAuSqJDchK8N2dBVM3Vkr1C3qc0K/aieHVUv44uopoztMA+p5 su9DJ+/r70kBbxw8VJib7V11Gm87QiGs9utvbWoEBGaMZjRvu0XavVtkYUdarcnM+k0mCrEXm72 157+KX+/bjApPWQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensorSize_ field is only used during the init() function and is provided to LscPolynomial using the LscDescriptor type. There is no need to store it as a class member and to pass it in at class construction time. Remove it and move the \todo comment in the LscDescriptor type documentation. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Stefan Klug --- src/ipa/libipa/lsc.cpp | 6 +----- src/ipa/libipa/lsc_base.cpp | 3 +++ src/ipa/libipa/lsc_polynomial.cpp | 7 ------- src/ipa/libipa/lsc_polynomial.h | 6 ------ 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index 32626049a2e2..2062b795991d 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control impl_ = std::make_unique(); LOG(Lsc, Debug) << "Using table-based Lsc"; } else if (type == "polynomial") { - /* - * \todo Most likely the reference frame should be native_size. - * Let's wait how the internal discussions progress. - */ - impl_ = std::make_unique(descriptor.sensorSize); + impl_ = std::make_unique(); polynomial_ = true; LOG(Lsc, Debug) << "Using polynomial Lsc"; } else { diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 01616d1c2e2a..cf2c3bfc382f 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -78,6 +78,9 @@ void Interpolator:: * \var LscDescriptor::sensorSize * \brief The physical sensor size. This is the largest frame size used to * generate the LSC table. Only used by the polynomial LSC algorithm + * + * \todo: Most likely the reference frame should be native_size. + * Let's wait how the internal discussions progress. */ /** diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index e17ba85448be..c61c85fbf2b2 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size) * \sa LscImplementation */ -/** - * \fn LscPolynomial::LscPolynomial - * \param[in] sensorSize The physical sensor size - * - * Construct an LscPolynomial - */ - /** * \brief Parse polynomial LSC data * \param[in] sets The tuning file content diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index 2a26db499d68..6d19e46a50b7 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -57,11 +57,6 @@ private: using PolynomialComponentsMap = std::map; public: - LscPolynomial(const Size &sensorSize) - : sensorSize_(sensorSize) - { - } - int parseLscData(const ValueNode &sets, const LscDescriptor &descriptor) override; @@ -75,7 +70,6 @@ private: Span yPositions, const Rectangle &cropRectangle); PolynomialComponentsMap lscData_; - Size sensorSize_; }; } /* namespace ipa */