Patch Detail
Show a patch.
GET /api/patches/27168/?format=api
{ "id": 27168, "url": "https://patchwork.libcamera.org/api/patches/27168/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27168/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260703122543.1991189-10-paul.elder@ideasonboard.com>", "date": "2026-07-03T12:25:15", "name": "[RFC,09/19] ipa: rkisp2: algo: awb: Implement automatic white balance control", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1fb5835ef29dd26efeec0fb0ba4b0d96d0d29035", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27168/mbox/", "series": [ { "id": 6035, "url": "https://patchwork.libcamera.org/api/series/6035/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6035", "date": "2026-07-03T12:25:06", "name": "Add support for rkisp2", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6035/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27168/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27168/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 090AAC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Jul 2026 12:26:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5F4165FD8;\n\tFri, 3 Jul 2026 14:26:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53E2965FD8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2026 14:26:32 +0200 (CEST)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:a2cc:2f45:3bd7:2589])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 739198E0;\n\tFri, 3 Jul 2026 14:25:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rMV/2muO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783081546;\n\tbh=CzSviiRCwi9H5hJ2YKvMHc9OL7RDud3wqlrh3cartjY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rMV/2muOy6BeQmPaWFkT487SQkngQpBUoF55BQVEdINGtmJtSRbagljD91LC/M4P2\n\tGg6GoT8mCslGi+DWAaR4TEE8FFjdfgAC7pfRsJq4Bs4QVMwdTgAndSsz/gMeKrjTch\n\tZA/XUm3fjFi/W8uUX6jF0TttijM+ivGIKoR/59dU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "laurent.pinchart@ideasonboard.com", "Cc": "Paul Elder <paul.elder@ideasonboard.com>, michael.riesch@collabora.com, \n\txuhf@rock-chips.com, stefan.klug@ideasonboard.com,\n\tkieran.bingham@ideasonboard.com, dan.scally@ideasonboard.com,\n\tjacopo.mondi@ideasonboard.com, nicolas.dufresne@collabora.com,\n\tlibcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH 09/19] ipa: rkisp2: algo: awb: Implement automatic white\n\tbalance control", "Date": "Fri, 3 Jul 2026 21:25:15 +0900", "Message-ID": "<20260703122543.1991189-10-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "In-Reply-To": "<20260703122543.1991189-1-paul.elder@ideasonboard.com>", "References": "<20260703122543.1991189-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement auto white balance control algorithm for the rkisp2 IPA.\nThis leverages the libipa awb, so it supports baysian awb, grey world\nawb, as well as manual white balance.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/ipa/rkisp2/algorithms/awb.cpp | 174 ++++++++++++++++++++++++++\n src/ipa/rkisp2/algorithms/awb.h | 56 +++++++++\n src/ipa/rkisp2/algorithms/meson.build | 1 +\n 3 files changed, 231 insertions(+)\n create mode 100644 src/ipa/rkisp2/algorithms/awb.cpp\n create mode 100644 src/ipa/rkisp2/algorithms/awb.h", "diff": "diff --git a/src/ipa/rkisp2/algorithms/awb.cpp b/src/ipa/rkisp2/algorithms/awb.cpp\nnew file mode 100644\nindex 000000000000..4928ab13d220\n--- /dev/null\n+++ b/src/ipa/rkisp2/algorithms/awb.cpp\n@@ -0,0 +1,174 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2026, Ideas On Board\n+ *\n+ * AWB control algorithm\n+ */\n+\n+#include \"awb.h\"\n+\n+#include <algorithm>\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/ipa/core_ipa_interface.h>\n+\n+#include \"libcamera/internal/vector.h\"\n+\n+/**\n+ * \\file awb.h\n+ */\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp2::algorithms {\n+\n+LOG_DEFINE_CATEGORY(RkISP2Awb)\n+\n+class RkISP2AwbStats final : public AwbStats\n+{\n+public:\n+\tRkISP2AwbStats() = default;\n+\tRkISP2AwbStats(const RGB<double> means)\n+\t\t: AwbStats(means)\n+\t{\n+\t}\n+\n+\t/* Minimum mean value below which AWB can't operate. */\n+\tdouble minColourValue() const override\n+\t{\n+\t\treturn 2.0;\n+\t}\n+};\n+\n+namespace {\n+\n+} /* namespace */\n+\n+/**\n+ * \\class Awb\n+ * \\brief Manage the white balance with automatic and manual controls\n+ */\n+\n+Awb::Awb()\n+{\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::init\n+ */\n+int Awb::init(IPAContext &context, const ValueNode &tuningData)\n+{\n+\treturn awbAlgo_.init(tuningData, context.ctrlMap);\n+}\n+\n+int Awb::configure(IPAContext &context,\n+\t\t const IPACameraSensorInfo &configInfo)\n+{\n+\tawbAlgo_.configure(context.activeState.awb);\n+\n+\tcontext.configuration.awb.measureWindow.h_offs = 0;\n+\tcontext.configuration.awb.measureWindow.v_offs = 0;\n+\t/*\n+\t * Unlike ae lite, this seems to still work when height == full window\n+\t * height\n+\t */\n+\tcontext.configuration.awb.measureWindow.h_size = configInfo.outputSize.width / 15;\n+\tcontext.configuration.awb.measureWindow.v_size = configInfo.outputSize.height / 15;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::queueRequest\n+ */\n+void Awb::queueRequest(IPAContext &context, const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const ControlList &controls)\n+{\n+\tawbAlgo_.queueRequest(context.activeState.awb, frame, frameContext.awb,\n+\t\t\t controls);\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::prepare\n+ */\n+void Awb::prepare([[maybe_unused]] IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t IPAFrameContext &frameContext, RkISP2Params *params)\n+{\n+\tawbAlgo_.prepare(context.activeState.awb, frameContext.awb);\n+\n+\tauto gainConfig = params->block<RkISP2Blocks::AwbGains>();\n+\tgainConfig.setEnabled(true);\n+\n+\tRGB<double> gains = frameContext.awb.gains;\n+\n+\t/* \\todo Use quantized class */\n+\tgainConfig->gains[0].gb = std::clamp<int>(256 * 1.0, 0, 0x3fff);\n+\tgainConfig->gains[0].b = std::clamp<int>(256 * gains.b(), 0, 0x3fff);\n+\tgainConfig->gains[0].r = std::clamp<int>(256 * gains.r(), 0, 0x3fff);\n+\tgainConfig->gains[0].gr = std::clamp<int>(256 * 1.0, 0, 0x3fff);\n+\n+\tauto measConfig = params->block<RkISP2Blocks::AwbMeas>();\n+\tmeasConfig.setEnabled(true);\n+\n+\tmeasConfig->meas_window = context.configuration.awb.measureWindow;\n+\tstruct rkisp2_isp_awb_color_quad minLimits = { 0, 0, 0, 0 };\n+\tstruct rkisp2_isp_awb_color_quad maxLimits = { 255, 255, 255, 255 };\n+\tmeasConfig->limits[0] = minLimits;\n+\tmeasConfig->limits[1] = maxLimits;\n+\n+\tfor (unsigned int i = 0; i < RKISP2_ISP_AWB_COUNTS_SIZE; i++)\n+\t\tmeasConfig->weights[i] = 0x20;\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::process\n+ */\n+void Awb::process([[maybe_unused]] IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp2_stats_buffer *stats,\n+\t\t ControlList &metadata)\n+{\n+\tRkISP2AwbStats awbStats = calculateRgbMeans(frameContext, stats);\n+\n+\tawbAlgo_.process(context.activeState.awb, frameContext.awb, awbStats,\n+\t\t\t frameContext.lux.lux, metadata);\n+}\n+\n+RkISP2AwbStats Awb::calculateRgbMeans([[maybe_unused]] const IPAFrameContext &frameContext,\n+\t\t\t\t const rkisp2_stats_buffer *stats) const\n+{\n+\tif (!stats->awb.done) {\n+\t\tLOG(RkISP2Awb, Error) << \"No awb stats\";\n+\t\treturn {};\n+\t}\n+\n+\tstd::array<int32_t, RKISP2_ISP_AWB_COUNTS_SIZE> counts;\n+\tRGB<double> means;\n+\n+\tfor (size_t i = 0; i < RKISP2_ISP_AWB_COUNTS_SIZE; i++)\n+\t\tcounts[i] = static_cast<int32_t>(stats->awb.counts_r[i]);\n+\tmeans.r() = std::accumulate(counts.begin(), counts.end(), 0) / counts.size();\n+\n+\tfor (size_t i = 0; i < RKISP2_ISP_AWB_COUNTS_SIZE; i++)\n+\t\tcounts[i] = static_cast<int32_t>(stats->awb.counts_g[i]);\n+\tmeans.g() = std::accumulate(counts.begin(), counts.end(), 0) / counts.size();\n+\n+\tfor (size_t i = 0; i < RKISP2_ISP_AWB_COUNTS_SIZE; i++)\n+\t\tcounts[i] = static_cast<int32_t>(stats->awb.counts_b[i]);\n+\tmeans.b() = std::accumulate(counts.begin(), counts.end(), 0) / counts.size();\n+\n+\tfor (size_t i = 0; i < RKISP2_ISP_AWB_COUNTS_SIZE; i++)\n+\t\tcounts[i] = static_cast<int32_t>(stats->awb.counts_w[i]);\n+\n+\treturn RkISP2AwbStats(means);\n+}\n+\n+REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n+\n+} /* namespace ipa::rkisp2::algorithms */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp2/algorithms/awb.h b/src/ipa/rkisp2/algorithms/awb.h\nnew file mode 100644\nindex 000000000000..5f25ae1f1f05\n--- /dev/null\n+++ b/src/ipa/rkisp2/algorithms/awb.h\n@@ -0,0 +1,56 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2026, Ideas On Board\n+ *\n+ * AWB control algorithm\n+ */\n+\n+#pragma once\n+\n+#include <linux/rkisp2-config.h>\n+\n+#include <libcamera/controls.h>\n+\n+#include \"libcamera/internal/value_node.h\"\n+\n+#include \"libipa/awb.h\"\n+#include \"libipa/fixedpoint.h\"\n+\n+#include \"algorithm.h\"\n+#include \"ipa_context.h\"\n+#include \"params.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp2::algorithms {\n+\n+class RkISP2AwbStats;\n+\n+class Awb : public Algorithm\n+{\n+public:\n+\tAwb();\n+\t~Awb() = default;\n+\n+\tint init(IPAContext &context, const ValueNode &tuningData) override;\n+\tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n+\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n+\t\t\t IPAFrameContext &frameContext,\n+\t\t\t const ControlList &controls) override;\n+\tvoid prepare(IPAContext &context, const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t RkISP2Params *params) override;\n+\tvoid process(IPAContext &context, const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp2_stats_buffer *stats,\n+\t\t ControlList &metadata) override;\n+\n+private:\n+\tRkISP2AwbStats calculateRgbMeans(const IPAFrameContext &frameContext,\n+\t\t\t\t\t const rkisp2_stats_buffer *stats) const;\n+\n+\tAwbAlgorithm<UQ<6, 8>> awbAlgo_;\n+};\n+\n+} /* namespace ipa::rkisp2::algorithms */\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp2/algorithms/meson.build b/src/ipa/rkisp2/algorithms/meson.build\nindex 36996918b39e..30133ac4fa68 100644\n--- a/src/ipa/rkisp2/algorithms/meson.build\n+++ b/src/ipa/rkisp2/algorithms/meson.build\n@@ -1,6 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n rkisp2_ipa_algorithms = files([\n+ 'awb.cpp',\n 'bls.cpp',\n ])\n \n", "prefixes": [ "RFC", "09/19" ] }