Patch Detail
Show a patch.
GET /api/patches/27119/?format=api
{ "id": 27119, "url": "https://patchwork.libcamera.org/api/patches/27119/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27119/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-42-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:30:04", "name": "[RFC,v1,41/54] app: lc-compliance: Use camera buffer pool", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69976c3b94b94f30968170414bee24ba0217a8eb", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27119/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27119/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27119/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52613C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE24D65FC7;\n\tMon, 29 Jun 2026 18:31:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5362465F2C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:30 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B00DE91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lfeNlG6R\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750587;\n\tbh=I16+fIsMsBuYE2MczZTvkNlv97XF1oFMoVrjPo25gbQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lfeNlG6RV1zNe+s4Lz0Bzlll5YnAt43Jbno4Zq9Q2xfJ+741ywwtCFhq6lvpsrAz+\n\t1qml+51rTP/8aXLqJOn/x306nggpScUgWqiRo2xcoAuLSjHYtsby+zqLOpchZxr1Zz\n\tIoseO1s9pRFI5Xgz3kCPdVz21T0R8BnV+1MGrzTo=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 41/54] app: lc-compliance: Use camera buffer pool", "Date": "Mon, 29 Jun 2026 18:30:04 +0200", "Message-ID": "<20260629163017.863145-42-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Convert the `lc-compliance` application to use the new buffer pool\ninterface of cameras.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/lc-compliance/helpers/capture.cpp | 23 ++++++++++++++++------\n 1 file changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex d83269d4a9..2a645b4445 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -88,6 +88,9 @@ int Capture::queueRequest(libcamera::Request *request)\n \tif (queueLimit_ && queueCount_ >= *queueLimit_)\n \t\treturn 0;\n \n+\tfor (const auto &cfg : *config_)\n+\t\trequest->enableStream(cfg.stream(), true);\n+\n \tint ret = camera_->queueRequest(request);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -107,7 +110,10 @@ void Capture::requestComplete(Request *request)\n \tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n \t\t<< \"Request didn't complete successfully\";\n \n-\trequest->reuse(Request::ReuseBuffers);\n+\tfor (const auto &[stream, buffer] : request->buffers())\n+\t\tcamera_->addBuffer(stream, buffer);\n+\n+\trequest->reuse();\n \tif (queueRequest(request))\n \t\tloop_->exit(-EINVAL);\n }\n@@ -141,11 +147,6 @@ void Capture::start()\n \n \t\tconst auto &buffers = allocator_.buffers(stream);\n \t\tASSERT_EQ(buffers.size(), bufferCount) << \"Mismatching buffer count\";\n-\n-\t\tfor (std::size_t i = 0; i < bufferCount; i++) {\n-\t\t\tASSERT_EQ(requests_[i]->addBuffer(stream, buffers[i].get()), 0)\n-\t\t\t\t<< \"Failed to add buffer to request\";\n-\t\t}\n \t}\n \n \tASSERT_TRUE(allocator_.allocated());\n@@ -153,6 +154,16 @@ void Capture::start()\n \tcamera_->requestCompleted.connect(this, &Capture::requestComplete);\n \n \tASSERT_EQ(camera_->start(), 0) << \"Failed to start camera\";\n+\n+\tfor (const auto &cfg : *config_) {\n+\t\tStream *stream = cfg.stream();\n+\t\tconst auto &buffers = allocator_.buffers(stream);\n+\n+\t\tfor (std::size_t i = 0; i < bufferCount; i++) {\n+\t\t\tASSERT_EQ(camera_->addBuffer(stream, buffers[i].get()), 0)\n+\t\t\t\t<< \"Failed to add buffer\";\n+\t\t}\n+\t}\n }\n \n void Capture::stop()\n", "prefixes": [ "RFC", "v1", "41/54" ] }