Patch Detail
Show a patch.
GET /api/patches/27108/?format=api
{ "id": 27108, "url": "https://patchwork.libcamera.org/api/patches/27108/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27108/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-30-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:52", "name": "[RFC,v1,29/54] libcamera: request: enableStream(): Add", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "14cc0118fe8cd58179311dec3f6662b4f94829ea", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27108/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27108/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27108/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8272C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56E1B65F92;\n\tMon, 29 Jun 2026 18:31:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B29E65F33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:27 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 540CAE91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WjqPwSXp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750584;\n\tbh=4K1DR+Z1s585oyJz9UXE/kiOJs3cKR4OAQuWD9T9NNU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=WjqPwSXpr/cBqP4Yvdkt6fKvb9v9H/x7OhIzGnF6FF9UIp8DpjtdE90koYPODxoFU\n\tYj8I5ZWRO24zj+ex0qKTbUYb3rI0UVUrp6/h7mmnZOpRUGF31SkF/u+7IDSwXgzlZI\n\t9KMcvvBexI/5jB4LyT0vISijiauduHYB8QTVyW84=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 29/54] libcamera: request: enableStream(): Add", "Date": "Mon, 29 Jun 2026 18:29:52 +0200", "Message-ID": "<20260629163017.863145-30-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a funtion that can enable/disable streams without adding buffers.\nSpecifically, use a `nullptr` as buffer to mark enabled stream. Adjust\n`completeBuffer()` to set the buffer pointer in the map.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp | 30 +++++++++++++++++++++++++++++-\n 2 files changed, 30 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 290983f613..c86259c59b 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -55,6 +55,7 @@ public:\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr<Fence> &&fence = {});\n \tFrameBuffer *findBuffer(const Stream *stream) const;\n+\tvoid enableStream(const Stream *stream, bool enabled);\n \n \tuint32_t sequence() const;\n \tuint64_t cookie() const { return cookie_; }\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 5bb1617b51..d7cf39ae2e 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -110,13 +110,16 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer)\n \tRequest *request = LIBCAMERA_O_PTR();\n \tcamera_->bufferCompleted.emit(request, buffer);\n \n-\tASSERT(request->findBuffer(buffer->_d()->stream_) == buffer);\n+\tauto it = request->bufferMap_.find(buffer->_d()->stream_);\n+\tASSERT(it != request->bufferMap_.end());\n+\tASSERT(it->second == buffer || !it->second);\n \n \tASSERT(pending_ > 0);\n \tpending_ -= 1;\n \n \tbuffer->_d()->setRequest(nullptr);\n \tbuffer->_d()->stream_ = nullptr;\n+\tit->second = buffer;\n \n \tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n \t\tcancelled_ = true;\n@@ -337,6 +340,31 @@ FrameBuffer *Request::findBuffer(const Stream *stream) const\n \treturn it->second;\n }\n \n+/**\n+ * \\brief Change whether the particular stream should be captured\n+ * \\param[in] stream The stream\n+ * \\param[in] enabled Whether to enable or disable the stream\n+ */\n+void Request::enableStream(const Stream *stream, bool enabled)\n+{\n+\tASSERT(stream);\n+\n+\tRequest::Private *const d = _d();\n+\n+\tif (enabled) {\n+\t\tconst auto [it, inserted] = bufferMap_.try_emplace(stream);\n+\n+\t\tit->second = nullptr;\n+\t\td->pending_ += inserted;\n+\t} else {\n+\t\td->pending_ -= bufferMap_.erase(stream);\n+\t}\n+\n+\tLOG(Request, Debug)\n+\t\t<< \"request:\" << this << \" stream:\" << stream\n+\t\t<< ' ' << (enabled ? \"en\" : \"dis\") << \"abled pending:\" << d->pending_;\n+}\n+\n /**\n * \\brief Retrieve the sequence number for the request\n *\n", "prefixes": [ "RFC", "v1", "29/54" ] }