Patch Detail
Show a patch.
GET /api/patches/27100/?format=api
{ "id": 27100, "url": "https://patchwork.libcamera.org/api/patches/27100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-21-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:43", "name": "[RFC,v1,20/54] libcamera: framebuffer: Store associated Stream", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a56a1c226bbbbcdd2f2cb224317f7dd409bccd1a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27100/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C56A3C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5223B65F5D;\n\tMon, 29 Jun 2026 18:31:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 953A265F35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:25 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B7808D4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ULN9oESJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750582;\n\tbh=4/PLcbRs+8EHIOon+V3jxlyjcguVLwiBB0QOCOiWP3w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ULN9oESJed7hs5pDqshUAAI5qPett158uwFfSRI7vKFB/yM1WK957HbPz8LR7GX8q\n\tXZT47C62TSKt6H3oS9FW91Iyh2ekXAi0y/PfmbbrbMIwj9/wq+3I12SUSj6+OvJ+ZJ\n\tK9w6DVSYlMUhhXIveNbYpwkUvlZsbf/Qi5gRgO2I=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 20/54] libcamera: framebuffer: Store associated Stream", "Date": "Mon, 29 Jun 2026 18:29:43 +0200", "Message-ID": "<20260629163017.863145-21-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Store the Stream of the Camera that will capture data into the buffer.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/framebuffer.h | 4 ++++\n src/libcamera/framebuffer.cpp | 8 ++++++++\n src/libcamera/request.cpp | 5 +++++\n 3 files changed, 17 insertions(+)", "diff": "diff --git a/include/libcamera/internal/framebuffer.h b/include/libcamera/internal/framebuffer.h\nindex 7e96100b6c..466ddc1b73 100644\n--- a/include/libcamera/internal/framebuffer.h\n+++ b/include/libcamera/internal/framebuffer.h\n@@ -19,6 +19,8 @@\n \n namespace libcamera {\n \n+class Stream;\n+\n class FrameBuffer::Private : public Extensible::Private\n {\n \tLIBCAMERA_DECLARE_PUBLIC(FrameBuffer)\n@@ -39,6 +41,8 @@ public:\n \n \tFrameMetadata &metadata() { return metadata_; }\n \n+\tconst Stream *stream_ = nullptr;\n+\n private:\n \tstd::vector<Plane> planes_;\n \tFrameMetadata metadata_;\ndiff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 4f23df6482..baa298a8e3 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -232,6 +232,14 @@ FrameBuffer::Private::~Private()\n * \\brief Retrieve the dynamic metadata\n * \\return Dynamic metadata for the frame contained in the buffer\n */\n+\n+/**\n+ * \\var FrameBuffer::Private::stream_\n+ * \\brief The Stream the buffer belongs to\n+ *\n+ * This member designates the Stream of the Camera that the buffer belongs\n+ * to at the moment.\n+ */\n #endif /* __DOXYGEN_PUBLIC__ */\n \n /**\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex b1a81e36ef..278d993445 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -107,10 +107,13 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer)\n \tRequest *request = LIBCAMERA_O_PTR();\n \tcamera_->bufferCompleted.emit(request, buffer);\n \n+\tASSERT(request->findBuffer(buffer->_d()->stream_) == buffer);\n+\n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n \n \tbuffer->_d()->setRequest(nullptr);\n+\tbuffer->_d()->stream_ = nullptr;\n \n \tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n \t\tcancelled_ = true;\n@@ -147,6 +150,7 @@ void Request::Private::doCancelRequest()\n \t\tbuffer->_d()->cancel();\n \t\tcamera_->bufferCompleted.emit(request, buffer);\n \t\tbuffer->_d()->setRequest(nullptr);\n+\t\tbuffer->_d()->stream_ = nullptr;\n \t}\n \n \tcancelled_ = true;\n@@ -495,6 +499,7 @@ int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t}\n \n \tbuffer->_d()->setRequest(this);\n+\tbuffer->_d()->stream_ = stream;\n \t_d()->pending_.insert(buffer);\n \n \tif (fence && fence->isValid())\n", "prefixes": [ "RFC", "v1", "20/54" ] }