Patch Detail
Show a patch.
GET /api/patches/27093/?format=api
{ "id": 27093, "url": "https://patchwork.libcamera.org/api/patches/27093/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27093/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-14-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:36", "name": "[RFC,v1,13/54] v4l2: v4l2_camera: Rename `Buffer` to `CompletedBuffer`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0d7116cc76c6153c83b7cafd4879ceec8857a018", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27093/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27093/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27093/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45064C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A3E465F70;\n\tMon, 29 Jun 2026 18:30:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D861865F3B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:23 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A32D18D4;\n\tMon, 29 Jun 2026 18:29:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l2xXtJLs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750580;\n\tbh=LqtsnaMtOlhRDgFmn13fgnQAF7gGluEBp5g0nxaUHuw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l2xXtJLsB39aH3YV7H2abCYJDo14tqk6UFjfFrvXPo1/JVpVujIutMDMHBMxpUOD8\n\t3qk8yFDWCe99J6qrl/jlz+tPGMr9U8ALM5rd5IFy571ZsxxqB8cWy4iqlhS46/fUpE\n\tf01dZIAxgxIxcKHCJhE6BaXN4Vs7YnZLH916JkXw=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v1 13/54] v4l2: v4l2_camera: Rename `Buffer` to\n\t`CompletedBuffer`", "Date": "Mon, 29 Jun 2026 18:29:36 +0200", "Message-ID": "<20260629163017.863145-14-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This expresses the meaning better.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 2 +-\n src/v4l2/v4l2_camera.h | 8 ++++----\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++--\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 7dd0ea1ef9..e72b73a22a 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -68,7 +68,7 @@ void V4L2Camera::unbind()\n \tefd_ = -1;\n }\n \n-std::vector<V4L2Camera::Buffer> V4L2Camera::completedBuffers()\n+std::vector<V4L2Camera::CompletedBuffer> V4L2Camera::completedBuffers()\n {\n \tMutexLocker lock(bufferLock_);\n \tstd::vector v(std::move_iterator(completedBuffers_.begin()),\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 8a58169d89..1d90eb43e4 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -23,8 +23,8 @@\n class V4L2Camera\n {\n public:\n-\tstruct Buffer {\n-\t\tBuffer(unsigned int index, const libcamera::FrameMetadata &data)\n+\tstruct CompletedBuffer {\n+\t\tCompletedBuffer(unsigned int index, const libcamera::FrameMetadata &data)\n \t\t\t: index_(index), data_(data)\n \t\t{\n \t\t}\n@@ -41,7 +41,7 @@ public:\n \tvoid bind(int efd);\n \tvoid unbind();\n \n-\tstd::vector<Buffer> completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_);\n+\tstd::vector<CompletedBuffer> completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_);\n \n \tint configure(libcamera::StreamConfiguration *streamConfigOut,\n \t\t const libcamera::Size &size,\n@@ -85,7 +85,7 @@ private:\n \tstd::vector<std::unique_ptr<libcamera::Request>> requestPool_;\n \n \tstd::deque<libcamera::Request *> pendingRequests_;\n-\tstd::deque<Buffer> completedBuffers_\n+\tstd::deque<CompletedBuffer> completedBuffers_\n \t\tLIBCAMERA_TSA_GUARDED_BY(bufferLock_);\n \n \tint efd_;\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex ee44767bd3..02b238c81b 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -243,8 +243,8 @@ void V4L2CameraProxy::querycap(std::shared_ptr<Camera> camera)\n \n void V4L2CameraProxy::updateBuffers()\n {\n-\tstd::vector<V4L2Camera::Buffer> completedBuffers = vcam_->completedBuffers();\n-\tfor (const V4L2Camera::Buffer &buffer : completedBuffers) {\n+\tstd::vector<V4L2Camera::CompletedBuffer> completedBuffers = vcam_->completedBuffers();\n+\tfor (const V4L2Camera::CompletedBuffer &buffer : completedBuffers) {\n \t\tconst FrameMetadata &fmd = buffer.data_;\n \t\tstruct v4l2_buffer &buf = buffers_[buffer.index_];\n \n", "prefixes": [ "RFC", "v1", "13/54" ] }