From patchwork Mon Jun 29 16:29:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27093 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 45064C3261 for ; Mon, 29 Jun 2026 16:31:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2A3E465F70; Mon, 29 Jun 2026 18:30:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l2xXtJLs"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D861865F3B for ; Mon, 29 Jun 2026 18:30:23 +0200 (CEST) Received: from pb-laptop.local (185.221.140.128.nat.pool.zt.hu [185.221.140.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A32D18D4; Mon, 29 Jun 2026 18:29:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782750580; bh=LqtsnaMtOlhRDgFmn13fgnQAF7gGluEBp5g0nxaUHuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l2xXtJLsB39aH3YV7H2abCYJDo14tqk6UFjfFrvXPo1/JVpVujIutMDMHBMxpUOD8 3qk8yFDWCe99J6qrl/jlz+tPGMr9U8ALM5rd5IFy571ZsxxqB8cWy4iqlhS46/fUpE f01dZIAxgxIxcKHCJhE6BaXN4Vs7YnZLH916JkXw= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Paul Elder Subject: [RFC PATCH v1 13/54] v4l2: v4l2_camera: Rename `Buffer` to `CompletedBuffer` Date: Mon, 29 Jun 2026 18:29:36 +0200 Message-ID: <20260629163017.863145-14-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> References: <20260629163017.863145-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This expresses the meaning better. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/v4l2/v4l2_camera.cpp | 2 +- src/v4l2/v4l2_camera.h | 8 ++++---- src/v4l2/v4l2_camera_proxy.cpp | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp index 7dd0ea1ef9..e72b73a22a 100644 --- a/src/v4l2/v4l2_camera.cpp +++ b/src/v4l2/v4l2_camera.cpp @@ -68,7 +68,7 @@ void V4L2Camera::unbind() efd_ = -1; } -std::vector V4L2Camera::completedBuffers() +std::vector V4L2Camera::completedBuffers() { MutexLocker lock(bufferLock_); std::vector v(std::move_iterator(completedBuffers_.begin()), diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h index 8a58169d89..1d90eb43e4 100644 --- a/src/v4l2/v4l2_camera.h +++ b/src/v4l2/v4l2_camera.h @@ -23,8 +23,8 @@ class V4L2Camera { public: - struct Buffer { - Buffer(unsigned int index, const libcamera::FrameMetadata &data) + struct CompletedBuffer { + CompletedBuffer(unsigned int index, const libcamera::FrameMetadata &data) : index_(index), data_(data) { } @@ -41,7 +41,7 @@ public: void bind(int efd); void unbind(); - std::vector completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_); + std::vector completedBuffers() LIBCAMERA_TSA_EXCLUDES(bufferLock_); int configure(libcamera::StreamConfiguration *streamConfigOut, const libcamera::Size &size, @@ -85,7 +85,7 @@ private: std::vector> requestPool_; std::deque pendingRequests_; - std::deque completedBuffers_ + std::deque completedBuffers_ LIBCAMERA_TSA_GUARDED_BY(bufferLock_); int efd_; diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index ee44767bd3..02b238c81b 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -243,8 +243,8 @@ void V4L2CameraProxy::querycap(std::shared_ptr camera) void V4L2CameraProxy::updateBuffers() { - std::vector completedBuffers = vcam_->completedBuffers(); - for (const V4L2Camera::Buffer &buffer : completedBuffers) { + std::vector completedBuffers = vcam_->completedBuffers(); + for (const V4L2Camera::CompletedBuffer &buffer : completedBuffers) { const FrameMetadata &fmd = buffer.data_; struct v4l2_buffer &buf = buffers_[buffer.index_];