Patch Detail
Show a patch.
GET /api/patches/27061/?format=api
{ "id": 27061, "url": "https://patchwork.libcamera.org/api/patches/27061/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27061/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260626-ipu3-libipa-rework-v2-1-41546e23de3e@ideasonboard.com>", "date": "2026-06-26T13:05:48", "name": "[v2,01/12] ipa: ipu3: Remove ~Awb() from source and header", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "061c1dcb33458323da3a2f4e8f592d90ae0915f8", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27061/mbox/", "series": [ { "id": 6022, "url": "https://patchwork.libcamera.org/api/series/6022/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6022", "date": "2026-06-26T13:05:47", "name": "libipa: Re-work IPU3 IPA to use libipa algorithms", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6022/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27061/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27061/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62A85C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 13:06:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E8F865EFA;\n\tFri, 26 Jun 2026 15:06:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3423658FA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 15:06:04 +0200 (CEST)", "from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF13FE2C;\n\tFri, 26 Jun 2026 15:05:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HrErYQgn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782479124;\n\tbh=doQKSK44QFyMvkC8EuIN8TSx1AHGSeggFu6MvvflL20=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=HrErYQgnQCk8aCR/Yrs1VcWf9HFwMYVJ5BbzL9Dzd73icaOvZUDktCZ0z2XR9iDhe\n\tvkgVWn+P6zNhRafntVi7oyC/Dw6oFyul5VawJL/CEPZ5gTbc5ZyoKGhMb2zJqymvEW\n\t7LhvdAPmpVuvSDMsIVJZdGe0nQtu+vOJMu76mryk=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "Date": "Fri, 26 Jun 2026 14:05:48 +0100", "Subject": "[PATCH v2 01/12] ipa: ipu3: Remove ~Awb() from source and header", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260626-ipu3-libipa-rework-v2-1-41546e23de3e@ideasonboard.com>", "References": "<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>", "In-Reply-To": "<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_?=\n\t=?utf-8?b?UMWRY3pl?= <barnabas.pocze@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1403;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=doQKSK44QFyMvkC8EuIN8TSx1AHGSeggFu6MvvflL20=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqPnk5CiUTqb17OcRJiaaNPY5acNs8we4Wd04uK\n\tEOs5U4rg76JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaj55OQAKCRDISVd6bEV1\n\tMh0uD/oC4/b6XTwuPn+lLK3qDp548EmUzgPHkgrqK6Gky+6akW9QGYzQ12jcCUSH9OwGk2LW0lD\n\tdCzC8tTMM16M8QVJKwWCRljb8FXC2qv6Z15H05wbg0K1F1qHlaep4cHXD4gnH5jbgycgwLRAgEJ\n\tgavwFFl7WbuPVi1ITsfxEH+meBAUuvZlctOAFm8FX0QVHOYrjSPeAwDjN4Qqxm+e8hM6q52/Xnb\n\tLPbcv9uc5wySDhbxmdu9KXLlp7B63CVOvp0bjTAVseRe1PTXl+e70cZbzE95sUi0j1RjK6TAET9\n\t7MQYyXHbJoKkm6bzkP2CXm4PBivhexYcCI+Q2n8xgc5gtwI2cvtjZVf1eam4vGpJjsktjEW0sP2\n\ttiC684YtbosQll5yJ+O5t7Br9UonBdDD7rFiK1BGavPhr5egI52jmkyjv6lkyDnWxCb52V5qPJf\n\tbpRWqARqnJmP5PbAj46e/AAqMpbx+3GS/DePemH8agHF3kUZOaCiqjFbs8le5Q7DusxNGkzbjYL\n\t2AXWQqDWs+LkPTAUxldEh6nVrvK8VMYVnj13jsPBRV102reckRSCNqC4ij5VoSf3d5A9A8iDbCT\n\t3c5LjE+x+emPC54gfmLF6Svu06BNJmS3I0TYYUYW46y4p37/yIbPW+6UfxBt2poUrhs/c0RTOMv\n\tr8evmJU2inVVAtA==", "X-Developer-Key": "i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the ~Awb() definition from the source and header files and\nsimply allow the compiler to provide the default implementations.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v2:\n\n\t- None\n---\n src/ipa/ipu3/algorithms/awb.cpp | 2 --\n src/ipa/ipu3/algorithms/awb.h | 1 -\n 2 files changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -195,8 +195,6 @@ Awb::Awb()\n \tzones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n }\n \n-Awb::~Awb() = default;\n-\n /**\n * \\copydoc libcamera::ipa::Algorithm::configure\n */\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -38,7 +38,6 @@ class Awb : public Algorithm\n {\n public:\n \tAwb();\n-\t~Awb();\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n", "prefixes": [ "v2", "01/12" ] }