From patchwork Fri Jun 26 13:05:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 27061 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 62A85C3301 for ; Fri, 26 Jun 2026 13:06:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E8F865EFA; Fri, 26 Jun 2026 15:06:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HrErYQgn"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F3423658FA for ; Fri, 26 Jun 2026 15:06:04 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DF13FE2C; Fri, 26 Jun 2026 15:05:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782479124; bh=doQKSK44QFyMvkC8EuIN8TSx1AHGSeggFu6MvvflL20=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=HrErYQgnQCk8aCR/Yrs1VcWf9HFwMYVJ5BbzL9Dzd73icaOvZUDktCZ0z2XR9iDhe vkgVWn+P6zNhRafntVi7oyC/Dw6oFyul5VawJL/CEPZ5gTbc5ZyoKGhMb2zJqymvEW 7LhvdAPmpVuvSDMsIVJZdGe0nQtu+vOJMu76mryk= From: Daniel Scally Date: Fri, 26 Jun 2026 14:05:48 +0100 Subject: [PATCH v2 01/12] ipa: ipu3: Remove ~Awb() from source and header MIME-Version: 1.0 Message-Id: <20260626-ipu3-libipa-rework-v2-1-41546e23de3e@ideasonboard.com> References: <20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com> In-Reply-To: <20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_?= =?utf-8?b?UMWRY3pl?= , Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1403; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=doQKSK44QFyMvkC8EuIN8TSx1AHGSeggFu6MvvflL20=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqPnk5CiUTqb17OcRJiaaNPY5acNs8we4Wd04uK EOs5U4rg76JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaj55OQAKCRDISVd6bEV1 Mh0uD/oC4/b6XTwuPn+lLK3qDp548EmUzgPHkgrqK6Gky+6akW9QGYzQ12jcCUSH9OwGk2LW0lD dCzC8tTMM16M8QVJKwWCRljb8FXC2qv6Z15H05wbg0K1F1qHlaep4cHXD4gnH5jbgycgwLRAgEJ gavwFFl7WbuPVi1ITsfxEH+meBAUuvZlctOAFm8FX0QVHOYrjSPeAwDjN4Qqxm+e8hM6q52/Xnb LPbcv9uc5wySDhbxmdu9KXLlp7B63CVOvp0bjTAVseRe1PTXl+e70cZbzE95sUi0j1RjK6TAET9 7MQYyXHbJoKkm6bzkP2CXm4PBivhexYcCI+Q2n8xgc5gtwI2cvtjZVf1eam4vGpJjsktjEW0sP2 tiC684YtbosQll5yJ+O5t7Br9UonBdDD7rFiK1BGavPhr5egI52jmkyjv6lkyDnWxCb52V5qPJf bpRWqARqnJmP5PbAj46e/AAqMpbx+3GS/DePemH8agHF3kUZOaCiqjFbs8le5Q7DusxNGkzbjYL 2AXWQqDWs+LkPTAUxldEh6nVrvK8VMYVnj13jsPBRV102reckRSCNqC4ij5VoSf3d5A9A8iDbCT 3c5LjE+x+emPC54gfmLF6Svu06BNJmS3I0TYYUYW46y4p37/yIbPW+6UfxBt2poUrhs/c0RTOMv r8evmJU2inVVAtA== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the ~Awb() definition from the source and header files and simply allow the compiler to provide the default implementations. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Signed-off-by: Daniel Scally --- Changes in v2: - None --- src/ipa/ipu3/algorithms/awb.cpp | 2 -- src/ipa/ipu3/algorithms/awb.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -195,8 +195,6 @@ Awb::Awb() zones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY); } -Awb::~Awb() = default; - /** * \copydoc libcamera::ipa::Algorithm::configure */ diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644 --- a/src/ipa/ipu3/algorithms/awb.h +++ b/src/ipa/ipu3/algorithms/awb.h @@ -38,7 +38,6 @@ class Awb : public Algorithm { public: Awb(); - ~Awb(); int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; void prepare(IPAContext &context, const uint32_t frame,