Patch Detail
Show a patch.
GET /api/patches/26980/?format=api
{ "id": 26980, "url": "https://patchwork.libcamera.org/api/patches/26980/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26980/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-16-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:32", "name": "[RFC,v1,15/27] libcamera: request: completeBuffer(): Emit `bufferCompleted` here", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "02fe7fa4a949221ac4064a30472cf9eb33f7b411", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26980/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26980/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26980/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1745AC330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9771D656EE;\n\tThu, 18 Jun 2026 14:39:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A0C46301A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:51 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 717CB2F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TnQr8Sl8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786296;\n\tbh=o4EqpachFxbgXREAs9t0tKVRdw4gsuifEkINBGGzND4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TnQr8Sl82zM/fXGjNYNsGX/ATt1Yrq/+vbkV5gl5SLQ5KsYRX4c2EF6QOiL0cbCn8\n\ta3Vtp1rn+/RTT3iy7mrMDdqhSdKKE4M07KkdtK5uUM5rFs0QLwYDhvaaL0fWyKyk1y\n\toPrtzkgTyiHizI3MVkju6amwmkGlkzLp9+gVQf+k=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 15/27] libcamera: request: completeBuffer(): Emit\n\t`bufferCompleted` here", "Date": "Thu, 18 Jun 2026 14:38:32 +0200", "Message-ID": "<20260618123844.656396-16-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `Request` class already manages the emission of that signal in\n`doCancelRequest()`, so let's move the normal emission from the pipeline\nhandler base class while keeping the ordering of things.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 2 --\n src/libcamera/request.cpp | 3 +++\n 2 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e7145c1d48..3d49f85cfa 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -562,8 +562,6 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n */\n bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n {\n-\tCamera *camera = request->_d()->camera();\n-\tcamera->bufferCompleted.emit(request, buffer);\n \treturn request->_d()->completeBuffer(buffer);\n }\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 5f983e0ce6..022a97f169 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -104,6 +104,9 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer)\n {\n \tLIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer);\n \n+\tRequest *request = LIBCAMERA_O_PTR();\n+\tcamera_->bufferCompleted.emit(request, buffer);\n+\n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n \n", "prefixes": [ "RFC", "v1", "15/27" ] }