From patchwork Thu Jun 18 12:38:32 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26980 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1745AC330F for ; Thu, 18 Jun 2026 12:39:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9771D656EE; Thu, 18 Jun 2026 14:39:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TnQr8Sl8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A0C46301A for ; Thu, 18 Jun 2026 14:38:51 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 717CB2F8 for ; Thu, 18 Jun 2026 14:38:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786296; bh=o4EqpachFxbgXREAs9t0tKVRdw4gsuifEkINBGGzND4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TnQr8Sl82zM/fXGjNYNsGX/ATt1Yrq/+vbkV5gl5SLQ5KsYRX4c2EF6QOiL0cbCn8 a3Vtp1rn+/RTT3iy7mrMDdqhSdKKE4M07KkdtK5uUM5rFs0QLwYDhvaaL0fWyKyk1y oPrtzkgTyiHizI3MVkju6amwmkGlkzLp9+gVQf+k= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 15/27] libcamera: request: completeBuffer(): Emit `bufferCompleted` here Date: Thu, 18 Jun 2026 14:38:32 +0200 Message-ID: <20260618123844.656396-16-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The `Request` class already manages the emission of that signal in `doCancelRequest()`, so let's move the normal emission from the pipeline handler base class while keeping the ordering of things. Signed-off-by: Barnabás Pőcze --- src/libcamera/pipeline_handler.cpp | 2 -- src/libcamera/request.cpp | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index e7145c1d48..3d49f85cfa 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -562,8 +562,6 @@ void PipelineHandler::doQueueRequests(Camera *camera) */ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer) { - Camera *camera = request->_d()->camera(); - camera->bufferCompleted.emit(request, buffer); return request->_d()->completeBuffer(buffer); } diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 5f983e0ce6..022a97f169 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -104,6 +104,9 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer) { LIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer); + Request *request = LIBCAMERA_O_PTR(); + camera_->bufferCompleted.emit(request, buffer); + int ret = pending_.erase(buffer); ASSERT(ret == 1);