Patch Detail
Show a patch.
GET /api/patches/26975/?format=api
{ "id": 26975, "url": "https://patchwork.libcamera.org/api/patches/26975/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26975/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-12-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:28", "name": "[RFC,v1,11/27] libcamera: pipeline: rkisp1: Simplify dewarper configuration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "745d09959b9916840b120108e2e5600bf6d41837", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26975/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26975/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26975/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4902FC3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB16A62C71;\n\tThu, 18 Jun 2026 14:39:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9591562C7B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:50 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B09A92F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CfjemyL4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786295;\n\tbh=/sen95RERCEquFIDbNJtVDMphehdZ7RPBhlxdSVRpeg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CfjemyL4f1RapiGMG+ki5hXrpljvi93F6qQMdcataLAAFluYjc66cCVY6Cj551MAa\n\tZ9Cw9X1vkG1mWW5jEIo8xLLDMHL3B9SnfDXhOXjhVPg6bLaGO/MBht7gTCk2R8jxFC\n\tf4gXNkLuqPporIdy3D8khVdZe39He56c+foVnFRs=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 11/27] libcamera: pipeline: rkisp1: Simplify dewarper\n\tconfiguration", "Date": "Thu, 18 Jun 2026 14:38:28 +0200", "Message-ID": "<20260618123844.656396-12-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no need for to define a separate vector, initializing the\nargument in the call expression works. So do that.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 9606459fc2..4f9c0aa741 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1042,7 +1042,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tdata->properties_.set(properties::ScalerCropMaximum, sensorCrop);\n \n \tstd::map<unsigned int, IPAStream> streamConfig;\n-\tstd::vector<std::reference_wrapper<const StreamConfiguration>> outputCfgs;\n \n \tfor (const StreamConfiguration &cfg : *config) {\n \t\tif (cfg.stream() == &data->mainPathStream_) {\n@@ -1053,15 +1052,13 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t\t */\n \t\t\tStreamConfiguration ispCfg = cfg;\n \t\t\tif (data->usesDewarper_) {\n-\t\t\t\toutputCfgs.push_back(const_cast<StreamConfiguration &>(cfg));\n-\n \t\t\t\tispCfg.bufferCount = kRkISP1MinBufferCount;\n \t\t\t\tispCfg.size = format.size;\n \t\t\t\tispCfg.stride =\n \t\t\t\t\tPixelFormatInfo::info(ispCfg.pixelFormat)\n \t\t\t\t\t\t.stride(ispCfg.size.width, 0);\n \n-\t\t\t\tret = dewarper_->configure(ispCfg, outputCfgs);\n+\t\t\t\tret = dewarper_->configure(ispCfg, { cfg });\n \t\t\t\tif (ret)\n \t\t\t\t\treturn ret;\n \n", "prefixes": [ "RFC", "v1", "11/27" ] }