From patchwork Thu Jun 18 12:38:28 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26975 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4902FC3306 for ; Thu, 18 Jun 2026 12:39:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DB16A62C71; Thu, 18 Jun 2026 14:39:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CfjemyL4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9591562C7B for ; Thu, 18 Jun 2026 14:38:50 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B09A92F8 for ; Thu, 18 Jun 2026 14:38:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786295; bh=/sen95RERCEquFIDbNJtVDMphehdZ7RPBhlxdSVRpeg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CfjemyL4f1RapiGMG+ki5hXrpljvi93F6qQMdcataLAAFluYjc66cCVY6Cj551MAa Z9Cw9X1vkG1mWW5jEIo8xLLDMHL3B9SnfDXhOXjhVPg6bLaGO/MBht7gTCk2R8jxFC f4gXNkLuqPporIdy3D8khVdZe39He56c+foVnFRs= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 11/27] libcamera: pipeline: rkisp1: Simplify dewarper configuration Date: Thu, 18 Jun 2026 14:38:28 +0200 Message-ID: <20260618123844.656396-12-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" There is no need for to define a separate vector, initializing the argument in the call expression works. So do that. Signed-off-by: Barnabás Pőcze --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 9606459fc2..4f9c0aa741 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -1042,7 +1042,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) data->properties_.set(properties::ScalerCropMaximum, sensorCrop); std::map streamConfig; - std::vector> outputCfgs; for (const StreamConfiguration &cfg : *config) { if (cfg.stream() == &data->mainPathStream_) { @@ -1053,15 +1052,13 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) */ StreamConfiguration ispCfg = cfg; if (data->usesDewarper_) { - outputCfgs.push_back(const_cast(cfg)); - ispCfg.bufferCount = kRkISP1MinBufferCount; ispCfg.size = format.size; ispCfg.stride = PixelFormatInfo::info(ispCfg.pixelFormat) .stride(ispCfg.size.width, 0); - ret = dewarper_->configure(ispCfg, outputCfgs); + ret = dewarper_->configure(ispCfg, { cfg }); if (ret) return ret;