Patch Detail
Show a patch.
GET /api/patches/26965/?format=api
{ "id": 26965, "url": "https://patchwork.libcamera.org/api/patches/26965/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26965/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-2-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:18", "name": "[RFC,v1,01/27] apps: cam: Simplify buffer reuse", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cfc184a5f31c05d0c1d5e6e06b0528c52e0b5e2a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26965/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26965/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26965/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0855EBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:38:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1AB0656E7;\n\tThu, 18 Jun 2026 14:38:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C968C629AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:48 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B95A1DF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SV26I6Tl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786293;\n\tbh=+qbOOs9ZFFzV7sK0m0MjaIWTfgAYus9i/dOB6EryRB0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=SV26I6TlTvU9PE896mA29CVELe4Ww8+W4x4nhyzjaDn/gc8ZIrdx+ptPXg+C1fyKo\n\t0omm11s6YzGhD8pmriUjEILiZsYl1QK+l4h6QJJumyEL2zuvCO2sGWY5urTu/9Wuzu\n\t0hRxUyFDoQY1MltiMSM+Hvk++5ZJ07Z00mDdxl08=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 01/27] apps: cam: Simplify buffer reuse", "Date": "Thu, 18 Jun 2026 14:38:18 +0200", "Message-ID": "<20260618123844.656396-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove code duplication by calling `sinkRelease()` instead.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 17444a217b..ce8ee354f0 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -542,11 +542,8 @@ void CameraSession::processRequest(Request *request)\n \t * If the frame sink holds on the request, we'll requeue it later in the\n \t * complete handler.\n \t */\n-\tif (!requeue)\n-\t\treturn;\n-\n-\trequest->reuse(Request::ReuseBuffers);\n-\tqueueRequest(request);\n+\tif (requeue)\n+\t\tsinkRelease(request);\n }\n \n void CameraSession::sinkRelease(Request *request)\n", "prefixes": [ "RFC", "v1", "01/27" ] }