From patchwork Thu Jun 18 12:38:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26965 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0855EBF415 for ; Thu, 18 Jun 2026 12:38:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D1AB0656E7; Thu, 18 Jun 2026 14:38:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SV26I6Tl"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C968C629AD for ; Thu, 18 Jun 2026 14:38:48 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B95A1DF3 for ; Thu, 18 Jun 2026 14:38:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786293; bh=+qbOOs9ZFFzV7sK0m0MjaIWTfgAYus9i/dOB6EryRB0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=SV26I6TlTvU9PE896mA29CVELe4Ww8+W4x4nhyzjaDn/gc8ZIrdx+ptPXg+C1fyKo 0omm11s6YzGhD8pmriUjEILiZsYl1QK+l4h6QJJumyEL2zuvCO2sGWY5urTu/9Wuzu 0hRxUyFDoQY1MltiMSM+Hvk++5ZJ07Z00mDdxl08= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 01/27] apps: cam: Simplify buffer reuse Date: Thu, 18 Jun 2026 14:38:18 +0200 Message-ID: <20260618123844.656396-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove code duplication by calling `sinkRelease()` instead. Signed-off-by: Barnabás Pőcze --- src/apps/cam/camera_session.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp index 17444a217b..ce8ee354f0 100644 --- a/src/apps/cam/camera_session.cpp +++ b/src/apps/cam/camera_session.cpp @@ -542,11 +542,8 @@ void CameraSession::processRequest(Request *request) * If the frame sink holds on the request, we'll requeue it later in the * complete handler. */ - if (!requeue) - return; - - request->reuse(Request::ReuseBuffers); - queueRequest(request); + if (requeue) + sinkRelease(request); } void CameraSession::sinkRelease(Request *request)