Patch Detail
Show a patch.
GET /api/patches/26825/?format=api
{ "id": 26825, "url": "https://patchwork.libcamera.org/api/patches/26825/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26825/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260604095105.68798-5-mzamazal@redhat.com>", "date": "2026-06-04T09:50:46", "name": "[RFC,v3,03/17] libcamera: software_isp: Queue the input buffer per each output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b68d10f81b09339d53ccc32593e59681fe8833fe", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26825/mbox/", "series": [ { "id": 5977, "url": "https://patchwork.libcamera.org/api/series/5977/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5977", "date": "2026-06-04T09:50:46", "name": null, "version": 3, "mbox": "https://patchwork.libcamera.org/series/5977/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26825/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26825/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73984C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Jun 2026 09:51:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F76163403;\n\tThu, 4 Jun 2026 11:51:30 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E66663410\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jun 2026 11:51:28 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-345-dvj0Y8TYPViBzLusgtuU0Q-1;\n\tThu, 04 Jun 2026 05:51:23 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8CDF418004A9; Thu, 4 Jun 2026 09:51:22 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BE7CD30001A1; Thu, 4 Jun 2026 09:51:20 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"E2DM6owh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780566687;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=dnADbDcIZZnwB1EsPMd9G2vZ8oIeyRhK0d+Bo3HsHVc=;\n\tb=E2DM6owh3+uma2y3fY88OgU42oUxDC1vU9NNgh286kYLAPc0XVMlNVXxStG7LzGpa6xuj0\n\tf9vntkbGgmXcYqEyCXR+EoZviNc5IgswV1HQVSOg9Q67+n1mkABN7EUddMeg/eDVsBb523\n\tPbtgpL/bKR5lwl6D9zt/cSeTVTMRszc=", "X-MC-Unique": "dvj0Y8TYPViBzLusgtuU0Q-1", "X-Mimecast-MFC-AGG-ID": "dvj0Y8TYPViBzLusgtuU0Q_1780566682", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>,\n\tjohannes.goede@oss.qualcomm.com", "Subject": "[RFC PATCH v3 03/17] libcamera: software_isp: Queue the input buffer\n\tper each output", "Date": "Thu, 4 Jun 2026 11:50:46 +0200", "Message-ID": "<20260604095105.68798-5-mzamazal@redhat.com>", "In-Reply-To": "<20260604095105.68798-1-mzamazal@redhat.com>", "References": "<20260604095105.68798-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "XT83al2WpikaT-pPnbqVP3Aqy1KdlWrKqmp6gHIVo3I_1780566682", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Multiple outputs are not supported, but if they were, the input buffer\nshould be queued for each of them because each output buffer processing\nemits inputBufferReady.\n\nCurrently, with a single output, it doesn't change anything.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex f5b44f4e5..f17f1ca1f 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -342,9 +342,8 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input,\n \t\t\treturn -EINVAL;\n \t}\n \n-\tqueuedInputBuffers_.push_back(input);\n-\n \tfor (const auto &[stream, buffer] : outputs) {\n+\t\tqueuedInputBuffers_.push_back(input);\n \t\tqueuedOutputBuffers_.push_back(buffer);\n \t\tprocess(frame, input, buffer);\n \t}\n", "prefixes": [ "RFC", "v3", "03/17" ] }