[{"id":39004,"web_url":"https://patchwork.libcamera.org/comment/39004/","msgid":"<178059780722.1119811.14759742180852929457@ping.linuxembedded.co.uk>","date":"2026-06-04T18:30:07","subject":"Re: [RFC PATCH v3 03/17] libcamera: software_isp: Queue the input\n\tbuffer per each output","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2026-06-04 10:50:46)\n> Multiple outputs are not supported, but if they were, the input buffer\n> should be queued for each of them because each output buffer processing\n> emits inputBufferReady.\n> \n> Currently, with a single output, it doesn't change anything.\n\nI could imagine we might want to make SoftISP support multiple outputs\nindeed, perhaps when we have multi-pass so we could run the rescaler or\ndifferent stages independently.\n\nAnd this makes it more like the other pipelines, so I think it's\nhelpful:\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/software_isp/software_isp.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index f5b44f4e5..f17f1ca1f 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -342,9 +342,8 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input,\n> return -EINVAL;\n> }\n> \n> - queuedInputBuffers_.push_back(input);\n> -\n> for (const auto &[stream, buffer] : outputs) {\n> + queuedInputBuffers_.push_back(input);\n> queuedOutputBuffers_.push_back(buffer);\n> process(frame, input, buffer);\n> }\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2C6FC328C\n\tfor ;\n\tThu, 4 Jun 2026 18:30:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AC316344D;\n\tThu, 4 Jun 2026 20:30:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A5B062DC4\n\tfor ;\n\tThu, 4 Jun 2026 20:30:09 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66FEF13D7;\n\tThu, 4 Jun 2026 20:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JM6ww0+O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780597784;\n\tbh=xVOqKQpgJuwEA9S6CmKQ4plNdd0NPVBEWmg7+bfYPM8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JM6ww0+OJmeAcRIGYS5ZNQ0b9nJJ1rrfIFcCmRaG2e4mblbX4u47kQWnk0FFkY9It\n\tJxoyfxDvcLn1ByECSgn/NiWjpFNHY5EOKB8rsSs5TC4q79rIyY9PdtkFP+0ng0jSus\n\t/EXh56IbdLxbSqX77xPTylqhdK32MavyKmSuL7e8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260604095105.68798-5-mzamazal@redhat.com>","References":"<20260604095105.68798-1-mzamazal@redhat.com>\n\t<20260604095105.68798-5-mzamazal@redhat.com>","Subject":"Re: [RFC PATCH v3 03/17] libcamera: software_isp: Queue the input\n\tbuffer per each output","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tjohannes.goede@oss.qualcomm.com","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 04 Jun 2026 19:30:07 +0100","Message-ID":"<178059780722.1119811.14759742180852929457@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]