Patch Detail
Show a patch.
GET /api/patches/26823/?format=api
{ "id": 26823, "url": "https://patchwork.libcamera.org/api/patches/26823/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26823/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260604095105.68798-3-mzamazal@redhat.com>", "date": "2026-06-04T09:50:44", "name": "[RFC,v3,02/17] libcamera: ipa: simple: Rename setIspParams to paramsComputed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a577720d445080aac07171f097818267be5ac313", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26823/mbox/", "series": [ { "id": 5976, "url": "https://patchwork.libcamera.org/api/series/5976/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5976", "date": "2026-06-04T09:50:42", "name": "Software ISP: Share params and stats buffers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5976/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26823/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26823/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AEBDC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Jun 2026 09:51:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9800633C9;\n\tThu, 4 Jun 2026 11:51:25 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A44AC632B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jun 2026 11:51:23 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-615-DPh17l5KPf-Lva8U046gGw-1;\n\tThu, 04 Jun 2026 05:51:19 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 110DA1956046; Thu, 4 Jun 2026 09:51:18 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.156])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4A82230001A1; Thu, 4 Jun 2026 09:51:15 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WRQpB5O7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780566682;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=K+Q6pcsqu6yLpUtmH5cnrwW6Czo6+a2wr6NusK2cflU=;\n\tb=WRQpB5O7LyGcT/WDoCUsHFNwIF/mqlIRdofuBvgZfmAo29h9ifXVdoehSQvP2GrifUTKA3\n\tzud2+E7QDOsEb/TVmRNta+JG3wC/UMMYtWhMlFxmwRn/q+7DzSSuQVC4jv/jZ1knWfFcWI\n\tJUIuj7nB3L1NqqqvAZpqVhn2tYdgeU4=", "X-MC-Unique": "DPh17l5KPf-Lva8U046gGw-1", "X-Mimecast-MFC-AGG-ID": "DPh17l5KPf-Lva8U046gGw_1780566678", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>,\n\tjohannes.goede@oss.qualcomm.com", "Subject": "[RFC PATCH v3 02/17] libcamera: ipa: simple: Rename setIspParams to\n\tparamsComputed", "Date": "Thu, 4 Jun 2026 11:50:44 +0200", "Message-ID": "<20260604095105.68798-3-mzamazal@redhat.com>", "In-Reply-To": "<20260604095105.68798-1-mzamazal@redhat.com>", "References": "<20260604095105.68798-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "yy3zyoLlxejiFxr19l3VGA8BuEAxA67Z9GPkryQsSKw_1780566678", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For better consistency with other pipelines.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/ipa/soft.mojom | 2 +-\n src/ipa/simple/soft_simple.cpp | 2 +-\n src/libcamera/software_isp/software_isp.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..e75b03a3d 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -33,6 +33,6 @@ interface IPASoftInterface {\n \n interface IPASoftEventInterface {\n \tsetSensorControls(libcamera.ControlList sensorControls);\n-\tsetIspParams();\n+\tparamsComputed();\n \tmetadataReady(uint32 frame, libcamera.ControlList metadata);\n };\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 629e1a32d..cfc1389e4 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -292,7 +292,7 @@ void IPASoftSimple::computeParams(const uint32_t frame)\n \t\talgo->prepare(context_, frame, frameContext, params_);\n \tparams_->combinedMatrix = context_.activeState.combinedMatrix;\n \n-\tsetIspParams.emit();\n+\tparamsComputed.emit();\n }\n \n void IPASoftSimple::processStats(const uint32_t frame,\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 224a2fa7c..f5b44f4e5 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -164,7 +164,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\treturn;\n \t}\n \n-\tipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams);\n+\tipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams);\n \tipa_->metadataReady.connect(this,\n \t\t\t\t [this](uint32_t frame, const ControlList &metadata) {\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n", "prefixes": [ "RFC", "v3", "02/17" ] }