[{"id":39002,"web_url":"https://patchwork.libcamera.org/comment/39002/","msgid":"<178059719679.1119811.953424868321717255@ping.linuxembedded.co.uk>","date":"2026-06-04T18:19:56","subject":"Re: [RFC PATCH v3 02/17] libcamera: ipa: simple: Rename setIspParams\n\tto paramsComputed","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2026-06-04 10:50:44)\n> For better consistency with other pipelines.\n\nI'm all for consistency here.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Milan Zamazal \n> ---\n> include/libcamera/ipa/soft.mojom | 2 +-\n> src/ipa/simple/soft_simple.cpp | 2 +-\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\n> index 77328c5fd..e75b03a3d 100644\n> --- a/include/libcamera/ipa/soft.mojom\n> +++ b/include/libcamera/ipa/soft.mojom\n> @@ -33,6 +33,6 @@ interface IPASoftInterface {\n> \n> interface IPASoftEventInterface {\n> setSensorControls(libcamera.ControlList sensorControls);\n> - setIspParams();\n> + paramsComputed();\n> metadataReady(uint32 frame, libcamera.ControlList metadata);\n> };\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index 629e1a32d..cfc1389e4 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -292,7 +292,7 @@ void IPASoftSimple::computeParams(const uint32_t frame)\n> algo->prepare(context_, frame, frameContext, params_);\n> params_->combinedMatrix = context_.activeState.combinedMatrix;\n> \n> - setIspParams.emit();\n> + paramsComputed.emit();\n> }\n> \n> void IPASoftSimple::processStats(const uint32_t frame,\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 224a2fa7c..f5b44f4e5 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -164,7 +164,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> return;\n> }\n> \n> - ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams);\n> + ipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams);\n> ipa_->metadataReady.connect(this,\n> [this](uint32_t frame, const ControlList &metadata) {\n> metadataReady.emit(frame, metadata);\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07FD4C324C\n\tfor ;\n\tThu, 4 Jun 2026 18:20:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2C2E63411;\n\tThu, 4 Jun 2026 20:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 344AE63320\n\tfor ;\n\tThu, 4 Jun 2026 20:20:00 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E27213D7;\n\tThu, 4 Jun 2026 20:19:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J87YdyjS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780597175;\n\tbh=9LguwZTZtbKI7U1vLqrCcwJfyxQfWLIIEnliv62FysQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=J87YdyjSvQjcUUzyLLm+GvgyTfsZwDhQVnrQ1S82DKOjMavhllm3QY0xfy9PkfuGC\n\tf2ZyMKe2XXAjOduPH0EHkaWH2cpG03RgGnG+49NNj2dTmEIQfDl83WybcQON28xKVX\n\tb3xey60LTpXe/1Ezgzh0RobG0FbvuqzodeHDo2gk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260604095105.68798-3-mzamazal@redhat.com>","References":"<20260604095105.68798-1-mzamazal@redhat.com>\n\t<20260604095105.68798-3-mzamazal@redhat.com>","Subject":"Re: [RFC PATCH v3 02/17] libcamera: ipa: simple: Rename setIspParams\n\tto paramsComputed","From":"Kieran Bingham ","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tjohannes.goede@oss.qualcomm.com","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 04 Jun 2026 19:19:56 +0100","Message-ID":"<178059719679.1119811.953424868321717255@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]