Patch Detail
Show a patch.
GET /api/patches/26820/?format=api
{ "id": 26820, "url": "https://patchwork.libcamera.org/api/patches/26820/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26820/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260604090044.3536188-1-tju_cooyun@163.com>", "date": "2026-06-04T09:00:44", "name": "rpi: pipeline_base: print old color space in before updating", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "afe58b13f961bef73d2edf8c2cf7f9f7f17a4bfd", "submitter": { "id": 277, "url": "https://patchwork.libcamera.org/api/people/277/?format=api", "name": "张朝阳", "email": "tju_cooyun@163.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26820/mbox/", "series": [ { "id": 5975, "url": "https://patchwork.libcamera.org/api/series/5975/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5975", "date": "2026-06-04T09:00:44", "name": "rpi: pipeline_base: print old color space in before updating", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5975/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26820/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26820/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E496CC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Jun 2026 09:00:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D67B7631CC;\n\tThu, 4 Jun 2026 11:00:55 +0200 (CEST)", "from m16.mail.163.com (m16.mail.163.com [220.197.31.2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBBBA62DC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jun 2026 11:00:53 +0200 (CEST)", "from SH-DESKTOP.taile2d4ba.ts.net (unknown [])\n\tby gzsmtp5 (Coremail) with SMTP id QCgvCgDnQSG+PiFq61mdAQ--.55308S2; \n\tThu, 04 Jun 2026 17:00:46 +0800 (CST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=\"l0GWGPwi\";\n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=3f\n\tYCx2Hr3Rz09HUoIJR5O3UOmZwEskGW/aH5gP7Bj54=; b=l0GWGPwivlqvrVQeG4\n\tbBvevA16Zz8N2Kc6+0dMLLH++ohK3w9CfkpRLNE67q1eOkpH+qfTcJM4zBVpkDXm\n\t+d+k2H1m5ODGh6+/aOwIRq3kRJn5Yo9bqM+5G1DTZDJdUSutTLoQwNvFS2tPyzcZ\n\tCN5ypNMl1mZZIZGXULfqw8x1k=", "From": "tju_cooyun@163.com", "To": "libcamera-devel@lists.libcamera.org", "Cc": "zcy <tju_cooyun@163.com>", "Subject": "[PATCH] rpi: pipeline_base: print old color space in before updating", "Date": "Thu, 4 Jun 2026 17:00:44 +0800", "Message-ID": "<20260604090044.3536188-1-tju_cooyun@163.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "QCgvCgDnQSG+PiFq61mdAQ--.55308S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7Jry7Jw13KF1ruFyfAw1DJrb_yoW8JF4rpF\n\tyUAFs5t347ZF1rWF98u3ZaqF9rW34kXa1Igr1jkr4jkF45Kr9a9F42kw1fJrWfWFy3ZFsr\n\tWFWrJ3WxZr17GrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRH89ZUUUUU=", "X-Originating-IP": "[183.195.143.58]", "X-CM-SenderInfo": "5wmxsuprr130i6rwjhhfrp/xtbC5h+h+GohPr-MWgAA38", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: zcy <tju_cooyun@163.com>\n\nPipelineHandlerBase::updateStreamConfig now saves the previous\nstream color space before assignment when a color space change\nis detected. This ensures the debug log reports the transition\nas 'from <old> to <new>' instead of showing the new value twice.\n\nSigned-off-by: zcy <tju_cooyun@163.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 263a48387..5a5acf6a1 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n \t}\n \n \tif (stream->colorSpace != format.colorSpace) {\n-\t\tstream->colorSpace = format.colorSpace;\n-\t\tadjusted = true;\n \t\tLOG(RPI, Debug)\n \t\t\t<< \"Color space changed from \"\n \t\t\t<< ColorSpace::toString(stream->colorSpace) << \" to \"\n \t\t\t<< ColorSpace::toString(format.colorSpace);\n+\t\tstream->colorSpace = format.colorSpace;\n+\t\tadjusted = true;\n \t}\n \n \tstream->stride = format.planes[0].bpl;\n", "prefixes": [] }