[{"id":38993,"web_url":"https://patchwork.libcamera.org/comment/38993/","msgid":"<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","date":"2026-06-04T10:25:23","subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 04. 11:00 keltezéssel, tju_cooyun@163.com írta:\n> From: zcy \n> \n> PipelineHandlerBase::updateStreamConfig now saves the previous\n> stream color space before assignment when a color space change\n> is detected. This ensures the debug log reports the transition\n> as 'from to ' instead of showing the new value twice.\n> \n> Signed-off-by: zcy \n> ---\n\nLooks ok to me. I think this can have\n\n Fixes: 71bbf10a2f79 (\"libcamera: rpi: Add some helpers to PipelineHandlerBase\")\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index 263a48387..5a5acf6a1 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n> \t}\n> \n> \tif (stream->colorSpace != format.colorSpace) {\n> -\t\tstream->colorSpace = format.colorSpace;\n> -\t\tadjusted = true;\n> \t\tLOG(RPI, Debug)\n> \t\t\t<< \"Color space changed from \"\n> \t\t\t<< ColorSpace::toString(stream->colorSpace) << \" to \"\n> \t\t\t<< ColorSpace::toString(format.colorSpace);\n> +\t\tstream->colorSpace = format.colorSpace;\n> +\t\tadjusted = true;\n> \t}\n> \n> \tstream->stride = format.planes[0].bpl;\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89BBFC328C\n\tfor ;\n\tThu, 4 Jun 2026 10:25:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A841F632EE;\n\tThu, 4 Jun 2026 12:25:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E598B6303B\n\tfor ;\n\tThu, 4 Jun 2026 12:25:27 +0200 (CEST)","from [192.168.0.185] (catv-80-99-226-21.catv.fixed.one.hu\n\t[80.99.226.21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A00913D7;\n\tThu, 4 Jun 2026 12:25:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"elmq0cs7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780568703;\n\tbh=ekNNchQ3dwtoWE+oEaPKvmLKy2OtyRGrSUQBy32r6ys=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=elmq0cs7+3GKNQOXrUPdAyVbg3o8v+v6gUAMmBZFFOqnaJeXqNnj/IcYnZbWJZ6qR\n\tdyu7dnPdLjUwYAZdcZO9Al953Bmar0D8v0XaFcB+9b/c4BsFDV4QDADG1JqubkdQlP\n\tKkB2Vw+ekGt2nW2RgqxGihii9s05S6iQkIjxl8FU=","Message-ID":"<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","Date":"Thu, 4 Jun 2026 12:25:23 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","To":"tju_cooyun@163.com, libcamera-devel@lists.libcamera.org","References":"\n\t<20260604090044.3536188-1-tju_cooyun@163.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260604090044.3536188-1-tju_cooyun@163.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38994,"web_url":"https://patchwork.libcamera.org/comment/38994/","msgid":"","date":"2026-06-04T10:27:57","subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi\n\nThanks for the patch. Yes, I think that's clearly what was intended!\n\nOn Thu, 4 Jun 2026 at 11:25, Barnabás Pőcze\n wrote:\n>\n> 2026. 06. 04. 11:00 keltezéssel, tju_cooyun@163.com írta:\n> > From: zcy \n> >\n> > PipelineHandlerBase::updateStreamConfig now saves the previous\n> > stream color space before assignment when a color space change\n> > is detected. This ensures the debug log reports the transition\n> > as 'from to ' instead of showing the new value twice.\n> >\n> > Signed-off-by: zcy \n> > ---\n>\n> Looks ok to me. I think this can have\n>\n> Fixes: 71bbf10a2f79 (\"libcamera: rpi: Add some helpers to PipelineHandlerBase\")\n>\n> Reviewed-by: Barnabás Pőcze \n\nReviewed-by: David Plowman \n\nBest regards\n\nDavid\n\n>\n>\n> > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > index 263a48387..5a5acf6a1 100644\n> > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > @@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n> > }\n> >\n> > if (stream->colorSpace != format.colorSpace) {\n> > - stream->colorSpace = format.colorSpace;\n> > - adjusted = true;\n> > LOG(RPI, Debug)\n> > << \"Color space changed from \"\n> > << ColorSpace::toString(stream->colorSpace) << \" to \"\n> > << ColorSpace::toString(format.colorSpace);\n> > + stream->colorSpace = format.colorSpace;\n> > + adjusted = true;\n> > }\n> >\n> > stream->stride = format.planes[0].bpl;\n> > --\n> > 2.43.0\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7ED7FC328C\n\tfor ;\n\tThu, 4 Jun 2026 10:28:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EBDF632EE;\n\tThu, 4 Jun 2026 12:28:12 +0200 (CEST)","from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n\t[IPv6:2a00:1450:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9BCA6303B\n\tfor ;\n\tThu, 4 Jun 2026 12:28:10 +0200 (CEST)","by mail-ed1-x52b.google.com with SMTP id\n\t4fb4d7f45d1cf-68d233bf083so701276a12.1\n\tfor ;\n\tThu, 04 Jun 2026 03:28:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mhYdc038\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1780568890; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=FaYU33uK4FNSgH+c0u5kDL2+o0JMsXyjEnsLFtZckyiIV0lfCZNEkWOB4Xt2ZTQDX1\n\tMvSaAq1NFhbuvJFxzp0JLOUHfPMXyxVwkTQ2F18I6i2M8M77g4VVWpVc+5Jkjvzv/Wqp\n\t8kaiMjK5dU1/rm/GrJHgYSkDgchDLBtGtKdXGVrkVbxrhZiOsN1WROF27YfyFsNwc33U\n\tdq6uZy1FrYFC19pTyJqK8Jse+DqB1neMewh0ATNXjo8BdmsS2/DHpsMYNJIQebf4ZmW4\n\tqAowe61Vd7XitpIl4yO+P9Esh65I/+GOmyqHOVnsu0uWChoMTdLvVt/ND9VTvDy5gwAD\n\tXx4A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:dkim-signature;\n\tbh=gtVK/IXx0BEZKxpmQEhbRb16vzWf6Ry4lOHQl+vfSYo=;\n\tfh=fqFj0QEuMV13kN3hBZWKo08r6MG0kChESxXxM7pAo7M=;\n\tb=WHDR3W5TpSkqY8gi+Vx3+C/ZEhi7CSd7vU5zvp5rZJ9kGO1v3Hfxd7vZ048611zsmk\n\tQ4slNVx9FjYuQv6fnB3u+uKhBCa9G4KmKUCf7cizgpJEGDFgq92q3cfAH5xs3RawTTwJ\n\tj2zqVNTziw4t1XHnKhJaVc6wdr27h/BEiuwj6Tv3r06ztPTy4e/T7YyFd99TkghxMonI\n\ta7EI1r2uoDLugP9DXP0tJLrXK4d0kcuGEe4QJwYWVTsCQAcyH0gKEqtMY3/u/93jCHcp\n\t7UkMocJKPgmdW0IIKY+KFETPIo+wXVOODM7hnjd8wXoKEtlnPittLiNx40PwktYjQ5n3\n\tsOdA==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1780568890; x=1781173690;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=gtVK/IXx0BEZKxpmQEhbRb16vzWf6Ry4lOHQl+vfSYo=;\n\tb=mhYdc038NQRYidLfrverb9fBf8C/qkhuQmJAJkJgGgd5slSbTtjZshJfWEWwzHCyXY\n\tXaX3jE/1llnMKetAWixM1clRVIf9x0MpW1qTE+Gik0Dy+fhd/hAL65EOMFygfV3VI0gr\n\tXyeFN35zD0M7lSHNAC7fb6zi5Byty/nc2fmCPPUtwgYvH9po6Vq8ZVIxsTdwgwSRJBvK\n\t6zky/PoPJhq3JclcdwPfWNHD4v30GSAHywUr5ZWq02OsmIHdwrszBXaFOcwUOLuNDlH8\n\tei1B2KJediLOzAEgXmi91Sxh5YLU5AIlcGpSLMDz6VxJSeiSKNvVBvYE3xXhd+8lHWZd\n\tQEdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1780568890; x=1781173690;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=gtVK/IXx0BEZKxpmQEhbRb16vzWf6Ry4lOHQl+vfSYo=;\n\tb=Y/J2WBERodhQRhUzD4wU2vNLdKGqev64qD8PpIze8+obagTcA+CnJXUYlFcQOdQ0L8\n\t4hMx0+c+f8jR//yNLJLGJMbwvWv1w+m4+bvh23KWLZmnzf/iK9ZHTXNcz3AeBvGwdELf\n\t3cINhjXhnjiy3FgzzUjHoggzH4XIbAxUhTV8ebxWHXep6Jf5akkfyamtwgPKjNxl4k97\n\tMZf+aHNVPdVEQFcykDwM5zg1/BD//5gVArbByl7wIX14Xb+DEp/9Wz6ni00KA1+rK0jv\n\tsuIJUzLX8ONOhp3A9ag3Yv2oIoSEkxDlSkkCGdvKdz6HXaRndSBseWZyiir3c3xqjzKU\n\tVqxQ==","X-Forwarded-Encrypted":"i=1;\n\tAFNElJ8A7CqCEXS2HE98J39ZpSfdk2KjLHfB1uE7pp4WfEEmVAAXQgfT86ECULSdHS0U9G9LUmgzuDEZnqcPXUHJA4M=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwBvnIU3nnAWm9uawudPIdOof1oCj3ziCPujAKEapFWPCiKHkfb\n\tN5eQUnqc3Bb1ysavoTT8n5Gd1Uev6EUxYQZdg0UjjBXH1HBz8ndu/EmXdFxVG2kalXpoYklDlFO\n\tyIEGmkOXpUtoLDym/QDmdKkWI5vaCiprljMI0y8PMDgQD9Cr2NESQUik=","X-Gm-Gg":"Acq92OHBZVCbFieBQujkDqimbOyemsAPpgQIPMHzwJr3AjGp7Ypyg8BJb/LDlEvtwU5\n\tz+nlV6bvTD+A04zYZekNRczUKNw8Kg6eBx7NQEaEWUw3BxG4XlPN4NcuycTrtWGI7wrK3lh3GgX\n\tlToHnwZnX0+sgKoL1aR6NMax3CALq8sUgRvgNMuboWbuAottTKiml22cHyu4KYQNhwV3z+G2xoz\n\tTfc944uUm1c7L5ez3UJAhl90oAXqQK2lexa6HEN8OzcTcOk9VlCRGGXUi9HiHRZnbP8Umo6L7E+\n\tJHp+NXSnCZjU5vMV7pYw2UY4az3fn5gcQXBkRMM40+mzRNRyBGXkvN4NIWOUdBifFpCHMe/6DQz\n\tbmWT/Wpaxnbm37xyBUGAa3HEZCA6PUZ8oXFI=","X-Received":"by 2002:a17:907:1784:b0:bee:66ba:36b9 with SMTP id\n\ta640c23a62f3a-bf0af5083damr393340866b.44.1780568890029;\n\tThu, 04 Jun 2026 03:28:10 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<20260604090044.3536188-1-tju_cooyun@163.com>\n\t<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","In-Reply-To":"<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","From":"David Plowman ","Date":"Thu, 4 Jun 2026 11:27:57 +0100","X-Gm-Features":"AVHnY4KFL18N5wcrEVK-NbRArx-doHBRXovJbQ1FSy0gkA0VQHYo3EnusXfYgTU","Message-ID":"","Subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"tju_cooyun@163.com, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38995,"web_url":"https://patchwork.libcamera.org/comment/38995/","msgid":"<795ce7df-85b2-4fa1-88a4-58d2d48272d8@ideasonboard.com>","date":"2026-06-04T10:28:14","subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 04. 12:25 keltezéssel, Barnabás Pőcze írta:\n> 2026. 06. 04. 11:00 keltezéssel, tju_cooyun@163.com írta:\n>> From: zcy \n>>\n>> PipelineHandlerBase::updateStreamConfig now saves the previous\n>> stream color space before assignment when a color space change\n>> is detected. This ensures the debug log reports the transition\n>> as 'from to ' instead of showing the new value twice.\n>>\n>> Signed-off-by: zcy \n>> ---\n> \n> Looks ok to me. I think this can have\n> \n> Fixes: 71bbf10a2f79 (\"libcamera: rpi: Add some helpers to PipelineHandlerBase\")\n\nAdditionally, the subject prefix should probably be\n\n pipeline: rpi:\n\ninstead of\n\n rpi: pipeline_base:\n\nwith the first letter of the succeeding text capitalized, e.g:\n\n pipeline: rpi: Print old color space before updating\n\n> \n> Reviewed-by: Barnabás Pőcze \n> \n> \n>> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> index 263a48387..5a5acf6a1 100644\n>> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> @@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n>> \t}\n>>\n>> \tif (stream->colorSpace != format.colorSpace) {\n>> -\t\tstream->colorSpace = format.colorSpace;\n>> -\t\tadjusted = true;\n>> \t\tLOG(RPI, Debug)\n>> \t\t\t<< \"Color space changed from \"\n>> \t\t\t<< ColorSpace::toString(stream->colorSpace) << \" to \"\n>> \t\t\t<< ColorSpace::toString(format.colorSpace);\n>> +\t\tstream->colorSpace = format.colorSpace;\n>> +\t\tadjusted = true;\n>> \t}\n>>\n>> \tstream->stride = format.planes[0].bpl;\n>> --\n>> 2.43.0\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A38DFC328C\n\tfor ;\n\tThu, 4 Jun 2026 10:28:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D08463401;\n\tThu, 4 Jun 2026 12:28:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F1A0632B0\n\tfor ;\n\tThu, 4 Jun 2026 12:28:18 +0200 (CEST)","from [192.168.0.185] (catv-80-99-226-21.catv.fixed.one.hu\n\t[80.99.226.21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62CAFBE1;\n\tThu, 4 Jun 2026 12:27:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BKet2HDS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780568873;\n\tbh=m5jWdwIgc2hYaeLCI15w78rE5+rrZjf9TPNoRHBy6KI=;\n\th=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;\n\tb=BKet2HDS002TXHmrBjrJ7l7Wd7UdhCFsxTxJBpUt77aKZ7C2PyPh7V0PN/1KfcjJ7\n\trJDOyuuZbHK1bdt8B2uAD6nJ49zcqq6dpYxtL21cqVlTTmWbY60WNgzNbIDX75qUCM\n\tfbN8A6btfXOZz4V5mHxH/4PW2QDP6k0YUmQ3V1X8=","Message-ID":"<795ce7df-85b2-4fa1-88a4-58d2d48272d8@ideasonboard.com>","Date":"Thu, 4 Jun 2026 12:28:14 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"tju_cooyun@163.com, libcamera-devel@lists.libcamera.org","References":"\n\t<20260604090044.3536188-1-tju_cooyun@163.com>\n\t\n\t<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38996,"web_url":"https://patchwork.libcamera.org/comment/38996/","msgid":"<178056917571.815980.15948119793311472722@ping.linuxembedded.co.uk>","date":"2026-06-04T10:32:55","subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-06-04 11:28:14)\n> 2026. 06. 04. 12:25 keltezéssel, Barnabás Pőcze írta:\n> > 2026. 06. 04. 11:00 keltezéssel, tju_cooyun@163.com írta:\n> >> From: zcy \n> >>\n> >> PipelineHandlerBase::updateStreamConfig now saves the previous\n> >> stream color space before assignment when a color space change\n> >> is detected. This ensures the debug log reports the transition\n> >> as 'from to ' instead of showing the new value twice.\n> >>\n> >> Signed-off-by: zcy \n> >> ---\n> > \n> > Looks ok to me. I think this can have\n> > \n> > Fixes: 71bbf10a2f79 (\"libcamera: rpi: Add some helpers to PipelineHandlerBase\")\n> \n> Additionally, the subject prefix should probably be\n> \n> pipeline: rpi:\n> \n> instead of\n> \n> rpi: pipeline_base:\n> \n> with the first letter of the succeeding text capitalized, e.g:\n> \n> pipeline: rpi: Print old color space before updating\n\nI'll handle all that while applying.\n\n--\nThanks\n\nKieran\n\n\n> \n> > \n> > Reviewed-by: Barnabás Pőcze \n> > \n> > \n> >> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n> >> 1 file changed, 2 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> >> index 263a48387..5a5acf6a1 100644\n> >> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> >> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> >> @@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n> >> }\n> >>\n> >> if (stream->colorSpace != format.colorSpace) {\n> >> - stream->colorSpace = format.colorSpace;\n> >> - adjusted = true;\n> >> LOG(RPI, Debug)\n> >> << \"Color space changed from \"\n> >> << ColorSpace::toString(stream->colorSpace) << \" to \"\n> >> << ColorSpace::toString(format.colorSpace);\n> >> + stream->colorSpace = format.colorSpace;\n> >> + adjusted = true;\n> >> }\n> >>\n> >> stream->stride = format.planes[0].bpl;\n> >> --\n> >> 2.43.0\n> >>\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DEF6C324C\n\tfor ;\n\tThu, 4 Jun 2026 10:33:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3ED0663401;\n\tThu, 4 Jun 2026 12:33:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBE696303B\n\tfor ;\n\tThu, 4 Jun 2026 12:32:58 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24822BE1;\n\tThu, 4 Jun 2026 12:32:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HmyP2kTK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1780569154;\n\tbh=gOd+YgluWFquhKxS7URR2Mex+UM2dm2jZEcIG7PCAYA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HmyP2kTKDVxKw/5gVfUN78Hf6wIHSAlPTPF7wwlOiPpJ7Caazwj7lLhQf1iNsO92O\n\t5AM7jOEWJUJrc6dEbm2cAyQglfFJkE1ASGFRyIrFFysQzRNM1x6pGVTz1zx2jZ4+WQ\n\tKJFgifJ/XshULodd3Yds2KjFM4K7UkPLD9ckrW6o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<795ce7df-85b2-4fa1-88a4-58d2d48272d8@ideasonboard.com>","References":"\n\t<20260604090044.3536188-1-tju_cooyun@163.com>\n\t\n\t<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>\n\t<795ce7df-85b2-4fa1-88a4-58d2d48272d8@ideasonboard.com>","Subject":"Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org, tju_cooyun@163.com","Date":"Thu, 04 Jun 2026 11:32:55 +0100","Message-ID":"<178056917571.815980.15948119793311472722@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39009,"web_url":"https://patchwork.libcamera.org/comment/39009/","msgid":"<37453c77.7486.19ea655fec0.Coremail.tju_cooyun@163.com>","date":"2026-06-08T08:25:14","subject":"Re:Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","submitter":{"id":277,"url":"https://patchwork.libcamera.org/api/people/277/","name":"张朝阳","email":"tju_cooyun@163.com"},"content":"Hi,\nThanks for reviewing and handling the changes!\nI'm really happy to submit my first patch to the libcamera community. Looking forward to contributing more in the future.\n\nAt 2026-06-04 18:32:55, \"Kieran Bingham\" wrote:\n>Quoting Barnabás Pőcze (2026-06-04 11:28:14)\n>> 2026. 06. 04. 12:25 keltezéssel, Barnabás Pőcze írta:\n>> > 2026. 06. 04. 11:00 keltezéssel, tju_cooyun@163.com írta:\n>> >> From: zcy \n>> >>\n>> >> PipelineHandlerBase::updateStreamConfig now saves the previous\n>> >> stream color space before assignment when a color space change\n>> >> is detected. This ensures the debug log reports the transition\n>> >> as 'from to ' instead of showing the new value twice.\n>> >>\n>> >> Signed-off-by: zcy \n>> >> ---\n>> > \n>> > Looks ok to me. I think this can have\n>> > \n>> > Fixes: 71bbf10a2f79 (\"libcamera: rpi: Add some helpers to PipelineHandlerBase\")\n>> \n>> Additionally, the subject prefix should probably be\n>> \n>> pipeline: rpi:\n>> \n>> instead of\n>> \n>> rpi: pipeline_base:\n>> \n>> with the first letter of the succeeding text capitalized, e.g:\n>> \n>> pipeline: rpi: Print old color space before updating\n>\n>I'll handle all that while applying.\n>\n>--\n>Thanks\n>\n>Kieran\n>\n>\n>> \n>> > \n>> > Reviewed-by: Barnabás Pőcze \n>> > \n>> > \n>> >> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n>> >> 1 file changed, 2 insertions(+), 2 deletions(-)\n>> >>\n>> >> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> >> index 263a48387..5a5acf6a1 100644\n>> >> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> >> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n>> >> @@ -342,12 +342,12 @@ bool PipelineHandlerBase::updateStreamConfig(StreamConfiguration *stream,\n>> >> }\n>> >>\n>> >> if (stream->colorSpace != format.colorSpace) {\n>> >> - stream->colorSpace = format.colorSpace;\n>> >> - adjusted = true;\n>> >> LOG(RPI, Debug)\n>> >> << \"Color space changed from \"\n>> >> << ColorSpace::toString(stream->colorSpace) << \" to \"\n>> >> << ColorSpace::toString(format.colorSpace);\n>> >> + stream->colorSpace = format.colorSpace;\n>> >> + adjusted = true;\n>> >> }\n>> >>\n>> >> stream->stride = format.planes[0].bpl;\n>> >> --\n>> >> 2.43.0\n>> >>\n>> > \n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92A05C324C\n\tfor ;\n\tMon, 8 Jun 2026 08:25:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DBFD61ECF;\n\tMon, 8 Jun 2026 10:25:32 +0200 (CEST)","from m16.mail.163.com (m16.mail.163.com [220.197.31.2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04A7561754\n\tfor ;\n\tMon, 8 Jun 2026 10:25:27 +0200 (CEST)","from tju_cooyun$163.com ( [183.195.143.58] ) by\n\tajax-webmail-wmsvr-40-100 (Coremail) ;\n\tMon, 8 Jun 2026 16:25:14 +0800 (CST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=163.com header.i=@163.com header.b=\"hiKIRzcL\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Date:From:To:Subject:Content-Type:MIME-Version:\n\tMessage-ID; bh=MKDmEQTmy8YORkj46IDfSFY08DXRJYj6idTYHSCWLK0=; b=h\n\tiKIRzcLns1hkTiCaxlMJJs5iwq/wK8kVCYZyxefs4xZl+LCusndQT4FurIfhv+3s\n\tMj9zv4OUQXVag5NaTdTHLb26mpXiQu4m5mhddLVyPgxQAd2HdUO+cZK8qyWbC17W\n\tEAJXuPkIEjSWhsvVqoGaBoZWirGkzqnPkkAvaAOtAo=","X-Originating-IP":"[183.195.143.58]","Date":"Mon, 8 Jun 2026 16:25:14 +0800 (CST)","From":"=?utf-8?b?5byg5pyd6ZizIA==?= ","To":"\"Kieran Bingham\" ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re:Re: [PATCH] rpi: pipeline_base: print old color space in before\n\tupdating","X-Priority":"3","X-Mailer":"Coremail Webmail Server Version 2023.4-cmXT build\n\t20260403(27802f6d) Copyright (c) 2002-2026 www.mailtech.cn 163com","In-Reply-To":"<178056917571.815980.15948119793311472722@ping.linuxembedded.co.uk>","References":"\n\t<20260604090044.3536188-1-tju_cooyun@163.com>\n\t\n\t<744d34e2-2815-4199-a228-1e4553d2fc4d@ideasonboard.com>\n\t<795ce7df-85b2-4fa1-88a4-58d2d48272d8@ideasonboard.com>\n\t<178056917571.815980.15948119793311472722@ping.linuxembedded.co.uk>","X-NTES-SC":"AL_Qu2TAvWbuEkq4iGebekcnUkVj+8/W8C3vf0u1YNec+sEuCvSwRwKQXx4J0P2yMmjEyGVvj6Hax5T0fxaYqpSaNsGfy0CEHgB77/zmqNCRQ==","Content-Type":"multipart/alternative; \n\tboundary=\"----=_Part_112379_1205403749.1780907114175\"","MIME-Version":"1.0","Message-ID":"<37453c77.7486.19ea655fec0.Coremail.tju_cooyun@163.com>","X-Coremail-Locale":"zh_CN","X-CM-TRANSID":"ZCgvCgD3vxJqfCZq+7wEAA--.9788W","X-CM-SenderInfo":"5wmxsuprr130i6rwjhhfrp/xtbDAgpdtGomfGraMQAA3Q","X-Coremail-Antispam":"1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU==","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]