Patch Detail
Show a patch.
GET /api/patches/26810/?format=api
{ "id": 26810, "url": "https://patchwork.libcamera.org/api/patches/26810/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26810/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260527150715.67574-1-robert.mader@collabora.com>", "date": "2026-05-27T15:07:15", "name": "[v1] software_isp: Request input buffer alignment of 256 bytes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a6f2c7ded21e2a937fb1dd79a1ebd76b9126ce8", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26810/mbox/", "series": [ { "id": 5967, "url": "https://patchwork.libcamera.org/api/series/5967/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5967", "date": "2026-05-27T15:07:15", "name": "[v1] software_isp: Request input buffer alignment of 256 bytes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5967/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26810/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26810/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0755C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 May 2026 15:07:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7974C63021;\n\tWed, 27 May 2026 17:07:42 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DAC462FE1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 May 2026 17:07:40 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1779894454875745.5897331191827;\n\tWed, 27 May 2026 08:07:34 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"SppV8brU\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1779894457; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Ru8q3BhLC1xsNIpeghowKx0Ah3U66BitvbRDKkdxrkq61fYc2EJ5BY62gkibxZUZKZfpqQ7g6PX9yUO+P4KEdAvlDM0s+g+jWxiS75FRzm3uR5eow2R1w8FLErMGE8AbGRbZ+LrJLAiKu4X8fw32pJg1HncjHlfZbV79doVQsQ8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779894457;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=Ko/DzzOJgkNfW7oV3sqSG/SGo1Mg04nDIP5hQ1Jm/n4=; \n\tb=SaBAYKccY9I+4swiXX/5fScWtdGj4fM0NLqgQ3AA2HLhOws5BHHcfBHnUDjWyT3F8egVfNnwr0lZPMBq5xiyDCVF0Ms6v313RMswUzloNFNuaOYU7TAV8w604D1kxzepZqTKWHlWtkDRr/5r6UuQtyT8ZH8J2CleYKfhYtTaBfU=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779894457;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=Ko/DzzOJgkNfW7oV3sqSG/SGo1Mg04nDIP5hQ1Jm/n4=;\n\tb=SppV8brUPT1BKQsge/o8il0LG4UOKAvdLMFZ+c85XbODBeqirNwF6wjfUNJaS2j3\n\tatCfvth8pumw1VODh0cc3Ac3Fa60WqJnuRd4ziLHiXkmPgCEvGaaftaOq1eBu0zjpu+\n\tW5YL6ohYltdRmIrpUL/T2XdGdzYQWiKxP7yPrQrI=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v1] software_isp: Request input buffer alignment of 256 bytes", "Date": "Wed, 27 May 2026 17:07:15 +0200", "Message-ID": "<20260527150715.67574-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.54.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When using the GPU-ISP. This should increase the chances that input\nbuffers can be imported and directly be used by the GPU as stride\nrequirements are the most common reason for import fails.\n\nNotes:\n - 256 is already used for output buffers and known to work across\n most hardware. Unfortunately there is no API to query the optimal\n value from the GL driver.\n - The V4L2 API does not require drivers to honor stride request, thus\n we log those cases.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n\n---\n\nFollow-up to https://patchwork.libcamera.org/project/libcamera/list/?series=5965\n---\n .../libcamera/internal/software_isp/software_isp.h | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 12 ++++++++++++\n src/libcamera/software_isp/debayer.cpp | 8 ++++++++\n src/libcamera/software_isp/debayer.h | 1 +\n src/libcamera/software_isp/debayer_egl.cpp | 7 +++++++\n src/libcamera/software_isp/debayer_egl.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 13 +++++++++++++\n 7 files changed, 43 insertions(+)", "diff": "diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 86cb8f8de..7440937c2 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -61,6 +61,7 @@ public:\n \n \tstd::tuple<unsigned int, unsigned int>\n \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n+\tuint32_t getPreferredInputStride(const PixelFormat &inputFormat, const Size &size);\n \n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c6fe12d65..0de2fe695 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1542,6 +1542,11 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tcaptureFormat.fourcc = videoFormat;\n \tcaptureFormat.size = pipeConfig->captureSize;\n \n+\tuint32_t requested_bpl = 0;\n+\tif (data->swIsp_)\n+\t\trequested_bpl = data->swIsp_->getPreferredInputStride(videoFormat.toPixelFormat(), pipeConfig->captureSize);\n+\tcaptureFormat.planes[0].bpl = requested_bpl;\n+\n \tret = video->setFormat(&captureFormat);\n \tif (ret)\n \t\treturn ret;\n@@ -1561,6 +1566,13 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn -EINVAL;\n \t}\n \n+\tif (requested_bpl && captureFormat.planes[0].bpl != requested_bpl) {\n+\t\tLOG(SimplePipeline, Info)\n+\t\t\t<< \"Input buffer stride ignored by the driver. \"\n+\t\t\t<< \"Requested \" << requested_bpl\n+\t\t\t<< \", got \" << captureFormat.planes[0].bpl;\n+\t}\n+\n \t/* Configure the converter if needed. */\n \tstd::vector<std::reference_wrapper<const StreamConfiguration>> outputCfgs;\n \tdata->useConversion_ = config->needConversion();\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 2d7abfb83..858c9b97c 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -103,6 +103,14 @@ Debayer::~Debayer()\n * there is no valid output config\n */\n \n+/**\n+ * \\fn uint32_t Debayer::getPreferredInputStride(const PixelFormat &inputFormat, const Size &size)\n+ * Get the preferred input stride in bytes for the given input format and size\n+ * \\param[in] inputFormat The input format\n+ * \\param[in] size The input size (width and height in pixels)\n+ * \\return The preferred input stride in bytes\n+ */\n+\n /**\n * \\fn void Debayer::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n * \\brief Process the bayer data into the requested format\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex a2a17ec18..136374b8d 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -46,6 +46,7 @@ public:\n \n \tvirtual std::tuple<unsigned int, unsigned int>\n \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n+\tvirtual uint32_t getPreferredInputStride(const PixelFormat &inputFormat, const Size &size) { return 0; }\n \n \tvirtual void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) = 0;\n \tvirtual int start() { return 0; }\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 7b9e02d90..b7ddec17e 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -20,6 +20,7 @@\n \n #include <libcamera/formats.h>\n \n+#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/framebuffer.h\"\n \n #include \"../glsl_shaders.h\"\n@@ -377,6 +378,12 @@ DebayerEGL::strideAndFrameSize(const PixelFormat &outputFormat, const Size &size\n \treturn std::make_tuple(stride, stride * size.height);\n }\n \n+uint32_t DebayerEGL::getPreferredInputStride(const PixelFormat &inputFormat, const Size &size)\n+{\n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(inputFormat);\n+\treturn info.stride(size.width, 0, 256);\n+}\n+\n void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n {\n \t/*\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 141fb288f..1b0153853 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -50,6 +50,7 @@ public:\n \n \tstd::vector<PixelFormat> formats(PixelFormat input) override;\n \tstd::tuple<unsigned int, unsigned int> strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;\n+\tuint32_t getPreferredInputStride(const PixelFormat &inputFormat, const Size &size) override;\n \n \tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override;\n \tint start() override;\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 781cf02f8..f6c8f498e 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -255,6 +255,19 @@ SoftwareIsp::strideAndFrameSize(const PixelFormat &outputFormat, const Size &siz\n \treturn debayer_->strideAndFrameSize(outputFormat, size);\n }\n \n+/**\n+ * Get the preferred input stride in bytes for the given input format and size\n+ * \\param[in] inputFormat The input format\n+ * \\param[in] size The input size (width and height in pixels)\n+ * \\return The preferred input stride in bytes\n+ */\n+uint32_t SoftwareIsp::getPreferredInputStride(const PixelFormat &inputFormat, const Size &size)\n+{\n+\tASSERT(debayer_);\n+\n+\treturn debayer_->getPreferredInputStride(inputFormat, size);\n+}\n+\n /**\n * \\brief Configure the SoftwareIsp object according to the passed in parameters\n * \\param[in] inputCfg The input configuration\n", "prefixes": [ "v1" ] }