[{"id":38964,"web_url":"https://patchwork.libcamera.org/comment/38964/","msgid":"","date":"2026-05-27T20:55:12","subject":"Re: [PATCH v1] software_isp: Request input buffer alignment of 256\n\tbytes","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 27.05.26 17:07, Robert Mader wrote:\n> ...\n> \n> +uint32_t DebayerEGL::getPreferredInputStride(const PixelFormat &inputFormat, const Size &size)\n> +{\n> +\tconst PixelFormatInfo &info = PixelFormatInfo::info(inputFormat);\n> +\treturn info.stride(size.width, 0, 256);\n> +}\n> +\n\nSorry for talking to myself, however I guess it would be a good call to \nturn the 256 into a `static constexpr` variable and use that here and \nfor the other already present occurrence in strideAndFrameSize(). And \nwhile on it strideAndFrameSize() could be updated to use \n`info.stride(size.width, 0, 256)` instead of \n`libcamera::utils::alignUp(size.width * config.bpp / 8, 256)` as well. \nWill do that in v2.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F274C328C\n\tfor ;\n\tWed, 27 May 2026 20:55:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 766A263024;\n\tWed, 27 May 2026 22:55:23 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6346662E6A\n\tfor ;\n\tWed, 27 May 2026 22:55:21 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1779915314947753.7309115387111;\n\tWed, 27 May 2026 13:55:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"UfJ9mZsF\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1779915318; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=PaueVJePuqpkaE1wwo5wzA4/wudlUSlCubaPRg+GEX1oEfzXDzbR+/NfORxBV/rzPSVc9pJIshZGUH+wEAWpCUWkA3eQS98CoWl3h1xN7jEIm4ilHrN5ODBNXoc3CQnJbjktECOXri1B2jaCuk2+6qVX3vUa4Iv4o5syvTfHwmI=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779915318;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=tTmdyxW0HDVbyTQD0tcpYeJNAVMEZFc7nCeSIbkY5zM=; \n\tb=SHdpJ5slSlYobblnk7Vfwn4KssKSYLcW7nqlVCT5+604tfIbTWCOAh8dODvpr0goIhc+Sn7lK2crQuTCTBX1+WHf4BdmMDRvooWZ3slFZsgp3hpDZ6ysBxns7weqnNuSQXYLhrl/Ydx/CLneqQ58TRtLqDb+KrSKVYLyoFdOnXw=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779915318;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=tTmdyxW0HDVbyTQD0tcpYeJNAVMEZFc7nCeSIbkY5zM=;\n\tb=UfJ9mZsFNa3l2fjVBNkOer6BLq5NesrPRFGSOkkNIgBVPGyCva0Btf2yCUwNg8Qf\n\t97wvNqhfe6QYlZBmM+Yyb2EGG/8UPQnSPWHfJ6VojFF+PTrE6ft+Zm9B4sK7/ETRVLX\n\tAVLaw9/gdVi0x4dLozX1AJQ0qH2Q03X9svL2kJz8=","Message-ID":"","Date":"Wed, 27 May 2026 22:55:12 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] software_isp: Request input buffer alignment of 256\n\tbytes","To":"libcamera-devel@lists.libcamera.org","References":"<20260527150715.67574-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"<20260527150715.67574-1-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]