Patch Detail
Show a patch.
GET /api/patches/26794/?format=api
{ "id": 26794, "url": "https://patchwork.libcamera.org/api/patches/26794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260521155906.120373-4-robert.mader@collabora.com>", "date": "2026-05-21T15:59:04", "name": "[v4,3/5] egl: eGLImage: Add flag to remember dmabuf import fails", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9b524f86ada801c647c40bd40cfbe91b6059fcfb", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26794/mbox/", "series": [ { "id": 5960, "url": "https://patchwork.libcamera.org/api/series/5960/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5960", "date": "2026-05-21T15:59:02", "name": "software_isp: Implement DMABuf import for input buffers", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5960/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3AD2C32F4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 May 2026 15:59:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C174E63034;\n\tThu, 21 May 2026 17:59:33 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8CE56302B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 May 2026 17:59:28 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1779379164141161.036932664887;\n\tThu, 21 May 2026 08:59:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Nalu40GD\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1779379166; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=I5WGmPmgtefVh3aaXc3kZubfxQ99REuzQG6TDWl2s22hqLuphR16JP/Fi7NHjvcjSomDtoBKhuLa6PaZN/IyaVgYA1QOxPCsSn/A0bRVDTuEVVMe/bKmTTJRWSefvxEiBujui4+qvP4Br5IKm1cTt04JPsFGpc1iQfj+DIsGryw=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779379166;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=TSUlafOf8ofK9Cb40XzZGWps5gzsOIEZPVA0qsbnC88=; \n\tb=MJrmJsy9niVaB3GXQZmyLad4JiXeDHugmQWSIjB9GWf1nHT2ZUJvs2KPDcOic4odwMiLojySUSV84OLgs6ePSfP+bg74XbWMvv4/pf0VvmRxI3e68XeDZevP9HFWLPYP0qaL4LeWRY+VZcaTGh9SZjHpvxUsaHr9cu6+x+xP6Rc=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779379166;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=TSUlafOf8ofK9Cb40XzZGWps5gzsOIEZPVA0qsbnC88=;\n\tb=Nalu40GDzfK1LdW1/mB2Bwfht+SJPEeee/DJmkw6EF4d0s7YJQJw9BKNFH6jNfPn\n\tpRYLyiURTU8Rsy6uR1z12b5E1eye4mRUDoUZa10zAoGzVQZ76cN3HNUhNTvSlwcP1oD\n\tTU9iedq8Q2qlCGAsFyc+5JB8YSMJf5od5IyL0vYQ=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v4 3/5] egl: eGLImage: Add flag to remember dmabuf import\n\tfails", "Date": "Thu, 21 May 2026 17:59:04 +0200", "Message-ID": "<20260521155906.120373-4-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260521155906.120373-1-robert.mader@collabora.com>", "References": "<20260521155906.120373-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation of a following commit where we will start trying dmabuf\nimport for input buffers.\nAlso turn down error log in order to avoid flodding logs going\nforward.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n include/libcamera/internal/egl.h | 1 +\n src/libcamera/egl.cpp | 3 ++-\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex bcf09b475..57f90d93f 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -90,6 +90,7 @@ public:\n \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n \tGLuint texture_; /**< OpenGL texture object ID */\n \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n+\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 267d22c8b..c185bb7ad 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -165,7 +165,8 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \t\t\t\t\t NULL, image_attrs);\n \n \tif (image == EGL_NO_IMAGE_KHR) {\n-\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n+\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n+\t\teglImage.dmabuf_import_failed_ = true;\n \t\treturn -ENODEV;\n \t}\n \n", "prefixes": [ "v4", "3/5" ] }