[{"id":38953,"web_url":"https://patchwork.libcamera.org/comment/38953/","msgid":"<282d4249-13c5-4a63-96ae-9068a7a1b384@nxsw.ie>","date":"2026-05-26T17:34:03","subject":"Re: [PATCH v4 3/5] egl: eGLImage: Add flag to remember dmabuf import\n\tfails","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 21/05/2026 16:59, Robert Mader wrote:\n> In preparation of a following commit where we will start trying dmabuf\n> import for input buffers.\n> Also turn down error log in order to avoid flodding logs going\n> forward.\n> \n> Signed-off-by: Robert Mader \n> ---\n> include/libcamera/internal/egl.h | 1 +\n> src/libcamera/egl.cpp | 3 ++-\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index bcf09b475..57f90d93f 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -90,6 +90,7 @@ public:\n> \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n> \tGLuint texture_; /**< OpenGL texture object ID */\n> \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n> +\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n> \n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 267d22c8b..c185bb7ad 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -165,7 +165,8 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n> \t\t\t\t\t NULL, image_attrs);\n> \n> \tif (image == EGL_NO_IMAGE_KHR) {\n> -\t\tLOG(eGL, Error) << \"eglCreateImageKHR fail\";\n> +\t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n> +\t\teglImage.dmabuf_import_failed_ = true;\n> \t\treturn -ENODEV;\n> \t}\n> \n> --\n> 2.54.0\n> \n\nReviewed-by: Bryan O'Donoghue \n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17D6ABDCBC\n\tfor ;\n\tTue, 26 May 2026 17:34:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDEE762FEC;\n\tTue, 26 May 2026 19:34:08 +0200 (CEST)","from mail-24422.protonmail.ch (mail-24422.protonmail.ch\n\t[109.224.244.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B0B62FB1\n\tfor ;\n\tTue, 26 May 2026 19:34:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"kgZAYjZr\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail; t=1779816847; x=1780076047;\n\tbh=lrXRRNy8T+/fgM2lv4oKfNyetaM5ESc54jUg4DZ0cck=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=kgZAYjZrHv7b0ERuT6+v/unCORDnuU+Cc9dortGwCcArbKasi+WZpqGZ34EE1Str8\n\tjBW61XpWmihn5HS/oxqT4EeZoaVbh3ABx2ovzCA0ylusxFcOZDaXkL5P5FGCQQ0g2g\n\til9BiETbZwzX6S9IMQ3mRNZIcz9jO9KJY50FcZ7jh3xMe8VyciyGjcTgaE6bXdn5Ml\n\tEvfBJavgzVo9HrZeXPc3ZO2mu+AuVFl0vOhlltLoqF3CE0MiXbfuoVrnGV8UjzkUBB\n\tdZdCqiJMLXlQIpZC+YdYoRJeq5CvrKV2JALwoaKCxcCWl3MlJJYZ0XMMe/y3dLpwIG\n\tDggTT7yiYsVwQ==","Date":"Tue, 26 May 2026 17:34:03 +0000","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","From":"Bryan O'Donoghue ","Subject":"Re: [PATCH v4 3/5] egl: eGLImage: Add flag to remember dmabuf import\n\tfails","Message-ID":"<282d4249-13c5-4a63-96ae-9068a7a1b384@nxsw.ie>","In-Reply-To":"<20260521155906.120373-4-robert.mader@collabora.com>","References":"<20260521155906.120373-1-robert.mader@collabora.com>\n\t<20260521155906.120373-4-robert.mader@collabora.com>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"ef28b41458eb5dccda60b58d860f70693d0406c1","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]