Patch Detail
Show a patch.
GET /api/patches/26714/?format=api
{ "id": 26714, "url": "https://patchwork.libcamera.org/api/patches/26714/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26714/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260511-ov2740-tuning-v3-1-8ff3e57c7368@jetm.me>", "date": "2026-05-11T18:16:01", "name": "[v3,1/3] libcamera: software_isp: Drop redundant sumShift_ guard in finishFrame", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6b276a9366d8b115dc08fd0e72f7650ccc5f337a", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26714/mbox/", "series": [ { "id": 5933, "url": "https://patchwork.libcamera.org/api/series/5933/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5933", "date": "2026-05-11T18:16:00", "name": "ipa: simple: Add OV2740 tuning + AIQB parser", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5933/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26714/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26714/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7483CBDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 May 2026 18:16:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D7A26301A;\n\tMon, 11 May 2026 20:16:10 +0200 (CEST)", "from fout-b1-smtp.messagingengine.com\n\t(fout-b1-smtp.messagingengine.com [202.12.124.144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8483562E9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 May 2026 20:16:06 +0200 (CEST)", "from phl-compute-02.internal (phl-compute-02.internal\n\t[10.202.2.42])\n\tby mailfout.stl.internal (Postfix) with ESMTP id 792A91D00155;\n\tMon, 11 May 2026 14:16:05 -0400 (EDT)", "from phl-imap-07 ([10.202.2.97])\n\tby phl-compute-02.internal (MEProxy); Mon, 11 May 2026 14:16:05 -0400", "by mailuser.phl.internal (Postfix, from userid 501)\n\tid 2103A1EA006B; Mon, 11 May 2026 14:16:05 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"fVU4tIpK\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"Ti5dcHpp\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:content-type:date:date\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1778523365;\n\tx=1778609765; bh=bXv8QgCOCwDnXna1X01SjMJ8LH44mXxXFsakOOrQ30g=; b=\n\tfVU4tIpKKubSxYJXtIs7StvjguoWToRX40vLWlgDVr40M+BPFNVGI+q4f2KMRopw\n\t8xuDj8Ic2gwHBM5y2hamQV/8jgGojFn/+1msMxIpYbCrUL2u8kKe4rliaWN6Dzdh\n\ts4x2SOVg9OFzrcYicX3UDxNlxPaeHiwscmKDBu5nAJ8jXy4hNVeWNNPri00Y1VYC\n\t2k4V1tETyvcptmYA5vIDC0LbL+6vJjT4pHMJ+HJGF3dWxVHowKEwnXf9jO1JRZqj\n\trwvZZ0CaH4skOYtUFugf5qZ22YezA1LB5EiSxroA8lm/CoBp19wcjtY3++9fGHst\n\t0qMAfEE1Y4EsJ+s6obTZSQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778523365; x=\n\t1778609765; bh=bXv8QgCOCwDnXna1X01SjMJ8LH44mXxXFsakOOrQ30g=; b=T\n\ti5dcHppbW9YuQDLjSluP4iT1/OKRUIT3d4nh8kWjLPtm73TelYimTGxwyKwNPUxC\n\tKjKOUq9FLTbK+OiirLNoZrtlxm983bFhak9+z9fY7Ciqj/jDbLELNSVmLb47/vl+\n\toz0MSLprDn55tBhATfn1pxOp9cYFaE54dSLaW9zpjVwrrbwdWgEc9k1p1gyPXBGG\n\t740cYPc8TYYraPB3WDhhoaY9642tjiFHLuH7tqVmeUVqLofhUF17WLVzv2poFGbN\n\tuaKcXsBUyNlaGjAc7dngm9DZyoUsdVM0vq/4TsZnF0KkEqV9diecDd5iPsG8ecWQ\n\twWtlq6VD9p08r66WfB0Tw==" ], "X-ME-Sender": "<xms:5RwCavSSTiTvj989OhPgR18pqaGe4Jl4z6Kt5C8IRnERDwyKlgyUrQ>\n\t<xme:5RwCarmd-vkixtimILskaAxGqn4RsbzKkSWTqzjbOEqdjBKWO1la4DkTUcszXrG-p\n\tLm92o9DW38mSNIqhrj1P89zFI8xatk2yhifWuEc7y9EmS1l2Xild2mI>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudeliedvucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf\n\tgurhepoffhfffugggtgffkvfevofgjfhesthekredtredtjeenucfhrhhomheplfgrvhhi\n\tvghrucfvihgruceofhhlohhsshesjhgvthhmrdhmvgeqnecuggftrfgrthhtvghrnhepve\n\tektdfhffevuddtgfetieevtddvheduhfeggfekveejlefhleefieevueefiefhnecuvehl\n\tuhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfhhlohhsshesjh\n\tgvthhmrdhmvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtghp\n\tthhtoheprhhosggvrhhtrdhmrgguvghrsegtohhllhgrsghorhgrrdgtohhmpdhrtghpth\n\thtohepsggrrhhnrggsrghsrdhpohgtiigvsehiuggvrghsohhnsghorghrugdrtghomhdp\n\trhgtphhtthhopehkihgvrhgrnhdrsghinhhghhgrmhesihguvggrshhonhgsohgrrhgurd\n\tgtohhmpdhrtghpthhtoheplhgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhn\n\tsghorghrugdrtghomhdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehlih\n\thsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepjhhohhgrnhhnvghsrdhg\n\tohgvuggvsehoshhsrdhquhgrlhgtohhmmhdrtghomhdprhgtphhtthhopehmiigrmhgrii\n\tgrlhesrhgvughhrghtrdgtohhm", "X-ME-Proxy": "<xmx:5RwCak4EDPtDjLSncavKviqHcpmwOZ3szRvT8OKgKFLeTWJaVcOjLw>\n\t<xmx:5RwCav9IMZ5ofl9YBPmlEpBOEDUVygMpWiwg9VwRz031EeB_ihhHgQ>\n\t<xmx:5RwCajWKf4MvkGA_5mV3xoJKcRPsXABnSauz7Xo3YgmZ8LNs4fjrFw>\n\t<xmx:5RwCaqpxvoB8540JRw-AQbDTDxwW-9bAAlJYdqtwDbmX_-ZApXSjeg>\n\t<xmx:5RwCaj7dPJw6gUrrUiFG2Vfn0VuPDpEo4VruuMOJZoHD4lVauYCwvFzX>", "Feedback-ID": "i9dde48b3:Fastmail", "X-Mailer": [ "MessagingEngine.com Webmail Interface", "b4 0.15.2" ], "From": "Javier Tia <floss@jetm.me>", "Date": "Mon, 11 May 2026 12:16:01 -0600", "Subject": "[PATCH v3 1/3] libcamera: software_isp: Drop redundant sumShift_\n\tguard in finishFrame", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260511-ov2740-tuning-v3-1-8ff3e57c7368@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>, Robert Mader\n\t<robert.mader@collabora.com>, Hans de Goede\n\t<johannes.goede@oss.qualcomm.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1350; i=floss@jetm.me;\n\th=from:subject:message-id;\n\tbh=Nxi4aMjw+W7YmkXEKUECwpuUfdMTxYTUXauUrkEo+Zk=; \n\tb=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqAhzgH1/tCUwaCjDdT1t3c9tayJ+QNq+2Q5qgq\n\tUEn7PblWOyJAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCagIc4AAKCRC17sMLqGd3\n\tHx1NDACRxzeKteXgVsNScj4P7fmQCHMti+W8xgi5SyTXXqbOrJpu8tHG2EPEVwrasfEBJu4yzrT\n\tc92d/SW4oY8Ed9gPs40cmiwLpU35xsxkMQs5cm5+puN1tGnbEMBdE757cXj/Dn0Wjcpoa+veADt\n\tUOrJ55dz/AvkImTvs1dDdQvYtKBzwCQqfG0WNc/7ZF5n5XxFFD5j04XdVBP2zDudfagEMZDOnq3\n\t3WQWXPljNhLaneEIhEDpIgDBfDgwpteaV3b9ZiL6PNFJ+tj+NrJXyp3GdzP19DLYaGAcsOtg06F\n\tN65KFZHryX5enqlPzbLGTE65SuqNBuzo+xabnNC0SjdAWTixEGxGxZeVKfDz8LI9kHnqWPT6am9\n\tJ/MI00SnNV1o2f9cCSGBPkAsDEO8e+yGVPlBr0pongug3zNmjWEXwbGVSWO3Mke5dBs0szPZHDl\n\txHNru9j4EgeA4y+Jb+8c9j03w4P2Pe1dohavyYCEqTYMYNqralFzoCA1MTVIM1112sG+U=", "X-Developer-Key": "i=floss@jetm.me; a=openpgp;\n\tfpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F", "In-Reply-To": "<20260511-ov2740-tuning-v3-0-8ff3e57c7368@jetm.me>", "References": "<20260511-ov2740-tuning-v3-0-8ff3e57c7368@jetm.me>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Right-shifting by zero is a no-op, so the if (sumShift_) check before\nthe three >>= sumShift_ assignments is unnecessary. Remove it.\n\nSuggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSuggested-by: Barnabas Pocze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Javier Tia <floss@jetm.me>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex b40d3334..2e020e62 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -362,11 +362,10 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n \t\t\tfor (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++)\n \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n \t\t}\n-\t\tif (sumShift_) {\n-\t\t\tsharedStats_->sum_.r() >>= sumShift_;\n-\t\t\tsharedStats_->sum_.g() >>= sumShift_;\n-\t\t\tsharedStats_->sum_.b() >>= sumShift_;\n-\t\t}\n+\n+\t\tsharedStats_->sum_.r() >>= sumShift_;\n+\t\tsharedStats_->sum_.g() >>= sumShift_;\n+\t\tsharedStats_->sum_.b() >>= sumShift_;\n \t}\n \n \tsharedStats_->valid = valid;\n", "prefixes": [ "v3", "1/3" ] }