From patchwork Mon May 11 18:16:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Javier Tia X-Patchwork-Id: 26714 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7483CBDCBD for ; Mon, 11 May 2026 18:16:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1D7A26301A; Mon, 11 May 2026 20:16:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=jetm.me header.i=@jetm.me header.b="fVU4tIpK"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ti5dcHpp"; dkim-atps=neutral Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8483562E9D for ; Mon, 11 May 2026 20:16:06 +0200 (CEST) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 792A91D00155; Mon, 11 May 2026 14:16:05 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-02.internal (MEProxy); Mon, 11 May 2026 14:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1778523365; x=1778609765; bh=bXv8QgCOCwDnXna1X01SjMJ8LH44mXxXFsakOOrQ30g=; b= fVU4tIpKKubSxYJXtIs7StvjguoWToRX40vLWlgDVr40M+BPFNVGI+q4f2KMRopw 8xuDj8Ic2gwHBM5y2hamQV/8jgGojFn/+1msMxIpYbCrUL2u8kKe4rliaWN6Dzdh s4x2SOVg9OFzrcYicX3UDxNlxPaeHiwscmKDBu5nAJ8jXy4hNVeWNNPri00Y1VYC 2k4V1tETyvcptmYA5vIDC0LbL+6vJjT4pHMJ+HJGF3dWxVHowKEwnXf9jO1JRZqj rwvZZ0CaH4skOYtUFugf5qZ22YezA1LB5EiSxroA8lm/CoBp19wcjtY3++9fGHst 0qMAfEE1Y4EsJ+s6obTZSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778523365; x= 1778609765; bh=bXv8QgCOCwDnXna1X01SjMJ8LH44mXxXFsakOOrQ30g=; b=T i5dcHppbW9YuQDLjSluP4iT1/OKRUIT3d4nh8kWjLPtm73TelYimTGxwyKwNPUxC KjKOUq9FLTbK+OiirLNoZrtlxm983bFhak9+z9fY7Ciqj/jDbLELNSVmLb47/vl+ oz0MSLprDn55tBhATfn1pxOp9cYFaE54dSLaW9zpjVwrrbwdWgEc9k1p1gyPXBGG 740cYPc8TYYraPB3WDhhoaY9642tjiFHLuH7tqVmeUVqLofhUF17WLVzv2poFGbN uaKcXsBUyNlaGjAc7dngm9DZyoUsdVM0vq/4TsZnF0KkEqV9diecDd5iPsG8ecWQ wWtlq6VD9p08r66WfB0Tw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudeliedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepoffhfffugggtgffkvfevofgjfhesthekredtredtjeenucfhrhhomheplfgrvhhi vghrucfvihgruceofhhlohhsshesjhgvthhmrdhmvgeqnecuggftrfgrthhtvghrnhepve ektdfhffevuddtgfetieevtddvheduhfeggfekveejlefhleefieevueefiefhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfhhlohhsshesjh gvthhmrdhmvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtoheprhhosggvrhhtrdhmrgguvghrsegtohhllhgrsghorhgrrdgtohhmpdhrtghpth htohepsggrrhhnrggsrghsrdhpohgtiigvsehiuggvrghsohhnsghorghrugdrtghomhdp rhgtphhtthhopehkihgvrhgrnhdrsghinhhghhgrmhesihguvggrshhonhgsohgrrhgurd gtohhmpdhrtghpthhtoheplhgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhn sghorghrugdrtghomhdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehlih hsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepjhhohhgrnhhnvghsrdhg ohgvuggvsehoshhsrdhquhgrlhgtohhmmhdrtghomhdprhgtphhtthhopehmiigrmhgrii grlhesrhgvughhrghtrdgtohhm X-ME-Proxy: Feedback-ID: i9dde48b3:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2103A1EA006B; Mon, 11 May 2026 14:16:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface From: Javier Tia Date: Mon, 11 May 2026 12:16:01 -0600 Subject: [PATCH v3 1/3] libcamera: software_isp: Drop redundant sumShift_ guard in finishFrame MIME-Version: 1.0 Message-Id: <20260511-ov2740-tuning-v3-1-8ff3e57c7368@jetm.me> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , Laurent Pinchart , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= , Milan Zamazal , Robert Mader , Hans de Goede X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1350; i=floss@jetm.me; h=from:subject:message-id; bh=Nxi4aMjw+W7YmkXEKUECwpuUfdMTxYTUXauUrkEo+Zk=; b=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqAhzgH1/tCUwaCjDdT1t3c9tayJ+QNq+2Q5qgq UEn7PblWOyJAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCagIc4AAKCRC17sMLqGd3 Hx1NDACRxzeKteXgVsNScj4P7fmQCHMti+W8xgi5SyTXXqbOrJpu8tHG2EPEVwrasfEBJu4yzrT c92d/SW4oY8Ed9gPs40cmiwLpU35xsxkMQs5cm5+puN1tGnbEMBdE757cXj/Dn0Wjcpoa+veADt UOrJ55dz/AvkImTvs1dDdQvYtKBzwCQqfG0WNc/7ZF5n5XxFFD5j04XdVBP2zDudfagEMZDOnq3 3WQWXPljNhLaneEIhEDpIgDBfDgwpteaV3b9ZiL6PNFJ+tj+NrJXyp3GdzP19DLYaGAcsOtg06F N65KFZHryX5enqlPzbLGTE65SuqNBuzo+xabnNC0SjdAWTixEGxGxZeVKfDz8LI9kHnqWPT6am9 J/MI00SnNV1o2f9cCSGBPkAsDEO8e+yGVPlBr0pongug3zNmjWEXwbGVSWO3Mke5dBs0szPZHDl xHNru9j4EgeA4y+Jb+8c9j03w4P2Pe1dohavyYCEqTYMYNqralFzoCA1MTVIM1112sG+U= X-Developer-Key: i=floss@jetm.me; a=openpgp; fpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F In-Reply-To: <20260511-ov2740-tuning-v3-0-8ff3e57c7368@jetm.me> References: <20260511-ov2740-tuning-v3-0-8ff3e57c7368@jetm.me> X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Right-shifting by zero is a no-op, so the if (sumShift_) check before the three >>= sumShift_ assignments is unnecessary. Remove it. Suggested-by: Laurent Pinchart Suggested-by: Barnabas Pocze Signed-off-by: Javier Tia Reviewed-by: Laurent Pinchart Reviewed-by: Barnabás Pőcze --- src/libcamera/software_isp/swstats_cpu.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index b40d3334..2e020e62 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -362,11 +362,10 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId) for (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++) sharedStats_->yHistogram[j] += s.yHistogram[j]; } - if (sumShift_) { - sharedStats_->sum_.r() >>= sumShift_; - sharedStats_->sum_.g() >>= sumShift_; - sharedStats_->sum_.b() >>= sumShift_; - } + + sharedStats_->sum_.r() >>= sumShift_; + sharedStats_->sum_.g() >>= sumShift_; + sharedStats_->sum_.b() >>= sumShift_; } sharedStats_->valid = valid;