Patch Detail
Show a patch.
GET /api/patches/26583/?format=api
{ "id": 26583, "url": "https://patchwork.libcamera.org/api/patches/26583/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26583/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428084550.91669-2-barnabas.pocze@ideasonboard.com>", "date": "2026-04-28T08:45:50", "name": "[v1,2/2] test: controls: control_info_map: Fix libc++ warning", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7fbcda71114e7f3a5610a23b7c7b497e8b20ee9b", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26583/mbox/", "series": [ { "id": 5890, "url": "https://patchwork.libcamera.org/api/series/5890/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5890", "date": "2026-04-28T08:45:49", "name": "[v1,1/2] libcamera: base: regex: Fix preprocessor check", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5890/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26583/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26583/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64988C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Apr 2026 08:45:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 829E062FC8;\n\tTue, 28 Apr 2026 10:45:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ED9162FC2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2026 10:45:54 +0200 (CEST)", "from pb-laptop.local (185.221.140.120.nat.pool.zt.hu\n\t[185.221.140.120])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96105E91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2026 10:44:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gvjrLX/K\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777365851;\n\tbh=LiT5m6l1GyfANs/VKLVfm12wXIflCYIvci3RaxHBlEg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gvjrLX/KT+QYS0Iei/T82MvvbxzFYHocIHjjGMkv2VnHoHc/x8BCPIrLEDHxtEIm5\n\t1cNiNpCLVdGbMwSIoLukICRTkjl2gHvPcBJN/zuTBEKfcvuigHQY0evq6gRUW69/CZ\n\t/r+uHOTbKDfVBXwR7XowEJYxw+7B/Egr4miw90Iw=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/2] test: controls: control_info_map: Fix libc++ warning", "Date": "Tue, 28 Apr 2026 10:45:50 +0200", "Message-ID": "<20260428084550.91669-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>", "References": "<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since llvm 22, libc++ has made `std::unordered_map::at()` have the `nodiscard`\nattribute, leading to warnings, fix that with `std::ignore`.\n\nLink: https://github.com/llvm/llvm-project/commit/9a03a30706cca40b93146f379fb5faa75d417af5\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n test/controls/control_info_map.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp\nindex b0be14b58..6c20ee8d0 100644\n--- a/test/controls/control_info_map.cpp\n+++ b/test/controls/control_info_map.cpp\n@@ -49,7 +49,7 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tinfoMap.at(&controls::Brightness);\n+\t\tstd::ignore = infoMap.at(&controls::Brightness);\n \n \t\t/* Test looking up a valid control by numerical ID. */\n \t\tif (infoMap.count(controls::Brightness.id()) != 1) {\n", "prefixes": [ "v1", "2/2" ] }