[{"id":38674,"web_url":"https://patchwork.libcamera.org/comment/38674/","msgid":"<177754645315.45302.2700289746221633489@ping.linuxembedded.co.uk>","date":"2026-04-30T10:54:13","subject":"Re: [PATCH v1 2/2] test: controls: control_info_map: Fix libc++\n\twarning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-04-28 09:45:50)\n> Since llvm 22, libc++ has made `std::unordered_map::at()` have the `nodiscard`\n> attribute, leading to warnings, fix that with `std::ignore`.\n> \n> Link: https://github.com/llvm/llvm-project/commit/9a03a30706cca40b93146f379fb5faa75d417af5\n> Signed-off-by: Barnabás Pőcze \n> ---\n> test/controls/control_info_map.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp\n> index b0be14b58..6c20ee8d0 100644\n> --- a/test/controls/control_info_map.cpp\n> +++ b/test/controls/control_info_map.cpp\n> @@ -49,7 +49,7 @@ protected:\n> return TestFail;\n> }\n> \n> - infoMap.at(&controls::Brightness);\n> + std::ignore = infoMap.at(&controls::Brightness);\n\nI presume the test is looking for the fact that this will compile and\nnot cause an assertion rather than actually doing anything with the data\n?\n\nSo ignoreing it is the same as what we have, so at least in that\ninstance for this patch:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> /* Test looking up a valid control by numerical ID. */\n> if (infoMap.count(controls::Brightness.id()) != 1) {\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C435BDCB5\n\tfor ;\n\tThu, 30 Apr 2026 10:54:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B1D062FEB;\n\tThu, 30 Apr 2026 12:54:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FE4062FC8\n\tfor ;\n\tThu, 30 Apr 2026 12:54:15 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 777DF8FA;\n\tThu, 30 Apr 2026 12:52:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fyUiu8EE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777546351;\n\tbh=GiYpZAajQ4OnSAuvos+Fb1YocP9MUTpWx59Ndf0QNy4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=fyUiu8EEJx78lS+cmxUBUgR351/Tzck5GXsSLpgYn7ALRBC2cBhFuPMhwBSU2FfBG\n\t3Chrv6kWURYRiDmmJxCt3MP/IFZdM2ki2XKximUdqEanoBm+0QslclDXYhR1N/am1w\n\tkXWz1vstn/G55VuVvgBhqNqFTvzagh7GbKZc5msU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260428084550.91669-2-barnabas.pocze@ideasonboard.com>","References":"<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>\n\t<20260428084550.91669-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 2/2] test: controls: control_info_map: Fix libc++\n\twarning","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 30 Apr 2026 11:54:13 +0100","Message-ID":"<177754645315.45302.2700289746221633489@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38675,"web_url":"https://patchwork.libcamera.org/comment/38675/","msgid":"<7e328abe-1a0a-4907-8e0e-9f94fc1a788c@ideasonboard.com>","date":"2026-04-30T10:57:19","subject":"Re: [PATCH v1 2/2] test: controls: control_info_map: Fix libc++\n\twarning","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 30. 12:54 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2026-04-28 09:45:50)\n>> Since llvm 22, libc++ has made `std::unordered_map::at()` have the `nodiscard`\n>> attribute, leading to warnings, fix that with `std::ignore`.\n>>\n>> Link: https://github.com/llvm/llvm-project/commit/9a03a30706cca40b93146f379fb5faa75d417af5\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> test/controls/control_info_map.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp\n>> index b0be14b58..6c20ee8d0 100644\n>> --- a/test/controls/control_info_map.cpp\n>> +++ b/test/controls/control_info_map.cpp\n>> @@ -49,7 +49,7 @@ protected:\n>> return TestFail;\n>> }\n>> \n>> - infoMap.at(&controls::Brightness);\n>> + std::ignore = infoMap.at(&controls::Brightness);\n> \n> I presume the test is looking for the fact that this will compile and\n> not cause an assertion rather than actually doing anything with the data\n> ?\n\nYes, it throws an assertion if not found, which would abort the process\nsince there are no handlers, leading to the test failure.\n\n\n> \n> So ignoreing it is the same as what we have, so at least in that\n> instance for this patch:\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n>> \n>> /* Test looking up a valid control by numerical ID. */\n>> if (infoMap.count(controls::Brightness.id()) != 1) {\n>> -- \n>> 2.54.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F037CBDCB5\n\tfor ;\n\tThu, 30 Apr 2026 10:57:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 237F762FE5;\n\tThu, 30 Apr 2026 12:57:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24DD162FC8\n\tfor ;\n\tThu, 30 Apr 2026 12:57:23 +0200 (CEST)","from [192.168.33.72] (185.221.140.120.nat.pool.zt.hu\n\t[185.221.140.120])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8E8E34;\n\tThu, 30 Apr 2026 12:55:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vLBLWWHi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777546538;\n\tbh=6h+gCVMxSxf3PuOYrIjIxWHrKjCbWm9WoD59afV4r/A=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=vLBLWWHizr99zugwnx9L7LwDPj5nmTPaVeRhrhyKjmZdZk8KH/D+TNiuGmaSU33YF\n\tWA+3zDOwIlSHVZ04yVr4IZH6TMFrxXcdRHSn6jYzCESXKaoHgBdI8v5piXzyg5+QOJ\n\tKHYZudTjNmXr+uwJv/Mn5YtcagIWgqGgYX+4iE3w=","Message-ID":"<7e328abe-1a0a-4907-8e0e-9f94fc1a788c@ideasonboard.com>","Date":"Thu, 30 Apr 2026 12:57:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 2/2] test: controls: control_info_map: Fix libc++\n\twarning","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>\n\t<20260428084550.91669-2-barnabas.pocze@ideasonboard.com>\n\t<177754645315.45302.2700289746221633489@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<177754645315.45302.2700289746221633489@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]