Patch Detail
Show a patch.
GET /api/patches/26557/?format=api
{ "id": 26557, "url": "https://patchwork.libcamera.org/api/patches/26557/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26557/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423230059.3180987-36-laurent.pinchart@ideasonboard.com>", "date": "2026-04-23T23:00:57", "name": "[v3,35/37] libcamera: software_isp: Rename \"measure\" option to \"benchmark\"", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1d3abe7f1f2a8e82c8f384e495547580ed30b2b2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26557/mbox/", "series": [ { "id": 5883, "url": "https://patchwork.libcamera.org/api/series/5883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5883", "date": "2026-04-23T23:00:22", "name": "libcamera: Global configuration file improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26557/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26557/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC638BDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Apr 2026 23:02:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 613BD62FEA;\n\tFri, 24 Apr 2026 01:02:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DF4262FDA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:01:49 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 062141A4A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:00:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UdOgjiYl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985210;\n\tbh=/gVnENFzXG3dl4/tzf6ezmch6NTH4Oh9HOUdLsW9/JU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UdOgjiYlM7dbyZI02rvLhpAs9IlDJw1L4EP1zsQeyLhlZ1rgq1BBBMHc4fwzbUqbp\n\tNYqCkw2o2u8JCmde6Rys64f2sOT40aW8UBQenyox4I/CpObNFcuJT9xwPo8cF/f0pa\n\tID5zcJ1yI8LDn+3mVC0yvbst/IjO6hFoDJl/5wrE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 35/37] libcamera: software_isp: Rename \"measure\" option to\n\t\"benchmark\"", "Date": "Fri, 24 Apr 2026 02:00:57 +0300", "Message-ID": "<20260423230059.3180987-36-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "References": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The software ISP \"measure\" configuration option doesn't clearly indicate\nwhat it measures. Rename it to \"benchmark\" to match the name of the\nclass that handles it and make it self-explicit.\n\nWhile at it, improve the documentation slightly by replacing \"per-frame\ntime measurement\" with \"performance measurement\".\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\n Documentation/runtime_configuration.rst | 10 +++++-----\n src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n 2 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\nindex 2cdffb335a66..fa7fb34f8eff 100644\n--- a/Documentation/runtime_configuration.rst\n+++ b/Documentation/runtime_configuration.rst\n@@ -48,7 +48,7 @@ file structure:\n software_isp: # true/false\n software_isp:\n copy_input_buffer: # true/false\n- measure:\n+ benchmark:\n skip: # non-negative integer, frames to skip initially\n number: # non-negative integer, frames to measure\n mode: # cpu/gpu\n@@ -83,7 +83,7 @@ Configuration file example\n software_isp: true\n software_isp:\n copy_input_buffer: false\n- measure:\n+ benchmark:\n skip: 50\n number: 30\n mode: gpu\n@@ -166,13 +166,13 @@ software_isp.copy_input_buffer\n \n Example value: ``false``\n \n-software_isp.measure.skip, software_isp.measure.number\n- Define per-frame time measurement parameters in software ISP. `skip`\n+software_isp.benchmark.skip, software_isp.benchmark.number\n+ Define performance measurement parameters for the software ISP. `skip`\n defines how many initial frames are skipped before starting the\n measurement; `number` defines how many frames then participate in the\n measurement.\n \n- Set `software_isp.measure.number` to 0 to disable the measurement.\n+ Set `software_isp.benchmark.number` to 0 to disable the measurement.\n \n Example `skip` value: ``50``\n \ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex 96f0ae004563..22cc8cfb984e 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -35,11 +35,11 @@ Benchmark::Benchmark(const CameraManager &cm, const std::string &name)\n \tconst GlobalConfiguration &configuration = cm._d()->configuration();\n \n \tskipBeforeMeasure_ = configuration.option<unsigned int>(\n-\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"skip\" })\n-\t\t\t\t\t\t\t.value_or(skipBeforeMeasure_);\n-\tframesToMeasure_ = configuration.option<unsigned int>(\n-\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"number\" })\n-\t\t\t\t\t\t\t.value_or(framesToMeasure_);\n+\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"skip\" })\n+\t\t\t\t\t .value_or(skipBeforeMeasure_);\n+ framesToMeasure_ = configuration.option<unsigned int>(\n+\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"number\" })\n+\t\t\t\t\t.value_or(framesToMeasure_);\n }\n \n Benchmark::~Benchmark()\n", "prefixes": [ "v3", "35/37" ] }