From patchwork Thu Apr 23 23:00:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26557 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BC638BDCB5 for ; Thu, 23 Apr 2026 23:02:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 613BD62FEA; Fri, 24 Apr 2026 01:02:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UdOgjiYl"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DF4262FDA for ; Fri, 24 Apr 2026 01:01:49 +0200 (CEST) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 062141A4A for ; Fri, 24 Apr 2026 01:00:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776985210; bh=/gVnENFzXG3dl4/tzf6ezmch6NTH4Oh9HOUdLsW9/JU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UdOgjiYlM7dbyZI02rvLhpAs9IlDJw1L4EP1zsQeyLhlZ1rgq1BBBMHc4fwzbUqbp NYqCkw2o2u8JCmde6Rys64f2sOT40aW8UBQenyox4I/CpObNFcuJT9xwPo8cF/f0pa ID5zcJ1yI8LDn+3mVC0yvbst/IjO6hFoDJl/5wrE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH v3 35/37] libcamera: software_isp: Rename "measure" option to "benchmark" Date: Fri, 24 Apr 2026 02:00:57 +0300 Message-ID: <20260423230059.3180987-36-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260423230059.3180987-1-laurent.pinchart@ideasonboard.com> References: <20260423230059.3180987-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The software ISP "measure" configuration option doesn't clearly indicate what it measures. Rename it to "benchmark" to match the name of the class that handles it and make it self-explicit. While at it, improve the documentation slightly by replacing "per-frame time measurement" with "performance measurement". Signed-off-by: Laurent Pinchart Reviewed-by: Barnabás Pőcze Reviewed-by: Isaac Scott --- Documentation/runtime_configuration.rst | 10 +++++----- src/libcamera/software_isp/benchmark.cpp | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst index 2cdffb335a66..fa7fb34f8eff 100644 --- a/Documentation/runtime_configuration.rst +++ b/Documentation/runtime_configuration.rst @@ -48,7 +48,7 @@ file structure: software_isp: # true/false software_isp: copy_input_buffer: # true/false - measure: + benchmark: skip: # non-negative integer, frames to skip initially number: # non-negative integer, frames to measure mode: # cpu/gpu @@ -83,7 +83,7 @@ Configuration file example software_isp: true software_isp: copy_input_buffer: false - measure: + benchmark: skip: 50 number: 30 mode: gpu @@ -166,13 +166,13 @@ software_isp.copy_input_buffer Example value: ``false`` -software_isp.measure.skip, software_isp.measure.number - Define per-frame time measurement parameters in software ISP. `skip` +software_isp.benchmark.skip, software_isp.benchmark.number + Define performance measurement parameters for the software ISP. `skip` defines how many initial frames are skipped before starting the measurement; `number` defines how many frames then participate in the measurement. - Set `software_isp.measure.number` to 0 to disable the measurement. + Set `software_isp.benchmark.number` to 0 to disable the measurement. Example `skip` value: ``50`` diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp index 96f0ae004563..22cc8cfb984e 100644 --- a/src/libcamera/software_isp/benchmark.cpp +++ b/src/libcamera/software_isp/benchmark.cpp @@ -35,11 +35,11 @@ Benchmark::Benchmark(const CameraManager &cm, const std::string &name) const GlobalConfiguration &configuration = cm._d()->configuration(); skipBeforeMeasure_ = configuration.option( - { "software_isp", "measure", "skip" }) - .value_or(skipBeforeMeasure_); - framesToMeasure_ = configuration.option( - { "software_isp", "measure", "number" }) - .value_or(framesToMeasure_); + { "software_isp", "benchmark", "skip" }) + .value_or(skipBeforeMeasure_); + framesToMeasure_ = configuration.option( + { "software_isp", "benchmark", "number" }) + .value_or(framesToMeasure_); } Benchmark::~Benchmark()