Patch Detail
Show a patch.
GET /api/patches/26536/?format=api
{ "id": 26536, "url": "https://patchwork.libcamera.org/api/patches/26536/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26536/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423230059.3180987-15-laurent.pinchart@ideasonboard.com>", "date": "2026-04-23T23:00:36", "name": "[v3,14/37] libcamera: value_node: Add constructor with value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "097c13cd9662cf52f3f413cb42150375db10067f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26536/mbox/", "series": [ { "id": 5883, "url": "https://patchwork.libcamera.org/api/series/5883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5883", "date": "2026-04-23T23:00:22", "name": "libcamera: Global configuration file improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26536/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26536/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 942ABC32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Apr 2026 23:01:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 412D362FA8;\n\tFri, 24 Apr 2026 01:01:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8DC962F75\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:01:20 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EF69802\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 00:59:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UbjP7Jwh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985181;\n\tbh=W3M2DdCXe1Dp/v21zwb9TIWjYy/jlfmZhUfU/4yzz4c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UbjP7Jwhj2HVxu8C73SYjGobojfeYSxVr6/OJZLLKAUvZhbhCGU9QLEETv8XVPbYn\n\te4SkGoY1xuVFwM1zKiUfz5URccrKmJOVP7OfDVb7fEKX+UOD5n6gLcHcDZA0NGQ+yI\n\tCFwHns08cVMouCFoP8RGzQM64jRiSeW0+AXL1UC8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 14/37] libcamera: value_node: Add constructor with value", "Date": "Fri, 24 Apr 2026 02:00:36 +0300", "Message-ID": "<20260423230059.3180987-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "References": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The new constructor takes a value, allowing creation of a leaf ValueNode\nwith a value in a single operation instead of having to call set() on an\nempty node.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\nChanges since v1:\n\n- Initialize type_ to Empty\n---\n include/libcamera/internal/value_node.h | 8 ++++++++\n src/libcamera/value_node.cpp | 7 +++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex d4533df1a643..bcf2c8ecc90e 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,6 +143,14 @@ public:\n #endif /* __DOXYGEN__ */\n \n \tValueNode();\n+\n+\ttemplate<typename T>\n+\tValueNode(T &&value)\n+\t\t: type_(Type::Empty)\n+\t{\n+\t\tset(std::forward<T>(value));\n+\t}\n+\n \t~ValueNode();\n \n \tbool isValue() const\ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex 2d1642c2dd06..324419f02bb6 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -44,6 +44,13 @@ ValueNode::ValueNode()\n {\n }\n \n+/**\n+ * \\fn template<typename T> ValueNode::ValueNode(T &&value)\n+ * \\brief Construct a ValueNode instance with a value\n+ * \\tparam T Type of the value\n+ * \\param[in] value The value\n+ */\n+\n ValueNode::~ValueNode() = default;\n \n /**\n", "prefixes": [ "v3", "14/37" ] }