Patch Detail
Show a patch.
GET /api/patches/26498/?format=api
{ "id": 26498, "url": "https://patchwork.libcamera.org/api/patches/26498/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26498/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408075540.53309-2-hpa@redhat.com>", "date": "2026-04-08T07:55:37", "name": "[1/4] libcamera: pub_key: Add ML-DSA-65 signature algorithm for PQC compliance", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b9bc0cad118df54f1165c13a6f66406f69c373c9", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26498/mbox/", "series": [ { "id": 5875, "url": "https://patchwork.libcamera.org/api/series/5875/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5875", "date": "2026-04-08T07:55:36", "name": "Implement ML-DSA-65 for Post-Quantum Cryptographic compliance", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5875/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26498/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26498/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8AF6BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Apr 2026 07:56:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D2A262DB7;\n\tWed, 8 Apr 2026 09:56:28 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2397362DA6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 09:56:27 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-692-J9BOVr2fO5eUdmzkXR2caQ-1;\n\tWed, 08 Apr 2026 03:56:24 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid C19A1195608E for <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 07:56:23 +0000 (UTC)", "from fedora.redhat.com (unknown [10.67.32.15])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3C3F830001BB; Wed, 8 Apr 2026 07:56:21 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"SorPCmky\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1775634985;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=0O3fyPHHp57bswz2D8I6bzccBP1mTD6VJ226V09wIK8=;\n\tb=SorPCmkyopLfvJsfS9sc0NK1S5LlHeH7PDaKRwgnCRBDI8O4ZS6OV8XA+F6M4uP0omdOb+\n\t5GR7wxIRPf+A/DkrWJO12l9HqqK+dd1GdVDwOPVeXZ9gaHEI9dXpkO1neUXyxjLeaHtgDY\n\t5Xv0VA8arAj5gjZvjzEda8dUiHsPxJo=", "X-MC-Unique": "J9BOVr2fO5eUdmzkXR2caQ-1", "X-Mimecast-MFC-AGG-ID": "J9BOVr2fO5eUdmzkXR2caQ_1775634983", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kate Hsuan <hpa@redhat.com>", "Subject": "[PATCH 1/4] libcamera: pub_key: Add ML-DSA-65 signature algorithm\n\tfor PQC compliance", "Date": "Wed, 8 Apr 2026 15:55:37 +0800", "Message-ID": "<20260408075540.53309-2-hpa@redhat.com>", "In-Reply-To": "<20260408075540.53309-1-hpa@redhat.com>", "References": "<20260408075540.53309-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "zCRcpyGPtJ_Rp3c54g9OgiRLyOdtmv-TI--CTePgooU_1775634983", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As quantum computing advances, traditional signature algorithms are\nbecoming vulnerable. To ensure long-term data security, this change\nimplements ML-DSA-65, the primary Post-Quantum Cryptography (PQC)\nstandard finalized by NIST. This addition prepares for the transition\naway from RSA, which is slated for deprecation by 2035.\n\nLink: https://csrc.nist.gov/projects/post-quantum-cryptography/post-quantum-cryptography-standardization/evaluation-criteria/security-(evaluation-criteria)\nLink: https://nvlpubs.nist.gov/nistpubs/ir/2024/NIST.IR.8547.ipd.pdf\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/libcamera/pub_key.cpp | 55 ++++++++++++++++++++++++++++++++++++---\n 1 file changed, 52 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pub_key.cpp b/src/libcamera/pub_key.cpp\nindex f1d73a5c..20f13600 100644\n--- a/src/libcamera/pub_key.cpp\n+++ b/src/libcamera/pub_key.cpp\n@@ -14,8 +14,13 @@\n #include <openssl/x509.h>\n #elif HAVE_GNUTLS\n #include <gnutls/abstract.h>\n+#include <gnutls/gnutls.h>\n #endif\n \n+#include \"libcamera/internal/pub_key.h\"\n+#include <libcamera/base/log.h>\n+#include <libcamera/base/utils.h>\n+\n /**\n * \\file pub_key.h\n * \\brief Public key signature verification\n@@ -23,17 +28,24 @@\n \n namespace libcamera {\n \n+LOG_DEFINE_CATEGORY(PubKey);\n /**\n * \\class PubKey\n * \\brief Public key wrapper for signature verification\n *\n * The PubKey class wraps a public key and implements signature verification. It\n- * only supports RSA keys and the RSA-SHA256 signature algorithm.\n+ * supports RSA keys with the RSA-SHA256 signature algorithm, or ML-DSA-65 keys\n+ * as specified in NIST FIPS 204. The signature algorithm is determined in\n+ * compile time.\n */\n \n /**\n * \\brief Construct a PubKey from key data\n * \\param[in] key Key data encoded in DER format\n+ *\n+ * The signature algorithm is determined in the compile\n+ * Supported key types are RSA (verified with RSA-SHA256) and ML-DSA-65\n+ * (verified as ML-DSA-65 according to FIPS 204).\n */\n PubKey::PubKey([[maybe_unused]] Span<const uint8_t> key)\n \t: valid_(false)\n@@ -83,7 +95,8 @@ PubKey::~PubKey()\n * \\param[in] sig The signature\n *\n * Verify that the signature \\a sig matches the signed \\a data for the public\n- * key. The signture algorithm is hardcoded to RSA-SHA256.\n+ * key. The signature algorithm is determined in compile time. RSA keys use\n+ * RSA-SHA256, while ML-DSA keys use ML-DSA-65 mentioned in FIPS 204.\n *\n * \\return True if the signature is valid, false otherwise\n */\n@@ -94,6 +107,30 @@ bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,\n \t\treturn false;\n \n #if HAVE_CRYPTO\n+\n+#if WITH_FIPS\n+\t/* ML-DSA */\n+\tEVP_MD_CTX *ctx_dsa = EVP_MD_CTX_new();\n+\tif (!ctx_dsa) {\n+\t\tLOG(PubKey, Error) << \"Initialize context for ML-DSA failed\";\n+\t\treturn false;\n+\t}\n+\n+\tif (EVP_DigestVerifyInit(ctx_dsa, nullptr, nullptr, nullptr,\n+\t\t\t\t pubkey_) <= 0) {\n+\t\tEVP_MD_CTX_free(ctx_dsa);\n+\t\tLOG(PubKey, Error) << \"Initialize ML-DSA verification failed\";\n+\t\treturn false;\n+\t}\n+\n+\tint ret = EVP_DigestVerify(ctx_dsa, sig.data(), sig.size(),\n+\t\t\t\t data.data(), data.size());\n+\tEVP_MD_CTX_free(ctx_dsa);\n+\tLOG(PubKey, Error) << \"Verify with ML-DSA-65: \" << ret;\n+\treturn ret == 1;\n+#else\n+\t/* RSA with SHA-256 */\n+\n \t/*\n \t * Create and initialize a public key algorithm context for signature\n \t * verification.\n@@ -117,7 +154,11 @@ bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,\n \tint ret = EVP_PKEY_verify(ctx, sig.data(), sig.size(), digest,\n \t\t\t\t SHA256_DIGEST_LENGTH);\n \tEVP_PKEY_CTX_free(ctx);\n+\n+\tLOG(PubKey, Error) << \"Verify with RSA-SHA256: \" << ret;\n \treturn ret == 1;\n+#endif\n+\n #elif HAVE_GNUTLS\n \tconst gnutls_datum_t gnuTlsData{\n \t\tconst_cast<unsigned char *>(data.data()),\n@@ -129,9 +170,17 @@ bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,\n \t\tstatic_cast<unsigned int>(sig.size())\n \t};\n \n-\tint ret = gnutls_pubkey_verify_data2(pubkey_, GNUTLS_SIGN_RSA_SHA256, 0,\n+#if WITH_FIPS\n+\tint ret = gnutls_pubkey_verify_data2(pubkey_, GNUTLS_SIGN_MLDSA65, 0,\n \t\t\t\t\t &gnuTlsData, &gnuTlsSig);\n+\tLOG(PubKey, Error) << \"Verify with ML-DSA-65: \" << ret;\n+\treturn ret >= 0;\n+#else\n+\tint ret = gnutls_pubkey_verify_data2(pubkey_, GNUTLS_SIGN_RSA_SHA256,\n+\t\t\t\t\t 0, &gnuTlsData, &gnuTlsSig);\n+\tLOG(PubKey, Error) << \"Verify with RSA-SHA256: \" << ret;\n \treturn ret >= 0;\n+#endif\n #else\n \treturn false;\n #endif\n", "prefixes": [ "1/4" ] }