Patch Detail
Show a patch.
GET /api/patches/26438/?format=api
{ "id": 26438, "url": "https://patchwork.libcamera.org/api/patches/26438/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26438/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>", "date": "2026-04-05T22:27:05", "name": "[2/2] meson: Use <version> header for C++ library version check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "95bfe3b85f4008fd472e7624ca6ec6e404d46746", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26438/mbox/", "series": [ { "id": 5871, "url": "https://patchwork.libcamera.org/api/series/5871/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5871", "date": "2026-04-05T22:27:04", "name": "[1/2] Documentation: Update to C++20", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5871/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26438/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26438/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAC28BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 5 Apr 2026 22:27:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAE8D62D7C;\n\tMon, 6 Apr 2026 00:27:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48AB162CE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Apr 2026 00:27:08 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 048B463C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Apr 2026 00:25:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"maqx+E5C\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775427942;\n\tbh=lVOSm1GMOuVZKQhZih5rIZ8ejqyYn0cks9I0zSlFApw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=maqx+E5CN9bd4R3rnpK5FgFAJ6oOmjVTIiqKXek/LZjtwxaEJNgxHlBHwg1yXGQPQ\n\tQJz11nFbWq9zbN6ukadJr5PlCnNse5m01e6zXv4cp3zRD31HtQZVrdOVKZPFUyndYo\n\ttpQOq7h686xGNHa2mxT5SV+C187Ofsr3sQvreRfQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 2/2] meson: Use <version> header for C++ library version\n\tcheck", "Date": "Mon, 6 Apr 2026 01:27:05 +0300", "Message-ID": "<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260405222705.1238116-1-laurent.pinchart@ideasonboard.com>", "References": "<20260405222705.1238116-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ciso646 header has been removed in C++20. Use the version header\ninstead.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex a6cfdd07605c..a411d171d9db 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -118,10 +118,9 @@ cpp_arguments = [\n '-Wnon-virtual-dtor',\n ]\n \n-# \\todo Switch to `version` when moving to C++20 as `ciso646` has been removed in C++20.\n-if cxx.has_header_symbol('ciso646', '_LIBCPP_VERSION')\n+if cxx.has_header_symbol('version', '_LIBCPP_VERSION')\n cxx_stdlib = 'libc++'\n-elif cxx.has_header_symbol('ciso646', '__GLIBCXX__')\n+elif cxx.has_header_symbol('version', '__GLIBCXX__')\n cxx_stdlib = 'libstdc++'\n else\n error('C++ standard library cannot be detected')\n", "prefixes": [ "2/2" ] }