[{"id":38501,"web_url":"https://patchwork.libcamera.org/comment/38501/","msgid":"","date":"2026-04-07T10:03:46","subject":"Re: [PATCH 2/2] meson: Use header for C++ library version\n\tcheck","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Apr 06, 2026 at 01:27:05AM +0300, Laurent Pinchart wrote:\n> The ciso646 header has been removed in C++20. Use the version header\n> instead.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nthanks\n j\n> ---\n> meson.build | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/meson.build b/meson.build\n> index a6cfdd07605c..a411d171d9db 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -118,10 +118,9 @@ cpp_arguments = [\n> '-Wnon-virtual-dtor',\n> ]\n>\n> -# \\todo Switch to `version` when moving to C++20 as `ciso646` has been removed in C++20.\n> -if cxx.has_header_symbol('ciso646', '_LIBCPP_VERSION')\n> +if cxx.has_header_symbol('version', '_LIBCPP_VERSION')\n> cxx_stdlib = 'libc++'\n> -elif cxx.has_header_symbol('ciso646', '__GLIBCXX__')\n> +elif cxx.has_header_symbol('version', '__GLIBCXX__')\n> cxx_stdlib = 'libstdc++'\n> else\n> error('C++ standard library cannot be detected')\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B397FBEFBE\n\tfor ;\n\tTue, 7 Apr 2026 10:03:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 093F262D82;\n\tTue, 7 Apr 2026 12:03:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8A9262846\n\tfor ;\n\tTue, 7 Apr 2026 12:03:51 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DE662F8;\n\tTue, 7 Apr 2026 12:02:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z8MJsMPG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775556144;\n\tbh=pRwSngy2Rhl0ibEiZ510GBLNJ9gBgtr4/GUa8Kgy9XE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Z8MJsMPG7FLSfgZyrLK5UPGjGv/ibRTKDfko18i7tXDg2nRktazgSbvA0cZoYJwZi\n\tD1MhbBGk+gYCxlFT4Hx2GXK5PEZqeFxmmsLOJ9FvsmjW86V/J6KxLri7eqoKu72IyG\n\t6G5PK5MFYU9VbgIBl5oNBVvBTjCY8e4joWYEEBK8=","Date":"Tue, 7 Apr 2026 12:03:46 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] meson: Use header for C++ library version\n\tcheck","Message-ID":"","References":"<20260405222705.1238116-1-laurent.pinchart@ideasonboard.com>\n\t<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38575,"web_url":"https://patchwork.libcamera.org/comment/38575/","msgid":"<30f13547-748c-44f2-9449-a4070a7284ff@ideasonboard.com>","date":"2026-04-13T06:53:51","subject":"Re: [PATCH 2/2] meson: Use header for C++ library version\n\tcheck","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 06. 0:27 keltezéssel, Laurent Pinchart írta:\n> The ciso646 header has been removed in C++20. Use the version header\n> instead.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> meson.build | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index a6cfdd07605c..a411d171d9db 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -118,10 +118,9 @@ cpp_arguments = [\n> '-Wnon-virtual-dtor',\n> ]\n> \n> -# \\todo Switch to `version` when moving to C++20 as `ciso646` has been removed in C++20.\n> -if cxx.has_header_symbol('ciso646', '_LIBCPP_VERSION')\n> +if cxx.has_header_symbol('version', '_LIBCPP_VERSION')\n> cxx_stdlib = 'libc++'\n> -elif cxx.has_header_symbol('ciso646', '__GLIBCXX__')\n> +elif cxx.has_header_symbol('version', '__GLIBCXX__')\n> cxx_stdlib = 'libstdc++'\n> else\n> error('C++ standard library cannot be detected')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D3B8BDCBD\n\tfor ;\n\tMon, 13 Apr 2026 06:53:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0811362E6A;\n\tMon, 13 Apr 2026 08:53:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D5C662E57\n\tfor ;\n\tMon, 13 Apr 2026 08:53:55 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B3494BB;\n\tMon, 13 Apr 2026 08:52:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GCPRzvr0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776063144;\n\tbh=VSisDLmZuBlK9waw8RKxpEU8HJS5H7s31E+RIYOJkMM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=GCPRzvr0micXYsTLalHkM82xG71ly51x60pXj1f9bJ/+L/9SXQUlPJHRrpao04N3e\n\tcmAIi8Gy8jsX2n6kW4vaNQ3y+5QHA6S6IQmhVgAtaLvCPdoqInQjFbE7RJBMIF7YSL\n\tk28NGRiHrr7xnyNhQssEyIBb5ZkBxSDSSkw+bfyM=","Message-ID":"<30f13547-748c-44f2-9449-a4070a7284ff@ideasonboard.com>","Date":"Mon, 13 Apr 2026 08:53:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] meson: Use header for C++ library version\n\tcheck","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405222705.1238116-1-laurent.pinchart@ideasonboard.com>\n\t<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405222705.1238116-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]