Patch Detail
Show a patch.
GET /api/patches/26436/?format=api
{ "id": 26436, "url": "https://patchwork.libcamera.org/api/patches/26436/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26436/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260405222436.1237846-1-laurent.pinchart@ideasonboard.com>", "date": "2026-04-05T22:24:36", "name": "[v2] meson: Print missing application options in summary", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "de7b4b4919ebd1858f24476346a0c67ffbab1c4f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26436/mbox/", "series": [ { "id": 5870, "url": "https://patchwork.libcamera.org/api/series/5870/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5870", "date": "2026-04-05T22:24:36", "name": "[v2] meson: Print missing application options in summary", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5870/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26436/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26436/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C042EBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 5 Apr 2026 22:24:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEAF862CE6;\n\tMon, 6 Apr 2026 00:24:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6A5C62CE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Apr 2026 00:24:37 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4ED3F63C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Apr 2026 00:23:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gkELZGQo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775427791;\n\tbh=FLhMYr10CgwCk1ovhun+pqgG808NC3VRYo7yvkV/wL8=;\n\th=From:To:Subject:Date:From;\n\tb=gkELZGQoVFpiP5ZttB33ld6iK20afeHO3fgO8qUWuE/RRu/bBuRfeWav3z9gNXSJF\n\tYh2UdK355zjbD9eLEQFd5+MaWLgscYlfdcunit4zs9YB52tUT84YeZ0m+C8oVJQSrA\n\tBpp6acCnysbRoIIGTEHeiQFWvSy+C5j6nUDK4Bbg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2] meson: Print missing application options in summary", "Date": "Mon, 6 Apr 2026 01:24:36 +0300", "Message-ID": "<20260405222436.1237846-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The recently added application options (DNG output support, KMS and SDL2\noutputs for cam, and JPEG support for cam) are not printed in the\nsummary. This makes it more difficult to quickly assess the\nconfiguration when those options are set to the 'auto' value. Add them\nto the summary, and move all application configuration options to a\ndedicated section of the summary to improve readability.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Declare cam_options[] earlier to avoid failures when the cam\n application is disabled\n---\n meson.build | 3 ---\n src/apps/cam/meson.build | 5 +++++\n src/apps/meson.build | 10 ++++++++++\n 3 files changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 2e2a27ef4c25..a6cfdd07605c 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -305,9 +305,6 @@ summary({\n 'GStreamer support': gst_enabled,\n 'Python bindings': pycamera_enabled,\n 'V4L2 emulation support': v4l2_enabled,\n- 'cam application': cam_enabled,\n- 'qcam application': qcam_enabled,\n- 'lc-compliance application': lc_compliance_enabled,\n 'Unit tests': test_enabled,\n },\n section : 'Configuration',\ndiff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\nindex 0fd8462700a9..efd4c268db56 100644\n--- a/src/apps/cam/meson.build\n+++ b/src/apps/cam/meson.build\n@@ -1,5 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+cam_options = []\n+\n if opt_cam.disabled() or not libevent.found()\n cam_enabled = false\n subdir_done()\n@@ -39,6 +41,7 @@ if libdrm.found()\n cam_deps += [\n libdrm,\n ]\n+ cam_options += 'output-kms'\n endif\n \n if libsdl2.found()\n@@ -52,6 +55,7 @@ if libsdl2.found()\n cam_deps += [\n libsdl2,\n ]\n+ cam_options += 'output-sdl2'\n \n if libjpeg.found()\n cam_cpp_args += ['-DHAVE_LIBJPEG']\n@@ -61,6 +65,7 @@ if libsdl2.found()\n cam_deps += [\n libjpeg,\n ]\n+ cam_options += 'jpeg'\n endif\n endif\n \ndiff --git a/src/apps/meson.build b/src/apps/meson.build\nindex bc3a79196949..bd2f7858e1a3 100644\n--- a/src/apps/meson.build\n+++ b/src/apps/meson.build\n@@ -20,3 +20,13 @@ subdir('cam')\n subdir('qcam')\n \n subdir('ipa-verify')\n+\n+summary({\n+ 'cam application': cam_enabled,\n+ 'cam options': cam_options,\n+ 'DNG output support': libtiff.found(),\n+ 'qcam application': qcam_enabled,\n+ 'lc-compliance application': lc_compliance_enabled,\n+ },\n+ section : 'Applications',\n+ bool_yn : true)\n", "prefixes": [ "v2" ] }