[{"id":38583,"web_url":"https://patchwork.libcamera.org/comment/38583/","msgid":"<9a6b0596-fe25-4f24-b3f9-fbbd72564c40@ideasonboard.com>","date":"2026-04-13T08:25:11","subject":"Re: [PATCH v2] meson: Print missing application options in summary","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 06. 0:24 keltezéssel, Laurent Pinchart írta:\n> The recently added application options (DNG output support, KMS and SDL2\n> outputs for cam, and JPEG support for cam) are not printed in the\n> summary. This makes it more difficult to quickly assess the\n> configuration when those options are set to the 'auto' value. Add them\n> to the summary, and move all application configuration options to a\n> dedicated section of the summary to improve readability.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Changes since v1:\n> \n> - Declare cam_options[] earlier to avoid failures when the cam\n> application is disabled\n> ---\n\nLooks ok to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> meson.build | 3 ---\n> src/apps/cam/meson.build | 5 +++++\n> src/apps/meson.build | 10 ++++++++++\n> 3 files changed, 15 insertions(+), 3 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 2e2a27ef4c25..a6cfdd07605c 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -305,9 +305,6 @@ summary({\n> 'GStreamer support': gst_enabled,\n> 'Python bindings': pycamera_enabled,\n> 'V4L2 emulation support': v4l2_enabled,\n> - 'cam application': cam_enabled,\n> - 'qcam application': qcam_enabled,\n> - 'lc-compliance application': lc_compliance_enabled,\n> 'Unit tests': test_enabled,\n> },\n> section : 'Configuration',\n> diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> index 0fd8462700a9..efd4c268db56 100644\n> --- a/src/apps/cam/meson.build\n> +++ b/src/apps/cam/meson.build\n> @@ -1,5 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +cam_options = []\n> +\n> if opt_cam.disabled() or not libevent.found()\n> cam_enabled = false\n> subdir_done()\n> @@ -39,6 +41,7 @@ if libdrm.found()\n> cam_deps += [\n> libdrm,\n> ]\n> + cam_options += 'output-kms'\n> endif\n> \n> if libsdl2.found()\n> @@ -52,6 +55,7 @@ if libsdl2.found()\n> cam_deps += [\n> libsdl2,\n> ]\n> + cam_options += 'output-sdl2'\n> \n> if libjpeg.found()\n> cam_cpp_args += ['-DHAVE_LIBJPEG']\n> @@ -61,6 +65,7 @@ if libsdl2.found()\n> cam_deps += [\n> libjpeg,\n> ]\n> + cam_options += 'jpeg'\n> endif\n> endif\n> \n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index bc3a79196949..bd2f7858e1a3 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -20,3 +20,13 @@ subdir('cam')\n> subdir('qcam')\n> \n> subdir('ipa-verify')\n> +\n> +summary({\n> + 'cam application': cam_enabled,\n> + 'cam options': cam_options,\n> + 'DNG output support': libtiff.found(),\n> + 'qcam application': qcam_enabled,\n> + 'lc-compliance application': lc_compliance_enabled,\n> + },\n> + section : 'Applications',\n> + bool_yn : true)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61242BDCBD\n\tfor ;\n\tMon, 13 Apr 2026 08:25:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8473D62E71;\n\tMon, 13 Apr 2026 10:25:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF69F62846\n\tfor ;\n\tMon, 13 Apr 2026 10:25:15 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C47124F1;\n\tMon, 13 Apr 2026 10:23:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IvvQX32d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776068623;\n\tbh=+tc9Zts3PBCamcltPg8HYaMtfaAxQ9EmohaBH+GW5G4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IvvQX32dyoH23wVhmbmDnuDxuJgka08vwZMOdLfW81Dqu++alvV9ANSjCdo8hc9d7\n\tBCJ52zTRl4mZl45xoWbX4cItv1Pr316PANPm4PyFliRwxQa2k70FLLXCJFrlGiAm86\n\tV4PO6v13gFMtbnmVcJdcJmM/IsPtczxlHSfu+efo=","Message-ID":"<9a6b0596-fe25-4f24-b3f9-fbbd72564c40@ideasonboard.com>","Date":"Mon, 13 Apr 2026 10:25:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] meson: Print missing application options in summary","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405222436.1237846-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405222436.1237846-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38599,"web_url":"https://patchwork.libcamera.org/comment/38599/","msgid":"<177607871170.1874149.4403096477349497751@ping.linuxembedded.co.uk>","date":"2026-04-13T11:11:51","subject":"Re: [PATCH v2] meson: Print missing application options in summary","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-04-13 09:25:11)\n> 2026. 04. 06. 0:24 keltezéssel, Laurent Pinchart írta:\n> > The recently added application options (DNG output support, KMS and SDL2\n> > outputs for cam, and JPEG support for cam) are not printed in the\n> > summary. This makes it more difficult to quickly assess the\n> > configuration when those options are set to the 'auto' value. Add them\n> > to the summary, and move all application configuration options to a\n> > dedicated section of the summary to improve readability.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > Changes since v1:\n> > \n> > - Declare cam_options[] earlier to avoid failures when the cam\n> > application is disabled\n> > ---\n> \n> Looks ok to me.\n> \n> Reviewed-by: Barnabás Pőcze \n\nSeconded,\n\n\nReviewed-by: Kieran Bingham \n\n> \n> \n> > meson.build | 3 ---\n> > src/apps/cam/meson.build | 5 +++++\n> > src/apps/meson.build | 10 ++++++++++\n> > 3 files changed, 15 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 2e2a27ef4c25..a6cfdd07605c 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -305,9 +305,6 @@ summary({\n> > 'GStreamer support': gst_enabled,\n> > 'Python bindings': pycamera_enabled,\n> > 'V4L2 emulation support': v4l2_enabled,\n> > - 'cam application': cam_enabled,\n> > - 'qcam application': qcam_enabled,\n> > - 'lc-compliance application': lc_compliance_enabled,\n> > 'Unit tests': test_enabled,\n> > },\n> > section : 'Configuration',\n> > diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> > index 0fd8462700a9..efd4c268db56 100644\n> > --- a/src/apps/cam/meson.build\n> > +++ b/src/apps/cam/meson.build\n> > @@ -1,5 +1,7 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > +cam_options = []\n> > +\n> > if opt_cam.disabled() or not libevent.found()\n> > cam_enabled = false\n> > subdir_done()\n> > @@ -39,6 +41,7 @@ if libdrm.found()\n> > cam_deps += [\n> > libdrm,\n> > ]\n> > + cam_options += 'output-kms'\n> > endif\n> > \n> > if libsdl2.found()\n> > @@ -52,6 +55,7 @@ if libsdl2.found()\n> > cam_deps += [\n> > libsdl2,\n> > ]\n> > + cam_options += 'output-sdl2'\n> > \n> > if libjpeg.found()\n> > cam_cpp_args += ['-DHAVE_LIBJPEG']\n> > @@ -61,6 +65,7 @@ if libsdl2.found()\n> > cam_deps += [\n> > libjpeg,\n> > ]\n> > + cam_options += 'jpeg'\n> > endif\n> > endif\n> > \n> > diff --git a/src/apps/meson.build b/src/apps/meson.build\n> > index bc3a79196949..bd2f7858e1a3 100644\n> > --- a/src/apps/meson.build\n> > +++ b/src/apps/meson.build\n> > @@ -20,3 +20,13 @@ subdir('cam')\n> > subdir('qcam')\n> > \n> > subdir('ipa-verify')\n> > +\n> > +summary({\n> > + 'cam application': cam_enabled,\n> > + 'cam options': cam_options,\n> > + 'DNG output support': libtiff.found(),\n> > + 'qcam application': qcam_enabled,\n> > + 'lc-compliance application': lc_compliance_enabled,\n> > + },\n> > + section : 'Applications',\n> > + bool_yn : true)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8033C32BB\n\tfor ;\n\tMon, 13 Apr 2026 11:11:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C4B962E84;\n\tMon, 13 Apr 2026 13:11:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9050F6271A\n\tfor ;\n\tMon, 13 Apr 2026 13:11:54 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF33516A;\n\tMon, 13 Apr 2026 13:10:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IqbYt4g1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776078622;\n\tbh=B5wkvAr6jEYE54GLQzw3y86yOLC6zaH3/Q201br4A44=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=IqbYt4g1ReOxv5iV0pHskVqr6BtIBmOfAIcsp/asGhaCdrmFX6mZrxGP5tzMeIMkW\n\tZ8fGIZkPghgKSaNvleH4hsDaoB+OIYkye1nuX9stxeClK9vCXAwA1ZCdwyE1DjqkjA\n\twaVc1yNrA7rkIUpH0BdCoNGlA8oDKrIFgtG6k1MA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<9a6b0596-fe25-4f24-b3f9-fbbd72564c40@ideasonboard.com>","References":"<20260405222436.1237846-1-laurent.pinchart@ideasonboard.com>\n\t<9a6b0596-fe25-4f24-b3f9-fbbd72564c40@ideasonboard.com>","Subject":"Re: [PATCH v2] meson: Print missing application options in summary","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tLaurent Pinchart , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Apr 2026 12:11:51 +0100","Message-ID":"<177607871170.1874149.4403096477349497751@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]