Patch Detail
Show a patch.
GET /api/patches/26/?format=api
{ "id": 26, "url": "https://patchwork.libcamera.org/api/patches/26/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181210220330.20774-1-laurent.pinchart@ideasonboard.com>", "date": "2018-12-10T22:03:30", "name": "[libcamera-devel] libcamera: log: Fix miscellaneous coding style issues", "commit_ref": "ad8934db5b29810003a9a66b9c3a49f559ebff15", "pull_url": null, "state": "accepted", "archived": false, "hash": "f356602a3452eebd6d132955fbadc79aab421640", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26/mbox/", "series": [ { "id": 14, "url": "https://patchwork.libcamera.org/api/series/14/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=14", "date": "2018-12-10T22:03:30", "name": "[libcamera-devel] libcamera: log: Fix miscellaneous coding style issues", "version": 1, "mbox": "https://patchwork.libcamera.org/series/14/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09DE660B0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Dec 2018 23:03:05 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7711054B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Dec 2018 23:03:04 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544479384;\n\tbh=70Vs4LuSYsFnlFYiH+fsCqXCclYD1kc4DLHxFQEHIIY=;\n\th=From:To:Subject:Date:From;\n\tb=GM+UcXVlVwoOIwLo20WEhkzTOVF9g5q735pFXO3Pm9oRjRIUnVmG6mMDdrbVJvhXt\n\tl93iPj/aPjZT5vGxcin/qeGPRhuHawjkl0d6X3vK4vG2Cyp6i0l5/HNh6VWHFIcthZ\n\tVngs0Ma2jabYW7R3h/08AZbrRhjd6vnHX3l/IjEk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 11 Dec 2018 00:03:30 +0200", "Message-Id": "<20181210220330.20774-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: log: Fix miscellaneous coding\n\tstyle issues", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 10 Dec 2018 22:03:05 -0000" }, "content": "Those issues were pointed out during review.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/log.h | 2 +-\n src/libcamera/log.cpp | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\nindex 76acd1520868..41f8a756bf0c 100644\n--- a/src/libcamera/include/log.h\n+++ b/src/libcamera/include/log.h\n@@ -33,6 +33,6 @@ private:\n \n #define LOG(severity) LogMessage(__FILE__, __LINE__, Log##severity).stream()\n \n-};\n+} /* namespace libcamera */\n \n #endif /* __LIBCAMERA_LOG_H__ */\ndiff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex 18ccfa32d8b4..2a3824972c9a 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2018, Google Inc.\n *\n- * log.h - Logging infrastructure\n+ * log.cpp - Logging infrastructure\n */\n \n #include <cstdio>\n@@ -14,7 +14,7 @@\n #include \"utils.h\"\n \n /**\n- * \\file log.h\n+ * \\file log.cpp\n * \\brief Logging infrastructure\n */\n \n@@ -48,7 +48,7 @@ static const char *log_severity_name(LogSeverity severity)\n \t\t\" ERR\",\n \t};\n \n-\tif ((unsigned int)severity < ARRAY_SIZE(names))\n+\tif (static_cast<unsigned int>(severity) < ARRAY_SIZE(names))\n \t\treturn names[severity];\n \telse\n \t\treturn \"UNKN\";\n@@ -78,4 +78,4 @@ LogMessage::~LogMessage()\n \tfflush(stderr);\n }\n \n-};\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel" ] }